Re: [Buildroot] [PATCH 1/1] package/libwebsockets: added option to (re-)enable external poll loop support

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Luca, All,

On 2023-05-19 16:45 +0200, Luca Pesce via buildroot spake thusly:
> Since version 3.2.0, libwebsockets does not compile its external loop support
> code anymore. That code was put under LWS_WITH_EXTERNAL_POLL compile option,
> which defaults to OFF.
> Applications relying on that support need to turn that option on, so let's
> add it to the package.

So, as I understand it, before 3.2.0, this was unconditionally compiled
in, right?

If so, for backward compatibility, should we default this new option to
'y' ?

> For example, when libwebsockets in enabled, mosquitto broker is built with
> websocket support, but its code requires LWS_WITH_EXTERNAL_POLL to be on -
> otherwise, it gives compile-time warning hinting to unusable websocket support:
> https://github.com/eclipse/mosquitto/commit/1b24f625ea4ee77f3c4796ec2233d059f8c7977e

Then, should mosquitto also select this new option?

> Signed-off-by: Luca Pesce <luca.pesce@vimar.com>
> ---
>  package/libwebsockets/Config.in        | 10 ++++++++++
>  package/libwebsockets/libwebsockets.mk |  4 ++++
>  2 files changed, 14 insertions(+)
> 
> diff --git a/package/libwebsockets/Config.in b/package/libwebsockets/Config.in
> index d7b529c..1371717 100644
> --- a/package/libwebsockets/Config.in
> +++ b/package/libwebsockets/Config.in
> @@ -9,5 +9,15 @@ config BR2_PACKAGE_LIBWEBSOCKETS
>  
>  	  https://libwebsockets.org/
>  
> +if BR2_PACKAGE_LIBWEBSOCKETS
> +
> +config BR2_PACKAGE_LIBWEBSOCKETS_EXT_POLL
> +	bool "enable external poll loop support"
> +	default n

'n' is the default, so no need to specify it.

> +	help
> +	  Enable external poll loop support code.

I am not sure I understood this "external poll loop support". Does it
mean that the loop must be handle by the application itself, rather than
bey libwebsocket?

Regards,
Yann E. MORIN.

> +endif
> +
>  comment "libwebsockets needs a toolchain w/ dynamic library"
>  	depends on BR2_STATIC_LIBS
> diff --git a/package/libwebsockets/libwebsockets.mk b/package/libwebsockets/libwebsockets.mk
> index fb0ee66..86756ca 100644
> --- a/package/libwebsockets/libwebsockets.mk
> +++ b/package/libwebsockets/libwebsockets.mk
> @@ -94,4 +94,8 @@ ifeq ($(BR2_SHARED_LIBS),y)
>  LIBWEBSOCKETS_CONF_OPTS += -DLWS_WITH_STATIC=OFF
>  endif
>  
> +ifeq ($(BR2_PACKAGE_LIBWEBSOCKETS_EXT_POLL),y)
> +LIBWEBSOCKETS_CONF_OPTS += -DLWS_WITH_EXTERNAL_POLL=ON
> +endif
> +
>  $(eval $(cmake-package))
> -- 
> 2.7.4
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot