Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Luca Pesce <luca.pesce@vimar.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2 2/2] package/mosquitto: when building with libwebsockets support, select its external loop support option
Date: Wed, 24 May 2023 22:05:20 +0200	[thread overview]
Message-ID: <20230524200520.GF2623@scaer> (raw)
In-Reply-To: <1684917117-10063-2-git-send-email-luca.pesce@vimar.com>

Luca, All,

On 2023-05-24 10:31 +0200, Luca Pesce spake thusly:
> When libwebsockets is enabled, mosquitto broker is built with
> websocket support, but its code requires libwebsockets being built with
> external loop option - otherwise, mosquitto gives a compile-time warning
> hinting to unusable websocket support:
> https://github.com/eclipse/mosquitto/commit/1b24f625ea4ee77f3c4796ec2233d059f8c7977e
> To fix this, select the BR2_PACKAGE_LIBWEBSOCKETS_EXT_POLL option.
> 
> Signed-off-by: Luca Pesce <luca.pesce@vimar.com>

As I applied the libwebsockets option to next, so did I for this patch.

Applied to next, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/mosquitto/Config.in | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/mosquitto/Config.in b/package/mosquitto/Config.in
> index 6fa5f79..8bedf2a 100644
> --- a/package/mosquitto/Config.in
> +++ b/package/mosquitto/Config.in
> @@ -25,6 +25,7 @@ config BR2_PACKAGE_MOSQUITTO_BROKER
>  	depends on BR2_USE_MMU # fork()
>  	depends on !BR2_STATIC_LIBS # include <dlfcn.h>
>  	depends on BR2_PACKAGE_MOSQUITTO
> +	select BR2_PACKAGE_LIBWEBSOCKETS_EXT_POLL if BR2_PACKAGE_LIBWEBSOCKETS
>  	help
>  	  Build and install the mosquitto broker onto target.
>  
> -- 
> 2.7.4
> 

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2023-05-24 20:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-19 14:45 [Buildroot] [PATCH 1/1] package/libwebsockets: added option to (re-)enable external poll loop support Luca Pesce via buildroot
2023-05-21 17:08 ` Yann E. MORIN
2023-05-22  6:34   ` [Buildroot] R: " Pesce Luca via buildroot
2023-05-23 16:27     ` Yann E. MORIN
2023-05-24  6:00       ` [Buildroot] R: " Pesce Luca via buildroot
2023-05-24  6:10         ` Yann E. MORIN
2023-05-24  8:31 ` [Buildroot] [PATCH v2 1/2] " Luca Pesce via buildroot
2023-05-24  8:31   ` [Buildroot] [PATCH v2 2/2] package/mosquitto: when building with libwebsockets support, select its external loop support option Luca Pesce via buildroot
2023-05-24 20:05     ` Yann E. MORIN [this message]
2023-05-24 20:04   ` [Buildroot] [PATCH v2 1/2] package/libwebsockets: added option to (re-)enable external poll loop support Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230524200520.GF2623@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@buildroot.org \
    --cc=luca.pesce@vimar.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox