Re: [Buildroot] [PATCH v2 1/2] package/libwebsockets: added option to (re-)enable external poll loop support

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Luca, All,

On 2023-05-24 10:31 +0200, Luca Pesce spake thusly:
> Since version 3.2.0, libwebsockets does not compile its external loop support
> code anymore. That code was put under LWS_WITH_EXTERNAL_POLL compile option,
> which defaults to OFF.
> Applications relying on that support need to turn that option on, so let's
> add it to the package.
> 
> For example, when libwebsockets is enabled, mosquitto broker is built with
> websocket support, but its code requires LWS_WITH_EXTERNAL_POLL to be on -
> otherwise, it gives compile-time warning hinting to unusable websocket support:
> https://github.com/eclipse/mosquitto/commit/1b24f625ea4ee77f3c4796ec2233d059f8c7977e
> 
> Signed-off-by: Luca Pesce <luca.pesce@vimar.com>

I pondered whether this should go into master or next, and decided it
was not critical enough to go to master.

Indeed, extenal loop support has been disabled since we bumped to 3.2.0,
in commit dda92e2f58d4 (package/libwebsockets: bump version to 3.2.0),
back in October 2019.

So clearly, this was not that critical, as you're the first to notice in
such a long time.

Applied to next, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/libwebsockets/Config.in        | 12 ++++++++++++
>  package/libwebsockets/libwebsockets.mk |  4 ++++
>  2 files changed, 16 insertions(+)
> 
> diff --git a/package/libwebsockets/Config.in b/package/libwebsockets/Config.in
> index d7b529c..05c1326 100644
> --- a/package/libwebsockets/Config.in
> +++ b/package/libwebsockets/Config.in
> @@ -9,5 +9,17 @@ config BR2_PACKAGE_LIBWEBSOCKETS
>  
>  	  https://libwebsockets.org/
>  
> +if BR2_PACKAGE_LIBWEBSOCKETS
> +
> +config BR2_PACKAGE_LIBWEBSOCKETS_EXT_POLL
> +	bool "enable external poll loop support"
> +	default y  # legacy, was previously always enabled
> +	help
> +	  Enable external poll loop support code. This was
> +	  unconditionally compiled in for library versions
> +	  prior to 3.2.0.
> +
> +endif
> +
>  comment "libwebsockets needs a toolchain w/ dynamic library"
>  	depends on BR2_STATIC_LIBS
> diff --git a/package/libwebsockets/libwebsockets.mk b/package/libwebsockets/libwebsockets.mk
> index fb0ee66..86756ca 100644
> --- a/package/libwebsockets/libwebsockets.mk
> +++ b/package/libwebsockets/libwebsockets.mk
> @@ -94,4 +94,8 @@ ifeq ($(BR2_SHARED_LIBS),y)
>  LIBWEBSOCKETS_CONF_OPTS += -DLWS_WITH_STATIC=OFF
>  endif
>  
> +ifeq ($(BR2_PACKAGE_LIBWEBSOCKETS_EXT_POLL),y)
> +LIBWEBSOCKETS_CONF_OPTS += -DLWS_WITH_EXTERNAL_POLL=ON
> +endif
> +
>  $(eval $(cmake-package))
> -- 
> 2.7.4
> 

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot