* [Buildroot] [PATCH 01/10] configs/hifive_unleashed: Update to use OpenSBI 1.2
2023-06-26 16:00 [Buildroot] [PATCH 00/10] riscv: Various fixes and small enhancements Bin Meng
@ 2023-06-26 16:00 ` Bin Meng
2023-06-26 16:00 ` [Buildroot] [PATCH 02/10] configs/hifive_unleashed: Update to use U-Boot v2023.04 Bin Meng
` (9 subsequent siblings)
10 siblings, 0 replies; 21+ messages in thread
From: Bin Meng @ 2023-06-26 16:00 UTC (permalink / raw)
To: buildroot; +Cc: Bin Meng, Alistair Francis, Jan-Benedict Glaw
From: Bin Meng <bmeng@tinylab.org>
Since the rest of RISC-V boards have been switched to use OpenSBI
1.2, let's update hifive_unleashed to use OpenSBI 1.2 too.
Resolves: https://bugs.busybox.net/show_bug.cgi?id=15658
Signed-off-by: Bin Meng <bmeng@tinylab.org>
---
configs/hifive_unleashed_defconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configs/hifive_unleashed_defconfig b/configs/hifive_unleashed_defconfig
index 2b6ee6c08e..0440b14ba5 100644
--- a/configs/hifive_unleashed_defconfig
+++ b/configs/hifive_unleashed_defconfig
@@ -38,7 +38,7 @@ BR2_LINUX_KERNEL_INSTALL_TARGET=y
# Bootloader
BR2_TARGET_OPENSBI=y
BR2_TARGET_OPENSBI_CUSTOM_VERSION=y
-BR2_TARGET_OPENSBI_CUSTOM_VERSION_VALUE="0.9"
+BR2_TARGET_OPENSBI_CUSTOM_VERSION_VALUE="1.2"
BR2_TARGET_OPENSBI_PLAT="generic"
BR2_TARGET_UBOOT=y
BR2_TARGET_UBOOT_CUSTOM_VERSION=y
--
2.34.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 21+ messages in thread* [Buildroot] [PATCH 02/10] configs/hifive_unleashed: Update to use U-Boot v2023.04
2023-06-26 16:00 [Buildroot] [PATCH 00/10] riscv: Various fixes and small enhancements Bin Meng
2023-06-26 16:00 ` [Buildroot] [PATCH 01/10] configs/hifive_unleashed: Update to use OpenSBI 1.2 Bin Meng
@ 2023-06-26 16:00 ` Bin Meng
2023-06-26 16:00 ` [Buildroot] [PATCH 03/10] configs/hifive_unleashed: Enable BR2_RISCV_ISA_CUSTOM_RVA explicitly Bin Meng
` (8 subsequent siblings)
10 siblings, 0 replies; 21+ messages in thread
From: Bin Meng @ 2023-06-26 16:00 UTC (permalink / raw)
To: buildroot; +Cc: Bin Meng, Alistair Francis, Jan-Benedict Glaw
From: Bin Meng <bmeng@tinylab.org>
With upstream commit ae2d9506a36c ("riscv: sifive: Rename fu540 board to unleashed")
in U-Boot v2021.07 release, the defconfig for SiFive Unleashed board
has been changed to sifive_unleashed_defconfig.
Also newer U-Boot has deprecated the usage of SPL_FIT_GENERATOR
to generate u-boot.itb hence there is no 'u-boot.itb' target in
the U-Boot Makefile anymore. Instead binman is used to assemble
the u-boot.itb image.
We will need to switch to BR2_TARGET_UBOOT_FORMAT_CUSTOM for
installing u-boot.itb.
Switch over to use the latest U-Boot v2023.04 release.
Signed-off-by: Bin Meng <bmeng@tinylab.org>
---
configs/hifive_unleashed_defconfig | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/configs/hifive_unleashed_defconfig b/configs/hifive_unleashed_defconfig
index 0440b14ba5..35cb3558f9 100644
--- a/configs/hifive_unleashed_defconfig
+++ b/configs/hifive_unleashed_defconfig
@@ -42,12 +42,13 @@ BR2_TARGET_OPENSBI_CUSTOM_VERSION_VALUE="1.2"
BR2_TARGET_OPENSBI_PLAT="generic"
BR2_TARGET_UBOOT=y
BR2_TARGET_UBOOT_CUSTOM_VERSION=y
-BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2021.01"
+BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2023.04"
BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
-BR2_TARGET_UBOOT_BOARD_DEFCONFIG="sifive_fu540"
+BR2_TARGET_UBOOT_BOARD_DEFCONFIG="sifive_unleashed"
BR2_TARGET_UBOOT_NEEDS_DTC=y
BR2_TARGET_UBOOT_NEEDS_OPENSBI=y
-BR2_TARGET_UBOOT_FORMAT_ITB=y
+BR2_TARGET_UBOOT_FORMAT_CUSTOM=y
+BR2_TARGET_UBOOT_FORMAT_CUSTOM_NAME="u-boot.itb"
BR2_TARGET_UBOOT_SPL=y
# Host tools
--
2.34.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 21+ messages in thread* [Buildroot] [PATCH 03/10] configs/hifive_unleashed: Enable BR2_RISCV_ISA_CUSTOM_RVA explicitly
2023-06-26 16:00 [Buildroot] [PATCH 00/10] riscv: Various fixes and small enhancements Bin Meng
2023-06-26 16:00 ` [Buildroot] [PATCH 01/10] configs/hifive_unleashed: Update to use OpenSBI 1.2 Bin Meng
2023-06-26 16:00 ` [Buildroot] [PATCH 02/10] configs/hifive_unleashed: Update to use U-Boot v2023.04 Bin Meng
@ 2023-06-26 16:00 ` Bin Meng
2023-06-26 16:00 ` [Buildroot] [PATCH 04/10] configs/beaglev_defconfig: " Bin Meng
` (7 subsequent siblings)
10 siblings, 0 replies; 21+ messages in thread
From: Bin Meng @ 2023-06-26 16:00 UTC (permalink / raw)
To: buildroot; +Cc: Bin Meng, Alistair Francis, Jan-Benedict Glaw
From: Bin Meng <bmeng@tinylab.org>
BR2_RISCV_ISA_CUSTOM_RVA is currently not explicitly listed as it is
selected by BR2_riscv_custom. This looks confusing. Let's enable it.
Signed-off-by: Bin Meng <bmeng@tinylab.org>
---
configs/hifive_unleashed_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/configs/hifive_unleashed_defconfig b/configs/hifive_unleashed_defconfig
index 35cb3558f9..80c5e48f96 100644
--- a/configs/hifive_unleashed_defconfig
+++ b/configs/hifive_unleashed_defconfig
@@ -2,6 +2,7 @@
BR2_riscv=y
BR2_riscv_custom=y
BR2_RISCV_ISA_CUSTOM_RVM=y
+BR2_RISCV_ISA_CUSTOM_RVA=y
BR2_RISCV_ISA_CUSTOM_RVF=y
BR2_RISCV_ISA_CUSTOM_RVD=y
BR2_RISCV_ISA_CUSTOM_RVC=y
--
2.34.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 21+ messages in thread* [Buildroot] [PATCH 04/10] configs/beaglev_defconfig: Enable BR2_RISCV_ISA_CUSTOM_RVA explicitly
2023-06-26 16:00 [Buildroot] [PATCH 00/10] riscv: Various fixes and small enhancements Bin Meng
` (2 preceding siblings ...)
2023-06-26 16:00 ` [Buildroot] [PATCH 03/10] configs/hifive_unleashed: Enable BR2_RISCV_ISA_CUSTOM_RVA explicitly Bin Meng
@ 2023-06-26 16:00 ` Bin Meng
2023-06-26 16:00 ` [Buildroot] [PATCH 05/10] arch/Config.in.riscv: Remove BR2_RISCV_ISA_CUSTOM_RVA from BR2_riscv_custom Bin Meng
` (6 subsequent siblings)
10 siblings, 0 replies; 21+ messages in thread
From: Bin Meng @ 2023-06-26 16:00 UTC (permalink / raw)
To: buildroot; +Cc: Bin Meng, Alistair Francis, Jan-Benedict Glaw
From: Bin Meng <bmeng@tinylab.org>
BR2_RISCV_ISA_CUSTOM_RVA is currently not explicitly listed as it is
selected by BR2_riscv_custom. This looks confusing. Let's enable it.
Signed-off-by: Bin Meng <bmeng@tinylab.org>
---
configs/beaglev_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/configs/beaglev_defconfig b/configs/beaglev_defconfig
index 79af8c2ece..42c732b973 100644
--- a/configs/beaglev_defconfig
+++ b/configs/beaglev_defconfig
@@ -1,6 +1,7 @@
BR2_riscv=y
BR2_riscv_custom=y
BR2_RISCV_ISA_CUSTOM_RVM=y
+BR2_RISCV_ISA_CUSTOM_RVA=y
BR2_RISCV_ISA_CUSTOM_RVF=y
BR2_RISCV_ISA_CUSTOM_RVD=y
BR2_RISCV_ISA_CUSTOM_RVC=y
--
2.34.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 21+ messages in thread* [Buildroot] [PATCH 05/10] arch/Config.in.riscv: Remove BR2_RISCV_ISA_CUSTOM_RVA from BR2_riscv_custom
2023-06-26 16:00 [Buildroot] [PATCH 00/10] riscv: Various fixes and small enhancements Bin Meng
` (3 preceding siblings ...)
2023-06-26 16:00 ` [Buildroot] [PATCH 04/10] configs/beaglev_defconfig: " Bin Meng
@ 2023-06-26 16:00 ` Bin Meng
2023-06-26 16:00 ` [Buildroot] [PATCH 06/10] configs: riscv: Drop BR2_TARGET_OPENSBI_CUSTOM_VERSION Bin Meng
` (5 subsequent siblings)
10 siblings, 0 replies; 21+ messages in thread
From: Bin Meng @ 2023-06-26 16:00 UTC (permalink / raw)
To: buildroot; +Cc: Bin Meng, Alistair Francis, Jan-Benedict Glaw
From: Bin Meng <bmeng@tinylab.org>
BR2_riscv_custom should only contain the basic I extension. The A
extension should be optional and selected by board configs.
Signed-off-by: Bin Meng <bmeng@tinylab.org>
---
arch/Config.in.riscv | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/Config.in.riscv b/arch/Config.in.riscv
index b5e84389e0..853e8deb06 100644
--- a/arch/Config.in.riscv
+++ b/arch/Config.in.riscv
@@ -35,7 +35,6 @@ config BR2_riscv_g
config BR2_riscv_custom
bool "Custom architecture"
select BR2_RISCV_ISA_RVI
- select BR2_RISCV_ISA_CUSTOM_RVA
endchoice
--
2.34.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 21+ messages in thread* [Buildroot] [PATCH 06/10] configs: riscv: Drop BR2_TARGET_OPENSBI_CUSTOM_VERSION
2023-06-26 16:00 [Buildroot] [PATCH 00/10] riscv: Various fixes and small enhancements Bin Meng
` (4 preceding siblings ...)
2023-06-26 16:00 ` [Buildroot] [PATCH 05/10] arch/Config.in.riscv: Remove BR2_RISCV_ISA_CUSTOM_RVA from BR2_riscv_custom Bin Meng
@ 2023-06-26 16:00 ` Bin Meng
2023-06-26 17:10 ` Yann E. MORIN
2023-06-26 16:00 ` [Buildroot] [PATCH 07/10] boot/opensbi: Config.in: Cosmetic style fix Bin Meng
` (4 subsequent siblings)
10 siblings, 1 reply; 21+ messages in thread
From: Bin Meng @ 2023-06-26 16:00 UTC (permalink / raw)
To: buildroot; +Cc: Bin Meng, Alistair Francis, Jan-Benedict Glaw
From: Bin Meng <bmeng@tinylab.org>
Since commit 64f1f82385b2 ("boot/opensbi: Bump to version 1.2"),
the default OpenSBI version has been bumped up to 1.2. With that,
there is no need to define a custom version in each RISC-V board's
defconfig files.
Signed-off-by: Bin Meng <bmeng@tinylab.org>
---
configs/hifive_unleashed_defconfig | 2 --
configs/nezha_defconfig | 2 --
configs/qemu_riscv32_virt_defconfig | 2 --
configs/qemu_riscv64_virt_defconfig | 2 --
configs/sipeed_lichee_rv_defconfig | 2 --
configs/sipeed_lichee_rv_dock_defconfig | 2 --
configs/spike_riscv64_defconfig | 2 --
7 files changed, 14 deletions(-)
diff --git a/configs/hifive_unleashed_defconfig b/configs/hifive_unleashed_defconfig
index 80c5e48f96..013a1423c0 100644
--- a/configs/hifive_unleashed_defconfig
+++ b/configs/hifive_unleashed_defconfig
@@ -38,8 +38,6 @@ BR2_LINUX_KERNEL_INSTALL_TARGET=y
# Bootloader
BR2_TARGET_OPENSBI=y
-BR2_TARGET_OPENSBI_CUSTOM_VERSION=y
-BR2_TARGET_OPENSBI_CUSTOM_VERSION_VALUE="1.2"
BR2_TARGET_OPENSBI_PLAT="generic"
BR2_TARGET_UBOOT=y
BR2_TARGET_UBOOT_CUSTOM_VERSION=y
diff --git a/configs/nezha_defconfig b/configs/nezha_defconfig
index dd94707905..b4c5b4d0ba 100644
--- a/configs/nezha_defconfig
+++ b/configs/nezha_defconfig
@@ -15,8 +15,6 @@ BR2_TARGET_ROOTFS_EXT2=y
BR2_TARGET_ROOTFS_EXT2_4=y
# BR2_TARGET_ROOTFS_TAR is not set
BR2_TARGET_OPENSBI=y
-BR2_TARGET_OPENSBI_CUSTOM_VERSION=y
-BR2_TARGET_OPENSBI_CUSTOM_VERSION_VALUE="1.2"
BR2_TARGET_OPENSBI_PLAT="generic"
# BR2_TARGET_OPENSBI_INSTALL_JUMP_IMG is not set
BR2_TARGET_UBOOT=y
diff --git a/configs/qemu_riscv32_virt_defconfig b/configs/qemu_riscv32_virt_defconfig
index 03c871282e..01922ac151 100644
--- a/configs/qemu_riscv32_virt_defconfig
+++ b/configs/qemu_riscv32_virt_defconfig
@@ -25,8 +25,6 @@ BR2_LINUX_KERNEL_IMAGE=y
# Bootloader
BR2_TARGET_OPENSBI=y
-BR2_TARGET_OPENSBI_CUSTOM_VERSION=y
-BR2_TARGET_OPENSBI_CUSTOM_VERSION_VALUE="1.2"
BR2_TARGET_OPENSBI_PLAT="generic"
# host-qemu for gitlab testing
diff --git a/configs/qemu_riscv64_virt_defconfig b/configs/qemu_riscv64_virt_defconfig
index 666500d889..8b729f137d 100644
--- a/configs/qemu_riscv64_virt_defconfig
+++ b/configs/qemu_riscv64_virt_defconfig
@@ -25,8 +25,6 @@ BR2_LINUX_KERNEL_IMAGE=y
# Bootloader
BR2_TARGET_OPENSBI=y
-BR2_TARGET_OPENSBI_CUSTOM_VERSION=y
-BR2_TARGET_OPENSBI_CUSTOM_VERSION_VALUE="1.2"
BR2_TARGET_OPENSBI_PLAT="generic"
# host-qemu for gitlab testing
diff --git a/configs/sipeed_lichee_rv_defconfig b/configs/sipeed_lichee_rv_defconfig
index 750d2d6e3b..8ad587d35f 100644
--- a/configs/sipeed_lichee_rv_defconfig
+++ b/configs/sipeed_lichee_rv_defconfig
@@ -14,8 +14,6 @@ BR2_TARGET_ROOTFS_EXT2=y
BR2_TARGET_ROOTFS_EXT2_4=y
# BR2_TARGET_ROOTFS_TAR is not set
BR2_TARGET_OPENSBI=y
-BR2_TARGET_OPENSBI_CUSTOM_VERSION=y
-BR2_TARGET_OPENSBI_CUSTOM_VERSION_VALUE="1.2"
BR2_TARGET_OPENSBI_PLAT="generic"
# BR2_TARGET_OPENSBI_INSTALL_JUMP_IMG is not set
BR2_TARGET_UBOOT=y
diff --git a/configs/sipeed_lichee_rv_dock_defconfig b/configs/sipeed_lichee_rv_dock_defconfig
index a228cd8cb7..b6ac7aa31f 100644
--- a/configs/sipeed_lichee_rv_dock_defconfig
+++ b/configs/sipeed_lichee_rv_dock_defconfig
@@ -22,8 +22,6 @@ BR2_TARGET_ROOTFS_EXT2=y
BR2_TARGET_ROOTFS_EXT2_4=y
# BR2_TARGET_ROOTFS_TAR is not set
BR2_TARGET_OPENSBI=y
-BR2_TARGET_OPENSBI_CUSTOM_VERSION=y
-BR2_TARGET_OPENSBI_CUSTOM_VERSION_VALUE="1.2"
BR2_TARGET_OPENSBI_PLAT="generic"
# BR2_TARGET_OPENSBI_INSTALL_JUMP_IMG is not set
BR2_TARGET_UBOOT=y
diff --git a/configs/spike_riscv64_defconfig b/configs/spike_riscv64_defconfig
index 73ea566084..a6f746eb3f 100644
--- a/configs/spike_riscv64_defconfig
+++ b/configs/spike_riscv64_defconfig
@@ -9,8 +9,6 @@ BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_6_1=y
BR2_TARGET_ROOTFS_CPIO=y
# BR2_TARGET_ROOTFS_TAR is not set
BR2_TARGET_OPENSBI=y
-BR2_TARGET_OPENSBI_CUSTOM_VERSION=y
-BR2_TARGET_OPENSBI_CUSTOM_VERSION_VALUE="1.2"
BR2_TARGET_OPENSBI_PLAT="generic"
BR2_TARGET_OPENSBI_LINUX_PAYLOAD=y
BR2_PACKAGE_HOST_RISCV_ISA_SIM=y
--
2.34.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 21+ messages in thread* Re: [Buildroot] [PATCH 06/10] configs: riscv: Drop BR2_TARGET_OPENSBI_CUSTOM_VERSION
2023-06-26 16:00 ` [Buildroot] [PATCH 06/10] configs: riscv: Drop BR2_TARGET_OPENSBI_CUSTOM_VERSION Bin Meng
@ 2023-06-26 17:10 ` Yann E. MORIN
2023-06-27 2:11 ` Bin Meng
0 siblings, 1 reply; 21+ messages in thread
From: Yann E. MORIN @ 2023-06-26 17:10 UTC (permalink / raw)
To: Bin Meng; +Cc: Bin Meng, Alistair Francis, Jan-Benedict Glaw, buildroot
Bin, All,
On 2023-06-27 00:00 +0800, Bin Meng spake thusly:
> From: Bin Meng <bmeng@tinylab.org>
>
> Since commit 64f1f82385b2 ("boot/opensbi: Bump to version 1.2"),
> the default OpenSBI version has been bumped up to 1.2. With that,
> there is no need to define a custom version in each RISC-V board's
> defconfig files.
In fact, no, because opensbi is a "critical" component part of the boot
chain and, like uboot or the kernel, we want to pin the version we use
in defconfig files. We only want the v ersion to be bumped in defconfig,
when someone actually tested the defconfig still generates a bootable
system.
Regards,
Yann E. MORIN.
> Signed-off-by: Bin Meng <bmeng@tinylab.org>
> ---
>
> configs/hifive_unleashed_defconfig | 2 --
> configs/nezha_defconfig | 2 --
> configs/qemu_riscv32_virt_defconfig | 2 --
> configs/qemu_riscv64_virt_defconfig | 2 --
> configs/sipeed_lichee_rv_defconfig | 2 --
> configs/sipeed_lichee_rv_dock_defconfig | 2 --
> configs/spike_riscv64_defconfig | 2 --
> 7 files changed, 14 deletions(-)
>
> diff --git a/configs/hifive_unleashed_defconfig b/configs/hifive_unleashed_defconfig
> index 80c5e48f96..013a1423c0 100644
> --- a/configs/hifive_unleashed_defconfig
> +++ b/configs/hifive_unleashed_defconfig
> @@ -38,8 +38,6 @@ BR2_LINUX_KERNEL_INSTALL_TARGET=y
>
> # Bootloader
> BR2_TARGET_OPENSBI=y
> -BR2_TARGET_OPENSBI_CUSTOM_VERSION=y
> -BR2_TARGET_OPENSBI_CUSTOM_VERSION_VALUE="1.2"
> BR2_TARGET_OPENSBI_PLAT="generic"
> BR2_TARGET_UBOOT=y
> BR2_TARGET_UBOOT_CUSTOM_VERSION=y
> diff --git a/configs/nezha_defconfig b/configs/nezha_defconfig
> index dd94707905..b4c5b4d0ba 100644
> --- a/configs/nezha_defconfig
> +++ b/configs/nezha_defconfig
> @@ -15,8 +15,6 @@ BR2_TARGET_ROOTFS_EXT2=y
> BR2_TARGET_ROOTFS_EXT2_4=y
> # BR2_TARGET_ROOTFS_TAR is not set
> BR2_TARGET_OPENSBI=y
> -BR2_TARGET_OPENSBI_CUSTOM_VERSION=y
> -BR2_TARGET_OPENSBI_CUSTOM_VERSION_VALUE="1.2"
> BR2_TARGET_OPENSBI_PLAT="generic"
> # BR2_TARGET_OPENSBI_INSTALL_JUMP_IMG is not set
> BR2_TARGET_UBOOT=y
> diff --git a/configs/qemu_riscv32_virt_defconfig b/configs/qemu_riscv32_virt_defconfig
> index 03c871282e..01922ac151 100644
> --- a/configs/qemu_riscv32_virt_defconfig
> +++ b/configs/qemu_riscv32_virt_defconfig
> @@ -25,8 +25,6 @@ BR2_LINUX_KERNEL_IMAGE=y
>
> # Bootloader
> BR2_TARGET_OPENSBI=y
> -BR2_TARGET_OPENSBI_CUSTOM_VERSION=y
> -BR2_TARGET_OPENSBI_CUSTOM_VERSION_VALUE="1.2"
> BR2_TARGET_OPENSBI_PLAT="generic"
>
> # host-qemu for gitlab testing
> diff --git a/configs/qemu_riscv64_virt_defconfig b/configs/qemu_riscv64_virt_defconfig
> index 666500d889..8b729f137d 100644
> --- a/configs/qemu_riscv64_virt_defconfig
> +++ b/configs/qemu_riscv64_virt_defconfig
> @@ -25,8 +25,6 @@ BR2_LINUX_KERNEL_IMAGE=y
>
> # Bootloader
> BR2_TARGET_OPENSBI=y
> -BR2_TARGET_OPENSBI_CUSTOM_VERSION=y
> -BR2_TARGET_OPENSBI_CUSTOM_VERSION_VALUE="1.2"
> BR2_TARGET_OPENSBI_PLAT="generic"
>
> # host-qemu for gitlab testing
> diff --git a/configs/sipeed_lichee_rv_defconfig b/configs/sipeed_lichee_rv_defconfig
> index 750d2d6e3b..8ad587d35f 100644
> --- a/configs/sipeed_lichee_rv_defconfig
> +++ b/configs/sipeed_lichee_rv_defconfig
> @@ -14,8 +14,6 @@ BR2_TARGET_ROOTFS_EXT2=y
> BR2_TARGET_ROOTFS_EXT2_4=y
> # BR2_TARGET_ROOTFS_TAR is not set
> BR2_TARGET_OPENSBI=y
> -BR2_TARGET_OPENSBI_CUSTOM_VERSION=y
> -BR2_TARGET_OPENSBI_CUSTOM_VERSION_VALUE="1.2"
> BR2_TARGET_OPENSBI_PLAT="generic"
> # BR2_TARGET_OPENSBI_INSTALL_JUMP_IMG is not set
> BR2_TARGET_UBOOT=y
> diff --git a/configs/sipeed_lichee_rv_dock_defconfig b/configs/sipeed_lichee_rv_dock_defconfig
> index a228cd8cb7..b6ac7aa31f 100644
> --- a/configs/sipeed_lichee_rv_dock_defconfig
> +++ b/configs/sipeed_lichee_rv_dock_defconfig
> @@ -22,8 +22,6 @@ BR2_TARGET_ROOTFS_EXT2=y
> BR2_TARGET_ROOTFS_EXT2_4=y
> # BR2_TARGET_ROOTFS_TAR is not set
> BR2_TARGET_OPENSBI=y
> -BR2_TARGET_OPENSBI_CUSTOM_VERSION=y
> -BR2_TARGET_OPENSBI_CUSTOM_VERSION_VALUE="1.2"
> BR2_TARGET_OPENSBI_PLAT="generic"
> # BR2_TARGET_OPENSBI_INSTALL_JUMP_IMG is not set
> BR2_TARGET_UBOOT=y
> diff --git a/configs/spike_riscv64_defconfig b/configs/spike_riscv64_defconfig
> index 73ea566084..a6f746eb3f 100644
> --- a/configs/spike_riscv64_defconfig
> +++ b/configs/spike_riscv64_defconfig
> @@ -9,8 +9,6 @@ BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_6_1=y
> BR2_TARGET_ROOTFS_CPIO=y
> # BR2_TARGET_ROOTFS_TAR is not set
> BR2_TARGET_OPENSBI=y
> -BR2_TARGET_OPENSBI_CUSTOM_VERSION=y
> -BR2_TARGET_OPENSBI_CUSTOM_VERSION_VALUE="1.2"
> BR2_TARGET_OPENSBI_PLAT="generic"
> BR2_TARGET_OPENSBI_LINUX_PAYLOAD=y
> BR2_PACKAGE_HOST_RISCV_ISA_SIM=y
> --
> 2.34.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 21+ messages in thread* Re: [Buildroot] [PATCH 06/10] configs: riscv: Drop BR2_TARGET_OPENSBI_CUSTOM_VERSION
2023-06-26 17:10 ` Yann E. MORIN
@ 2023-06-27 2:11 ` Bin Meng
2023-06-27 20:39 ` Yann E. MORIN
0 siblings, 1 reply; 21+ messages in thread
From: Bin Meng @ 2023-06-27 2:11 UTC (permalink / raw)
To: Yann E. MORIN; +Cc: Bin Meng, Alistair Francis, Jan-Benedict Glaw, buildroot
Hi Yann,
On Tue, Jun 27, 2023 at 1:10 AM Yann E. MORIN <yann.morin.1998@free.fr> wrote:
>
> Bin, All,
>
> On 2023-06-27 00:00 +0800, Bin Meng spake thusly:
> > From: Bin Meng <bmeng@tinylab.org>
> >
> > Since commit 64f1f82385b2 ("boot/opensbi: Bump to version 1.2"),
> > the default OpenSBI version has been bumped up to 1.2. With that,
> > there is no need to define a custom version in each RISC-V board's
> > defconfig files.
>
> In fact, no, because opensbi is a "critical" component part of the boot
> chain and, like uboot or the kernel, we want to pin the version we use
> in defconfig files. We only want the v ersion to be bumped in defconfig,
> when someone actually tested the defconfig still generates a bootable
> system.
Makes sense to me.
But I would argue at least we should update
qemu_riscv32_virt_defconfig and qemu_riscv64_virt_defconfig to use the
latest OpenSBI due to the reason that:
1. they are the main platforms to develop and test OpenSBI
2. latest OpenSBI binaries will always be integrated into QEMU as the
default bios
thoughts?
Regards,
Bin
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 21+ messages in thread* Re: [Buildroot] [PATCH 06/10] configs: riscv: Drop BR2_TARGET_OPENSBI_CUSTOM_VERSION
2023-06-27 2:11 ` Bin Meng
@ 2023-06-27 20:39 ` Yann E. MORIN
0 siblings, 0 replies; 21+ messages in thread
From: Yann E. MORIN @ 2023-06-27 20:39 UTC (permalink / raw)
To: Bin Meng; +Cc: Bin Meng, Alistair Francis, Jan-Benedict Glaw, buildroot
Bin, All,
On 2023-06-27 10:11 +0800, Bin Meng spake thusly:
> On Tue, Jun 27, 2023 at 1:10 AM Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> > On 2023-06-27 00:00 +0800, Bin Meng spake thusly:
> > > From: Bin Meng <bmeng@tinylab.org>
> > > Since commit 64f1f82385b2 ("boot/opensbi: Bump to version 1.2"),
> > > the default OpenSBI version has been bumped up to 1.2. With that,
> > > there is no need to define a custom version in each RISC-V board's
> > > defconfig files.
> > In fact, no, because opensbi is a "critical" component part of the boot
> > chain and, like uboot or the kernel, we want to pin the version we use
> > in defconfig files. We only want the v ersion to be bumped in defconfig,
> > when someone actually tested the defconfig still generates a bootable
> > system.
> Makes sense to me.
> But I would argue at least we should update
> qemu_riscv32_virt_defconfig and qemu_riscv64_virt_defconfig to use the
> latest OpenSBI due to the reason that:
> 1. they are the main platforms to develop and test OpenSBI
> 2. latest OpenSBI binaries will always be integrated into QEMU as the
> default bios
> thoughts?
For the qemu defconfigs, I wouild indeed understand that we use the
latest version; the rationale looks sound.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 21+ messages in thread
* [Buildroot] [PATCH 07/10] boot/opensbi: Config.in: Cosmetic style fix
2023-06-26 16:00 [Buildroot] [PATCH 00/10] riscv: Various fixes and small enhancements Bin Meng
` (5 preceding siblings ...)
2023-06-26 16:00 ` [Buildroot] [PATCH 06/10] configs: riscv: Drop BR2_TARGET_OPENSBI_CUSTOM_VERSION Bin Meng
@ 2023-06-26 16:00 ` Bin Meng
2023-06-26 16:00 ` [Buildroot] [PATCH 08/10] boot/opensbi: Bump to version 1.3 Bin Meng
` (3 subsequent siblings)
10 siblings, 0 replies; 21+ messages in thread
From: Bin Meng @ 2023-06-26 16:00 UTC (permalink / raw)
To: buildroot; +Cc: Bin Meng, Alistair Francis, Jan-Benedict Glaw
From: Bin Meng <bmeng@tinylab.org>
Use space intead of tab before 'if'.
Signed-off-by: Bin Meng <bmeng@tinylab.org>
---
boot/opensbi/Config.in | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/boot/opensbi/Config.in b/boot/opensbi/Config.in
index 5e6b8d158e..99c4989479 100644
--- a/boot/opensbi/Config.in
+++ b/boot/opensbi/Config.in
@@ -57,10 +57,10 @@ endif
config BR2_TARGET_OPENSBI_VERSION
string
- default "1.2" if BR2_TARGET_OPENSBI_LATEST_VERSION
+ default "1.2" if BR2_TARGET_OPENSBI_LATEST_VERSION
default BR2_TARGET_OPENSBI_CUSTOM_VERSION_VALUE \
if BR2_TARGET_OPENSBI_CUSTOM_VERSION
- default "custom" if BR2_TARGET_OPENSBI_CUSTOM_TARBALL
+ default "custom" if BR2_TARGET_OPENSBI_CUSTOM_TARBALL
default BR2_TARGET_OPENSBI_CUSTOM_REPO_VERSION \
if BR2_TARGET_OPENSBI_CUSTOM_GIT
--
2.34.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 21+ messages in thread* [Buildroot] [PATCH 08/10] boot/opensbi: Bump to version 1.3
2023-06-26 16:00 [Buildroot] [PATCH 00/10] riscv: Various fixes and small enhancements Bin Meng
` (6 preceding siblings ...)
2023-06-26 16:00 ` [Buildroot] [PATCH 07/10] boot/opensbi: Config.in: Cosmetic style fix Bin Meng
@ 2023-06-26 16:00 ` Bin Meng
2023-06-26 16:00 ` [Buildroot] [PATCH 09/10] board/sifive: hifive-unleashed: Update rootfs offset Bin Meng
` (2 subsequent siblings)
10 siblings, 0 replies; 21+ messages in thread
From: Bin Meng @ 2023-06-26 16:00 UTC (permalink / raw)
To: buildroot; +Cc: Bin Meng, Alistair Francis, Jan-Benedict Glaw
From: Bin Meng <bmeng@tinylab.org>
Signed-off-by: Bin Meng <bmeng@tinylab.org>
---
boot/opensbi/Config.in | 4 ++--
boot/opensbi/opensbi.hash | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/boot/opensbi/Config.in b/boot/opensbi/Config.in
index 99c4989479..de2f0aae20 100644
--- a/boot/opensbi/Config.in
+++ b/boot/opensbi/Config.in
@@ -19,7 +19,7 @@ choice
Select the specific OpenSBI version you want to use
config BR2_TARGET_OPENSBI_LATEST_VERSION
- bool "1.2"
+ bool "1.3"
config BR2_TARGET_OPENSBI_CUSTOM_VERSION
bool "Custom version"
@@ -57,7 +57,7 @@ endif
config BR2_TARGET_OPENSBI_VERSION
string
- default "1.2" if BR2_TARGET_OPENSBI_LATEST_VERSION
+ default "1.3" if BR2_TARGET_OPENSBI_LATEST_VERSION
default BR2_TARGET_OPENSBI_CUSTOM_VERSION_VALUE \
if BR2_TARGET_OPENSBI_CUSTOM_VERSION
default "custom" if BR2_TARGET_OPENSBI_CUSTOM_TARBALL
diff --git a/boot/opensbi/opensbi.hash b/boot/opensbi/opensbi.hash
index dbc77e856f..980fb141dc 100644
--- a/boot/opensbi/opensbi.hash
+++ b/boot/opensbi/opensbi.hash
@@ -1,3 +1,3 @@
# locally computed
-sha256 8fcbce598a73acc2c7f7d5607d46b9d5107d3ecbede8f68f42631dcfc25ef2b2 opensbi-1.2.tar.gz
+sha256 2c0501eb3475f463b15f5b8531996f64604ea49e0e3ed040ecbd1fc27ecd8c5c opensbi-1.3.tar.gz
sha256 82d13fb1bf6bb162629deeea9eb9c117e74548d3b707e478967691fe79a68e21 COPYING.BSD
--
2.34.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 21+ messages in thread* [Buildroot] [PATCH 09/10] board/sifive: hifive-unleashed: Update rootfs offset
2023-06-26 16:00 [Buildroot] [PATCH 00/10] riscv: Various fixes and small enhancements Bin Meng
` (7 preceding siblings ...)
2023-06-26 16:00 ` [Buildroot] [PATCH 08/10] boot/opensbi: Bump to version 1.3 Bin Meng
@ 2023-06-26 16:00 ` Bin Meng
2023-06-26 17:12 ` Yann E. MORIN
2023-08-12 21:12 ` Thomas Petazzoni via buildroot
2023-06-26 16:00 ` [Buildroot] [PATCH 10/10] board/sifive: hifive-unleashed: Include QEMU instructions in readme.txt Bin Meng
2023-06-26 17:04 ` [Buildroot] [PATCH 00/10] riscv: Various fixes and small enhancements Yann E. MORIN
10 siblings, 2 replies; 21+ messages in thread
From: Bin Meng @ 2023-06-26 16:00 UTC (permalink / raw)
To: buildroot; +Cc: Bin Meng, Alistair Francis, Jan-Benedict Glaw
From: Bin Meng <bmeng@tinylab.org>
As the rootfs size is set to 60M, let's put it right on the 4M offset
in the SD card, so that the generated sdcard.img can be exactly 64M.
Signed-off-by: Bin Meng <bmeng@tinylab.org>
---
board/sifive/hifive-unleashed/genimage_sdcard.cfg | 1 +
1 file changed, 1 insertion(+)
diff --git a/board/sifive/hifive-unleashed/genimage_sdcard.cfg b/board/sifive/hifive-unleashed/genimage_sdcard.cfg
index 079ac5ed26..99e3525a8c 100644
--- a/board/sifive/hifive-unleashed/genimage_sdcard.cfg
+++ b/board/sifive/hifive-unleashed/genimage_sdcard.cfg
@@ -17,6 +17,7 @@ image sdcard.img {
partition rootfs {
image = "rootfs.ext4"
+ offset = 4076K
partition-type-uuid = 0fc63daf-8483-4772-8e79-3d69d8477de4
bootable = true
}
--
2.34.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 21+ messages in thread* Re: [Buildroot] [PATCH 09/10] board/sifive: hifive-unleashed: Update rootfs offset
2023-06-26 16:00 ` [Buildroot] [PATCH 09/10] board/sifive: hifive-unleashed: Update rootfs offset Bin Meng
@ 2023-06-26 17:12 ` Yann E. MORIN
2023-08-12 21:12 ` Thomas Petazzoni via buildroot
1 sibling, 0 replies; 21+ messages in thread
From: Yann E. MORIN @ 2023-06-26 17:12 UTC (permalink / raw)
To: Bin Meng; +Cc: Bin Meng, Alistair Francis, Jan-Benedict Glaw, buildroot
Bin, All,
On 2023-06-27 00:00 +0800, Bin Meng spake thusly:
> From: Bin Meng <bmeng@tinylab.org>
>
> As the rootfs size is set to 60M, let's put it right on the 4M offset
> in the SD card, so that the generated sdcard.img can be exactly 64M.
As much I like power-of-two numbers, is there a technical reason to hit
exactly 64MiB?
Regards,
Yann E. MORIN.
> Signed-off-by: Bin Meng <bmeng@tinylab.org>
> ---
>
> board/sifive/hifive-unleashed/genimage_sdcard.cfg | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/board/sifive/hifive-unleashed/genimage_sdcard.cfg b/board/sifive/hifive-unleashed/genimage_sdcard.cfg
> index 079ac5ed26..99e3525a8c 100644
> --- a/board/sifive/hifive-unleashed/genimage_sdcard.cfg
> +++ b/board/sifive/hifive-unleashed/genimage_sdcard.cfg
> @@ -17,6 +17,7 @@ image sdcard.img {
>
> partition rootfs {
> image = "rootfs.ext4"
> + offset = 4076K
> partition-type-uuid = 0fc63daf-8483-4772-8e79-3d69d8477de4
> bootable = true
> }
> --
> 2.34.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 21+ messages in thread* Re: [Buildroot] [PATCH 09/10] board/sifive: hifive-unleashed: Update rootfs offset
2023-06-26 16:00 ` [Buildroot] [PATCH 09/10] board/sifive: hifive-unleashed: Update rootfs offset Bin Meng
2023-06-26 17:12 ` Yann E. MORIN
@ 2023-08-12 21:12 ` Thomas Petazzoni via buildroot
1 sibling, 0 replies; 21+ messages in thread
From: Thomas Petazzoni via buildroot @ 2023-08-12 21:12 UTC (permalink / raw)
To: Bin Meng; +Cc: Bin Meng, Alistair Francis, Jan-Benedict Glaw, buildroot
On Tue, 27 Jun 2023 00:00:29 +0800
Bin Meng <bmeng.cn@gmail.com> wrote:
> From: Bin Meng <bmeng@tinylab.org>
>
> As the rootfs size is set to 60M, let's put it right on the 4M offset
> in the SD card, so that the generated sdcard.img can be exactly 64M.
>
> Signed-off-by: Bin Meng <bmeng@tinylab.org>
> ---
Applied to next after adding more explanations about the "why 64 MB":
because Qemu requires power of two sizes for the image files.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 21+ messages in thread
* [Buildroot] [PATCH 10/10] board/sifive: hifive-unleashed: Include QEMU instructions in readme.txt
2023-06-26 16:00 [Buildroot] [PATCH 00/10] riscv: Various fixes and small enhancements Bin Meng
` (8 preceding siblings ...)
2023-06-26 16:00 ` [Buildroot] [PATCH 09/10] board/sifive: hifive-unleashed: Update rootfs offset Bin Meng
@ 2023-06-26 16:00 ` Bin Meng
2023-06-26 17:21 ` Yann E. MORIN
2023-08-12 21:14 ` Thomas Petazzoni via buildroot
2023-06-26 17:04 ` [Buildroot] [PATCH 00/10] riscv: Various fixes and small enhancements Yann E. MORIN
10 siblings, 2 replies; 21+ messages in thread
From: Bin Meng @ 2023-06-26 16:00 UTC (permalink / raw)
To: buildroot; +Cc: Bin Meng, Alistair Francis, Jan-Benedict Glaw
From: Bin Meng <bmeng@tinylab.org>
The upstream QEMU 'sifive_u' machine supports running upstream U-Boot
for the SiFive HiFive Unleashed board out of the box.
Add the QEMU instructions for testing in readme.txt.
Signed-off-by: Bin Meng <bmeng@tinylab.org>
---
board/sifive/hifive-unleashed/readme.txt | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/board/sifive/hifive-unleashed/readme.txt b/board/sifive/hifive-unleashed/readme.txt
index 3263913e9c..e9ccb26fa6 100644
--- a/board/sifive/hifive-unleashed/readme.txt
+++ b/board/sifive/hifive-unleashed/readme.txt
@@ -113,3 +113,20 @@ Booting the SPI flash on the board
Make sure that the all DIP switches are set to the off position for
default boot mode (MSEL mode = 0110) to boot from SPI flash.
+
+Testing under QEMU
+==================
+
+The SD card image can be tested using QEMU:
+
+$ qemu-system-riscv64 -M sifive_u,msel=11 -smp 5 -m 8G \
+ -display none -serial stdio -nic user \
+ -bios output/images/u-boot-spl.bin \
+ -drive file=output/images/sdcard.img,if=sd
+
+The SPI flash image can be tested with a slightly different command:
+
+$ qemu-system-riscv64 -M sifive_u,msel=6 -smp 5 -m 8G \
+ -display none -serial stdio -nic user \
+ -bios output/images/u-boot-spl.bin \
+ -drive file=output/images/spi-nor.img,if=mtd
--
2.34.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 21+ messages in thread* Re: [Buildroot] [PATCH 10/10] board/sifive: hifive-unleashed: Include QEMU instructions in readme.txt
2023-06-26 16:00 ` [Buildroot] [PATCH 10/10] board/sifive: hifive-unleashed: Include QEMU instructions in readme.txt Bin Meng
@ 2023-06-26 17:21 ` Yann E. MORIN
2023-06-27 0:32 ` Alistair Francis
2023-08-12 21:14 ` Thomas Petazzoni via buildroot
1 sibling, 1 reply; 21+ messages in thread
From: Yann E. MORIN @ 2023-06-26 17:21 UTC (permalink / raw)
To: Bin Meng; +Cc: Bin Meng, Alistair Francis, Jan-Benedict Glaw, buildroot
Bin, All,
On 2023-06-27 00:00 +0800, Bin Meng spake thusly:
> From: Bin Meng <bmeng@tinylab.org>
>
> The upstream QEMU 'sifive_u' machine supports running upstream U-Boot
> for the SiFive HiFive Unleashed board out of the box.
>
> Add the QEMU instructions for testing in readme.txt.
Ah, is the 64MiB SDcard required to be bootable under qemu?
I.e. is it the same issue as fixed by 6f9e83f5f74d (support/testing:
test_ubi: reduce the rootfs.ubi size to 64M to match the Qemu emulated
flash device)?
Regards,
Yann E. MORIN.
> Signed-off-by: Bin Meng <bmeng@tinylab.org>
> ---
>
> board/sifive/hifive-unleashed/readme.txt | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/board/sifive/hifive-unleashed/readme.txt b/board/sifive/hifive-unleashed/readme.txt
> index 3263913e9c..e9ccb26fa6 100644
> --- a/board/sifive/hifive-unleashed/readme.txt
> +++ b/board/sifive/hifive-unleashed/readme.txt
> @@ -113,3 +113,20 @@ Booting the SPI flash on the board
>
> Make sure that the all DIP switches are set to the off position for
> default boot mode (MSEL mode = 0110) to boot from SPI flash.
> +
> +Testing under QEMU
> +==================
> +
> +The SD card image can be tested using QEMU:
> +
> +$ qemu-system-riscv64 -M sifive_u,msel=11 -smp 5 -m 8G \
> + -display none -serial stdio -nic user \
> + -bios output/images/u-boot-spl.bin \
> + -drive file=output/images/sdcard.img,if=sd
> +
> +The SPI flash image can be tested with a slightly different command:
> +
> +$ qemu-system-riscv64 -M sifive_u,msel=6 -smp 5 -m 8G \
> + -display none -serial stdio -nic user \
> + -bios output/images/u-boot-spl.bin \
> + -drive file=output/images/spi-nor.img,if=mtd
> --
> 2.34.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [Buildroot] [PATCH 10/10] board/sifive: hifive-unleashed: Include QEMU instructions in readme.txt
2023-06-26 17:21 ` Yann E. MORIN
@ 2023-06-27 0:32 ` Alistair Francis
2023-06-28 15:15 ` Bin Meng
0 siblings, 1 reply; 21+ messages in thread
From: Alistair Francis @ 2023-06-27 0:32 UTC (permalink / raw)
To: Yann E. MORIN
Cc: Bin Meng, Bin Meng, Alistair Francis, Jan-Benedict Glaw,
buildroot
On Tue, Jun 27, 2023 at 3:21 AM Yann E. MORIN <yann.morin.1998@free.fr> wrote:
>
> Bin, All,
>
> On 2023-06-27 00:00 +0800, Bin Meng spake thusly:
> > From: Bin Meng <bmeng@tinylab.org>
> >
> > The upstream QEMU 'sifive_u' machine supports running upstream U-Boot
> > for the SiFive HiFive Unleashed board out of the box.
> >
> > Add the QEMU instructions for testing in readme.txt.
>
> Ah, is the 64MiB SDcard required to be bootable under qemu?
Yes, QEMU requires the SD card to be a power of 2
https://gitlab.com/qemu-project/qemu/-/commit/a9bcedd15a5834ca9ae6c3a97933e85ac7edbd36
Alistair
>
> I.e. is it the same issue as fixed by 6f9e83f5f74d (support/testing:
> test_ubi: reduce the rootfs.ubi size to 64M to match the Qemu emulated
> flash device)?
>
> Regards,
> Yann E. MORIN.
>
> > Signed-off-by: Bin Meng <bmeng@tinylab.org>
> > ---
> >
> > board/sifive/hifive-unleashed/readme.txt | 17 +++++++++++++++++
> > 1 file changed, 17 insertions(+)
> >
> > diff --git a/board/sifive/hifive-unleashed/readme.txt b/board/sifive/hifive-unleashed/readme.txt
> > index 3263913e9c..e9ccb26fa6 100644
> > --- a/board/sifive/hifive-unleashed/readme.txt
> > +++ b/board/sifive/hifive-unleashed/readme.txt
> > @@ -113,3 +113,20 @@ Booting the SPI flash on the board
> >
> > Make sure that the all DIP switches are set to the off position for
> > default boot mode (MSEL mode = 0110) to boot from SPI flash.
> > +
> > +Testing under QEMU
> > +==================
> > +
> > +The SD card image can be tested using QEMU:
> > +
> > +$ qemu-system-riscv64 -M sifive_u,msel=11 -smp 5 -m 8G \
> > + -display none -serial stdio -nic user \
> > + -bios output/images/u-boot-spl.bin \
> > + -drive file=output/images/sdcard.img,if=sd
> > +
> > +The SPI flash image can be tested with a slightly different command:
> > +
> > +$ qemu-system-riscv64 -M sifive_u,msel=6 -smp 5 -m 8G \
> > + -display none -serial stdio -nic user \
> > + -bios output/images/u-boot-spl.bin \
> > + -drive file=output/images/spi-nor.img,if=mtd
> > --
> > 2.34.1
> >
> > _______________________________________________
> > buildroot mailing list
> > buildroot@buildroot.org
> > https://lists.buildroot.org/mailman/listinfo/buildroot
>
> --
> .-----------------.--------------------.------------------.--------------------.
> | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
> | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
> '------------------------------^-------^------------------^--------------------'
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [Buildroot] [PATCH 10/10] board/sifive: hifive-unleashed: Include QEMU instructions in readme.txt
2023-06-27 0:32 ` Alistair Francis
@ 2023-06-28 15:15 ` Bin Meng
0 siblings, 0 replies; 21+ messages in thread
From: Bin Meng @ 2023-06-28 15:15 UTC (permalink / raw)
To: Alistair Francis
Cc: Bin Meng, Alistair Francis, Yann E. MORIN, Jan-Benedict Glaw,
buildroot
Hi Yann,
On Tue, Jun 27, 2023 at 8:32 AM Alistair Francis <alistair23@gmail.com> wrote:
>
> On Tue, Jun 27, 2023 at 3:21 AM Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> >
> > Bin, All,
> >
> > On 2023-06-27 00:00 +0800, Bin Meng spake thusly:
> > > From: Bin Meng <bmeng@tinylab.org>
> > >
> > > The upstream QEMU 'sifive_u' machine supports running upstream U-Boot
> > > for the SiFive HiFive Unleashed board out of the box.
> > >
> > > Add the QEMU instructions for testing in readme.txt.
> >
> > Ah, is the 64MiB SDcard required to be bootable under qemu?
>
> Yes, QEMU requires the SD card to be a power of 2
>
> https://gitlab.com/qemu-project/qemu/-/commit/a9bcedd15a5834ca9ae6c3a97933e85ac7edbd36
>
How about these 2 patches? Do they look good?
Regards,
Bin
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [Buildroot] [PATCH 10/10] board/sifive: hifive-unleashed: Include QEMU instructions in readme.txt
2023-06-26 16:00 ` [Buildroot] [PATCH 10/10] board/sifive: hifive-unleashed: Include QEMU instructions in readme.txt Bin Meng
2023-06-26 17:21 ` Yann E. MORIN
@ 2023-08-12 21:14 ` Thomas Petazzoni via buildroot
1 sibling, 0 replies; 21+ messages in thread
From: Thomas Petazzoni via buildroot @ 2023-08-12 21:14 UTC (permalink / raw)
To: Bin Meng
Cc: Romain Naour, Bin Meng, Alistair Francis, Jan-Benedict Glaw,
buildroot
Hello,
+Romain Naour in Cc.
On Tue, 27 Jun 2023 00:00:30 +0800
Bin Meng <bmeng.cn@gmail.com> wrote:
> From: Bin Meng <bmeng@tinylab.org>
>
> The upstream QEMU 'sifive_u' machine supports running upstream U-Boot
> for the SiFive HiFive Unleashed board out of the box.
>
> Add the QEMU instructions for testing in readme.txt.
>
> Signed-off-by: Bin Meng <bmeng@tinylab.org>
> ---
Applied to next, thanks.
Now that this defconfig can be booted under Qemu, maybe it makes sense
to ensure that our Gitlab CI does some actual testing of the
"bootability" of this image under Qemu? Could you have a look at how
our qemu_* defconfigs do this, and try to adapt the HiFive Unleashed
defconfig to do the same? Romain Naour in Cc is the author/maintainer
of this logic that all the testing of Qemu defconfigs in our CI, so I'm
sure he can provide guidance if needed.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [Buildroot] [PATCH 00/10] riscv: Various fixes and small enhancements
2023-06-26 16:00 [Buildroot] [PATCH 00/10] riscv: Various fixes and small enhancements Bin Meng
` (9 preceding siblings ...)
2023-06-26 16:00 ` [Buildroot] [PATCH 10/10] board/sifive: hifive-unleashed: Include QEMU instructions in readme.txt Bin Meng
@ 2023-06-26 17:04 ` Yann E. MORIN
10 siblings, 0 replies; 21+ messages in thread
From: Yann E. MORIN @ 2023-06-26 17:04 UTC (permalink / raw)
To: Bin Meng; +Cc: Alistair Francis, Jan-Benedict Glaw, buildroot
Bin, All,
On 2023-06-27 00:00 +0800, Bin Meng spake thusly:
> A bug report [1] was filed recently against HiFive Unleashed board that
> it did not build. Although I could not reproduce the build failure, it
> does make sense to upgrade the OpenSBI version for this board, as
> discussed in the bug report.
>
> Now OpenSBI version is bumped up to 1.3 in this series for all RISC-V
> boards. For HiFive Unleashed board I decided to use the latest U-Boot
> release as well, which requires some new changes.
>
> The Kconfig options of RISC-V boards have been cleaned up. Instructions
> of using QEMU to test the HiFive Unleashed board images are added.
>
> [1] https://bugs.busybox.net/show_bug.cgi?id=15658
>
>
> Bin Meng (10):
> configs/hifive_unleashed: Update to use OpenSBI 1.2
> configs/hifive_unleashed: Update to use U-Boot v2023.04
> configs/hifive_unleashed: Enable BR2_RISCV_ISA_CUSTOM_RVA explicitly
> configs/beaglev_defconfig: Enable BR2_RISCV_ISA_CUSTOM_RVA explicitly
> arch/Config.in.riscv: Remove BR2_RISCV_ISA_CUSTOM_RVA from
> BR2_riscv_custom
I've applied the first fice patches to master.
> configs: riscv: Drop BR2_TARGET_OPENSBI_CUSTOM_VERSION
I'll reply to that one realy soon...
> boot/opensbi: Config.in: Cosmetic style fix
> boot/opensbi: Bump to version 1.3
I've applied those two to master too.
> board/sifive: hifive-unleashed: Update rootfs offset
> board/sifive: hifive-unleashed: Include QEMU instructions in
> readme.txt
I'll handle those two very soon.
Thanks!
Regards,
Yann E. MORIN.
>
> arch/Config.in.riscv | 1 -
> .../sifive/hifive-unleashed/genimage_sdcard.cfg | 1 +
> board/sifive/hifive-unleashed/readme.txt | 17 +++++++++++++++++
> boot/opensbi/Config.in | 6 +++---
> boot/opensbi/opensbi.hash | 2 +-
> configs/beaglev_defconfig | 1 +
> configs/hifive_unleashed_defconfig | 10 +++++-----
> configs/nezha_defconfig | 2 --
> configs/qemu_riscv32_virt_defconfig | 2 --
> configs/qemu_riscv64_virt_defconfig | 2 --
> configs/sipeed_lichee_rv_defconfig | 2 --
> configs/sipeed_lichee_rv_dock_defconfig | 2 --
> configs/spike_riscv64_defconfig | 2 --
> 13 files changed, 28 insertions(+), 22 deletions(-)
>
> --
> 2.34.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 21+ messages in thread