* [Buildroot] [PATCH 1/1] libgcrypt: disable assembly for i386
@ 2023-07-02 14:48 Bernd Kuhls
2023-07-03 20:03 ` Yann E. MORIN
0 siblings, 1 reply; 4+ messages in thread
From: Bernd Kuhls @ 2023-07-02 14:48 UTC (permalink / raw)
To: buildroot
Fixes:
http://autobuild.buildroot.net/results/3df/3df96fe36802d8c6ac5487bf3d7d7b6c97591d5e/
Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
---
package/libgcrypt/libgcrypt.mk | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/package/libgcrypt/libgcrypt.mk b/package/libgcrypt/libgcrypt.mk
index 4fffe5360e..bd7b1aa091 100644
--- a/package/libgcrypt/libgcrypt.mk
+++ b/package/libgcrypt/libgcrypt.mk
@@ -21,8 +21,8 @@ LIBGCRYPT_CONF_OPTS = \
$(if $(BR2_OPTIMIZE_0),--disable-ppc-crypto-support,) \
--with-gpg-error-prefix=$(STAGING_DIR)/usr
-# Libgcrypt doesn't support assembly for coldfire
-ifeq ($(BR2_m68k_cf),y)
+# Libgcrypt doesn't support assembly for coldfire & i386
+ifeq ($(BR2_i386)$(BR2_m68k_cf),y)
LIBGCRYPT_CONF_OPTS += --disable-asm
endif
--
2.39.2
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH 1/1] libgcrypt: disable assembly for i386
2023-07-02 14:48 [Buildroot] [PATCH 1/1] libgcrypt: disable assembly for i386 Bernd Kuhls
@ 2023-07-03 20:03 ` Yann E. MORIN
2023-07-03 20:06 ` Yann E. MORIN
0 siblings, 1 reply; 4+ messages in thread
From: Yann E. MORIN @ 2023-07-03 20:03 UTC (permalink / raw)
To: Bernd Kuhls; +Cc: buildroot
Bernd, All,
On 2023-07-02 16:48 +0200, Bernd Kuhls spake thusly:
> Fixes:
> http://autobuild.buildroot.net/results/3df/3df96fe36802d8c6ac5487bf3d7d7b6c97591d5e/
>
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
> ---
> package/libgcrypt/libgcrypt.mk | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/package/libgcrypt/libgcrypt.mk b/package/libgcrypt/libgcrypt.mk
> index 4fffe5360e..bd7b1aa091 100644
> --- a/package/libgcrypt/libgcrypt.mk
> +++ b/package/libgcrypt/libgcrypt.mk
> @@ -21,8 +21,8 @@ LIBGCRYPT_CONF_OPTS = \
> $(if $(BR2_OPTIMIZE_0),--disable-ppc-crypto-support,) \
> --with-gpg-error-prefix=$(STAGING_DIR)/usr
>
> -# Libgcrypt doesn't support assembly for coldfire
> -ifeq ($(BR2_m68k_cf),y)
> +# Libgcrypt doesn't support assembly for coldfire & i386
This is relatively weird, especially, since they do have upstream commit
that try to make it work on "old CPUs":
a5d126c61cc0 configure: fix avx512 check for i386
f01d4b7a601f mpi/longlong.h: i386: use tzcnt instruction for trailing zeros
So maybe this is a bug that should be reported and fixed upstream?
Regards,
Yann E. MORIN.
> +ifeq ($(BR2_i386)$(BR2_m68k_cf),y)
> LIBGCRYPT_CONF_OPTS += --disable-asm
> endif
>
> --
> 2.39.2
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Buildroot] [PATCH 1/1] libgcrypt: disable assembly for i386
2023-07-03 20:03 ` Yann E. MORIN
@ 2023-07-03 20:06 ` Yann E. MORIN
2023-07-17 11:50 ` Peter Korsgaard
0 siblings, 1 reply; 4+ messages in thread
From: Yann E. MORIN @ 2023-07-03 20:06 UTC (permalink / raw)
To: Bernd Kuhls; +Cc: buildroot
Bernd, All,
On 2023-07-03 22:03 +0200, Yann E. MORIN spake thusly:
> On 2023-07-02 16:48 +0200, Bernd Kuhls spake thusly:
> > Fixes:
> > http://autobuild.buildroot.net/results/3df/3df96fe36802d8c6ac5487bf3d7d7b6c97591d5e/
> >
> > Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
> > ---
> > package/libgcrypt/libgcrypt.mk | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/package/libgcrypt/libgcrypt.mk b/package/libgcrypt/libgcrypt.mk
> > index 4fffe5360e..bd7b1aa091 100644
> > --- a/package/libgcrypt/libgcrypt.mk
> > +++ b/package/libgcrypt/libgcrypt.mk
> > @@ -21,8 +21,8 @@ LIBGCRYPT_CONF_OPTS = \
> > $(if $(BR2_OPTIMIZE_0),--disable-ppc-crypto-support,) \
> > --with-gpg-error-prefix=$(STAGING_DIR)/usr
> >
> > -# Libgcrypt doesn't support assembly for coldfire
> > -ifeq ($(BR2_m68k_cf),y)
> > +# Libgcrypt doesn't support assembly for coldfire & i386
>
> This is relatively weird, especially, since they do have upstream commit
> that try to make it work on "old CPUs":
>
> a5d126c61cc0 configure: fix avx512 check for i386
> f01d4b7a601f mpi/longlong.h: i386: use tzcnt instruction for trailing zeros
>
> So maybe this is a bug that should be reported and fixed upstream?
Anyway: applied to master, thanks.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH 1/1] libgcrypt: disable assembly for i386
2023-07-03 20:06 ` Yann E. MORIN
@ 2023-07-17 11:50 ` Peter Korsgaard
0 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2023-07-17 11:50 UTC (permalink / raw)
To: Yann E. MORIN; +Cc: Bernd Kuhls, buildroot
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
> Bernd, All,
> On 2023-07-03 22:03 +0200, Yann E. MORIN spake thusly:
>> On 2023-07-02 16:48 +0200, Bernd Kuhls spake thusly:
>> > Fixes:
>> > http://autobuild.buildroot.net/results/3df/3df96fe36802d8c6ac5487bf3d7d7b6c97591d5e/
>> >
>> > Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
>> > ---
>> > package/libgcrypt/libgcrypt.mk | 4 ++--
>> > 1 file changed, 2 insertions(+), 2 deletions(-)
>> >
>> > diff --git a/package/libgcrypt/libgcrypt.mk b/package/libgcrypt/libgcrypt.mk
>> > index 4fffe5360e..bd7b1aa091 100644
>> > --- a/package/libgcrypt/libgcrypt.mk
>> > +++ b/package/libgcrypt/libgcrypt.mk
>> > @@ -21,8 +21,8 @@ LIBGCRYPT_CONF_OPTS = \
>> > $(if $(BR2_OPTIMIZE_0),--disable-ppc-crypto-support,) \
>> > --with-gpg-error-prefix=$(STAGING_DIR)/usr
>> >
>> > -# Libgcrypt doesn't support assembly for coldfire
>> > -ifeq ($(BR2_m68k_cf),y)
>> > +# Libgcrypt doesn't support assembly for coldfire & i386
>>
>> This is relatively weird, especially, since they do have upstream commit
>> that try to make it work on "old CPUs":
>>
>> a5d126c61cc0 configure: fix avx512 check for i386
>> f01d4b7a601f mpi/longlong.h: i386: use tzcnt instruction for trailing zeros
>>
>> So maybe this is a bug that should be reported and fixed upstream?
> Anyway: applied to master, thanks.
Committed to 2023.02.x and 2023.05.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-07-17 11:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-02 14:48 [Buildroot] [PATCH 1/1] libgcrypt: disable assembly for i386 Bernd Kuhls
2023-07-03 20:03 ` Yann E. MORIN
2023-07-03 20:06 ` Yann E. MORIN
2023-07-17 11:50 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox