[Buildroot] [PATCH 1/7] package/libde265: new package

[Buildroot] [PATCH 1/7] package/libde265: new package

[Bernd Kuhls]

Optional dependency of the upcoming libheif package.

Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
---
 DEVELOPERS                     |  1 +
 package/Config.in              |  1 +
 package/libde265/Config.in     | 12 ++++++++++++
 package/libde265/libde265.hash |  3 +++
 package/libde265/libde265.mk   | 13 +++++++++++++
 5 files changed, 30 insertions(+)
 create mode 100644 package/libde265/Config.in
 create mode 100644 package/libde265/libde265.hash
 create mode 100644 package/libde265/libde265.mk

diff --git a/DEVELOPERS b/DEVELOPERS
index 188c579010..53a58923e3 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -366,6 +366,7 @@ F:	package/libcdio/
 F:	package/libcec/
 F:	package/libcodec2/
 F:	package/libcrossguid/
+F:	package/libde265/
 F:	package/libdeflate/
 F:	package/libdrm/
 F:	package/libdvbcsa/
diff --git a/package/Config.in b/package/Config.in
index 3abbce72a1..58d02a5918 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1831,6 +1831,7 @@ menu "Multimedia"
 	source "package/libbluray/Config.in"
 	source "package/libcamera/Config.in"
 	source "package/libcamera-apps/Config.in"
+	source "package/libde265/Config.in"
 	source "package/libdvbcsa/Config.in"
 	source "package/libdvbpsi/Config.in"
 	source "package/libdvbsi/Config.in"
diff --git a/package/libde265/Config.in b/package/libde265/Config.in
new file mode 100644
index 0000000000..2436beff41
--- /dev/null
+++ b/package/libde265/Config.in
@@ -0,0 +1,12 @@
+config BR2_PACKAGE_LIBDE265
+	bool "libde265"
+	depends on BR2_INSTALL_LIBSTDCPP
+	depends on BR2_TOOLCHAIN_HAS_THREADS
+	help
+	  libde265 is an open source implementation of the h.265 video
+	  codec.
+
+	  https://github.com/strukturag/libde265
+
+comment "libde265 needs a toolchain w/ threads, C++"
+	depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_INSTALL_LIBSTDCPP
diff --git a/package/libde265/libde265.hash b/package/libde265/libde265.hash
new file mode 100644
index 0000000000..168b5db395
--- /dev/null
+++ b/package/libde265/libde265.hash
@@ -0,0 +1,3 @@
+# Locally computed
+sha256  62185ea2182e68cf68bba20cc6eb4c287407b509cf0a827d7ddb75614db77b5c  libde265-1.0.12.tar.gz
+sha256  02cc1585a20677992e0ba578fa692635dc193735f2691dc81de924b51c4e8020  COPYING
diff --git a/package/libde265/libde265.mk b/package/libde265/libde265.mk
new file mode 100644
index 0000000000..60424c0de6
--- /dev/null
+++ b/package/libde265/libde265.mk
@@ -0,0 +1,13 @@
+################################################################################
+#
+# libde265
+#
+################################################################################
+
+LIBDE265_VERSION = 1.0.12
+LIBDE265_SITE = https://github.com/strukturag/libde265/releases/download/v$(LIBDE265_VERSION)
+LIBDE265_LICENSE = LGPL-3.0+
+LIBDE265_LICENSE_FILES = COPYING
+LIBDE265_INSTALL_STAGING = YES
+
+$(eval $(cmake-package))
-- 
2.39.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 2/7] package/libheif: new package

[Bernd Kuhls]

Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
---
 DEVELOPERS                   |  1 +
 package/Config.in            |  1 +
 package/libheif/Config.in    | 14 +++++++++
 package/libheif/libheif.hash |  3 ++
 package/libheif/libheif.mk   | 59 ++++++++++++++++++++++++++++++++++++
 5 files changed, 78 insertions(+)
 create mode 100644 package/libheif/Config.in
 create mode 100644 package/libheif/libheif.hash
 create mode 100644 package/libheif/libheif.mk

diff --git a/DEVELOPERS b/DEVELOPERS
index 53a58923e3..f4a8011223 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -380,6 +380,7 @@ F:	package/libglew/
 F:	package/libglfw/
 F:	package/libglu/
 F:	package/libhdhomerun/
+F:	package/libheif/
 F:	package/libilbc/
 F:	package/libks/
 F:	package/libldns/
diff --git a/package/Config.in b/package/Config.in
index 58d02a5918..2b9ae471ea 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1840,6 +1840,7 @@ menu "Multimedia"
 	source "package/libdvdread/Config.in"
 	source "package/libebml/Config.in"
 	source "package/libhdhomerun/Config.in"
+	source "package/libheif/Config.in"
 	source "package/libimxvpuapi/Config.in"
 	source "package/libmatroska/Config.in"
 	source "package/libmms/Config.in"
diff --git a/package/libheif/Config.in b/package/libheif/Config.in
new file mode 100644
index 0000000000..9ce507fd24
--- /dev/null
+++ b/package/libheif/Config.in
@@ -0,0 +1,14 @@
+config BR2_PACKAGE_LIBHEIF
+	bool "libheif"
+	# avoid build error
+	# Internal error in emit_expr_encoded at dw2gencfi.c:215
+	depends on !BR2_m68k_cf
+	depends on BR2_INSTALL_LIBSTDCPP
+	help
+	  libheif is an HEIF and AVIF file format decoder and encoder.
+
+	  https://github.com/strukturag/libheif
+
+comment "libheif needs a toolchain w/ C++"
+	depends on !BR2_m68k_cf
+	depends on !BR2_INSTALL_LIBSTDCPP
diff --git a/package/libheif/libheif.hash b/package/libheif/libheif.hash
new file mode 100644
index 0000000000..50152abde5
--- /dev/null
+++ b/package/libheif/libheif.hash
@@ -0,0 +1,3 @@
+# Locally computed:
+sha256  7f97e4205c0bd9f9b8560536c8bd2e841d1c9a6d610401eb3eb87ed9cdfe78ea  libheif-1.16.2.tar.gz
+sha256  b2eb4f6588b005bebac44cfb2dfd23f6a16c5ca9b8a619a315158b0215a917a3  COPYING
diff --git a/package/libheif/libheif.mk b/package/libheif/libheif.mk
new file mode 100644
index 0000000000..9c6c2829cf
--- /dev/null
+++ b/package/libheif/libheif.mk
@@ -0,0 +1,59 @@
+################################################################################
+#
+# libheif
+#
+################################################################################
+
+LIBHEIF_VERSION = 1.16.2
+LIBHEIF_SITE = https://github.com/strukturag/libheif/releases/download/v$(LIBHEIF_VERSION)
+LIBHEIF_LICENSE = LGPL-3.0+
+LIBHEIF_LICENSE_FILES = COPYING
+LIBHEIF_INSTALL_STAGING = YES
+LIBHEIF_CONF_OPTS = \
+	-DCMAKE_CXX_FLAGS="-std=c++11" \
+	-DENABLE_PLUGIN_LOADING=OFF \
+	-DWITH_AOM_DECODER=OFF \
+	-DWITH_AOM_ENCODER=OFF \
+	-DWITH_DEFLATE_HEADER_COMPRESSION=OFF \
+	-DWITH_EXAMPLES=OFF \
+	-DWITH_GDK_PIXBUF=OFF \
+	-DWITH_LIBSHARPYUV=OFF \
+	-DWITH_RAV1E=OFF \
+	-DWITH_REDUCED_VISIBILITY=ON \
+	-DWITH_SvtEnc=OFF
+
+ifeq ($(BR2_PACKAGE_DAV1D),y)
+LIBHEIF_CONF_OPTS += -DWITH_DAV1D=ON
+LIBHEIF_DEPENDENCIES += dav1d
+else
+LIBHEIF_CONF_OPTS += -DWITH_DAV1D=OFF
+endif
+
+ifeq ($(BR2_PACKAGE_LIBDE265),y)
+LIBHEIF_CONF_OPTS += -DWITH_LIBDE265=ON
+LIBHEIF_DEPENDENCIES += libde265
+else
+LIBHEIF_CONF_OPTS += -DWITH_LIBDE265=OFF
+endif
+
+ifeq ($(BR2_PACKAGE_X265),y)
+LIBHEIF_CONF_OPTS += -DWITH_X265=ON
+LIBHEIF_DEPENDENCIES += x265
+else
+LIBHEIF_CONF_OPTS += -DWITH_X265=OFF
+endif
+
+ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),y)
+LIBHEIF_CONF_OPTS += -DENABLE_MULTITHREADING_SUPPORT=ON
+ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_64735),y)
+LIBHEIF_CONF_OPTS += -DENABLE_PARALLEL_TILE_DECODING=OFF
+else
+LIBHEIF_CONF_OPTS += -DENABLE_PARALLEL_TILE_DECODING=ON
+endif
+else
+LIBHEIF_CONF_OPTS += \
+	-DENABLE_MULTITHREADING_SUPPORT=OFF \
+	-DENABLE_PARALLEL_TILE_DECODING=OFF
+endif
+
+$(eval $(cmake-package))
-- 
2.39.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 3/7] package/gd: add optional support for libheif

[Bernd Kuhls]

Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
---
 package/gd/gd.mk | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/package/gd/gd.mk b/package/gd/gd.mk
index 55c12e6968..969c02aade 100644
--- a/package/gd/gd.mk
+++ b/package/gd/gd.mk
@@ -44,6 +44,13 @@ GD_DEPENDENCIES += jpeg
 GD_CONF_OPTS += --with-jpeg
 endif
 
+ifeq ($(BR2_PACKAGE_LIBHEIF),y)
+GD_DEPENDENCIES += libheif
+GD_CONF_OPTS += --with-heif
+else
+GD_CONF_OPTS += --without-heif
+endif
+
 ifeq ($(BR2_PACKAGE_LIBPNG),y)
 GD_DEPENDENCIES += libpng
 GD_CONF_OPTS += --with-png
-- 
2.39.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 4/7] package/imagemagick: add optional support for libheif

[Bernd Kuhls]

Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
---
 package/imagemagick/imagemagick.mk | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/package/imagemagick/imagemagick.mk b/package/imagemagick/imagemagick.mk
index 8a2ec460d5..91dd208b0d 100644
--- a/package/imagemagick/imagemagick.mk
+++ b/package/imagemagick/imagemagick.mk
@@ -32,7 +32,6 @@ IMAGEMAGICK_CONF_OPTS = \
 	--without-fpx \
 	--without-gslib \
 	--without-gvc \
-	--without-heic \
 	--without-jbig \
 	--without-jxl \
 	--without-lqr \
@@ -84,6 +83,13 @@ else
 IMAGEMAGICK_CONF_OPTS += --without-lcms
 endif
 
+ifeq ($(BR2_PACKAGE_LIBHEIF),y)
+IMAGEMAGICK_CONF_OPTS += --with-heic
+IMAGEMAGICK_DEPENDENCIES += libheif
+else
+IMAGEMAGICK_CONF_OPTS += --without-heic
+endif
+
 ifeq ($(BR2_PACKAGE_LIBPNG),y)
 IMAGEMAGICK_CONF_OPTS += --with-png
 IMAGEMAGICK_DEPENDENCIES += libpng
-- 
2.39.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 5/7] package/libvips: add optional support for libheif

[Bernd Kuhls]

Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
---
 package/libvips/libvips.mk | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/package/libvips/libvips.mk b/package/libvips/libvips.mk
index f7b15e8e06..1a0f9d5ead 100644
--- a/package/libvips/libvips.mk
+++ b/package/libvips/libvips.mk
@@ -132,6 +132,13 @@ else
 LIBVIPS_CONF_OPTS += --without-libexif
 endif
 
+ifeq ($(BR2_PACKAGE_LIBHEIF),y)
+LIBVIPS_CONF_OPTS += --with-heif
+LIBVIPS_DEPENDENCIES += libheif
+else
+LIBVIPS_CONF_OPTS += --without-heif
+endif
+
 ifeq ($(BR2_PACKAGE_WEBP_DEMUX)$(BR2_PACKAGE_WEBP_MUX),yy)
 LIBVIPS_CONF_OPTS += --with-libwebp
 LIBVIPS_DEPENDENCIES += webp
-- 
2.39.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 6/7] package/kodi-imagedecoder-heif: new package

[Bernd Kuhls]

Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
---
 package/kodi-imagedecoder-heif/Config.in            |  9 +++++++++
 .../kodi-imagedecoder-heif.hash                     |  3 +++
 .../kodi-imagedecoder-heif.mk                       | 13 +++++++++++++
 package/kodi/Config.in                              |  4 ++++
 4 files changed, 29 insertions(+)
 create mode 100644 package/kodi-imagedecoder-heif/Config.in
 create mode 100644 package/kodi-imagedecoder-heif/kodi-imagedecoder-heif.hash
 create mode 100644 package/kodi-imagedecoder-heif/kodi-imagedecoder-heif.mk

diff --git a/package/kodi-imagedecoder-heif/Config.in b/package/kodi-imagedecoder-heif/Config.in
new file mode 100644
index 0000000000..56ba282351
--- /dev/null
+++ b/package/kodi-imagedecoder-heif/Config.in
@@ -0,0 +1,9 @@
+config BR2_PACKAGE_KODI_IMAGEDECODER_HEIF
+	bool "kodi-imagedecoder-heif"
+	select BR2_PACKAGE_LIBDE265
+	select BR2_PACKAGE_LIBHEIF
+	select BR2_PACKAGE_TINYXML2
+	help
+	  HEIF image decoder add-on for Kodi
+
+	  https://github.com/xbmc/imagedecoder.heif
diff --git a/package/kodi-imagedecoder-heif/kodi-imagedecoder-heif.hash b/package/kodi-imagedecoder-heif/kodi-imagedecoder-heif.hash
new file mode 100644
index 0000000000..4c7dec7df1
--- /dev/null
+++ b/package/kodi-imagedecoder-heif/kodi-imagedecoder-heif.hash
@@ -0,0 +1,3 @@
+# Locally computed
+sha256  17f50aada11528c02db2ff3871a355c89709ab7e2a5e6b5e33957b790cf207ff  kodi-imagedecoder-heif-20.1.0-Nexus.tar.gz
+sha256  310782e1abd43c4de6217c513e328bddf999d39302d67c6e05b10a59959827af  LICENSE.md
diff --git a/package/kodi-imagedecoder-heif/kodi-imagedecoder-heif.mk b/package/kodi-imagedecoder-heif/kodi-imagedecoder-heif.mk
new file mode 100644
index 0000000000..40b091d8b4
--- /dev/null
+++ b/package/kodi-imagedecoder-heif/kodi-imagedecoder-heif.mk
@@ -0,0 +1,13 @@
+################################################################################
+#
+# kodi-imagedecoder-heif
+#
+################################################################################
+
+KODI_IMAGEDECODER_HEIF_VERSION = 20.1.0-Nexus
+KODI_IMAGEDECODER_HEIF_SITE = $(call github,xbmc,imagedecoder.heif,$(KODI_IMAGEDECODER_HEIF_VERSION))
+KODI_IMAGEDECODER_HEIF_LICENSE = GPL-2.0+
+KODI_IMAGEDECODER_HEIF_LICENSE_FILES = LICENSE.md
+KODI_IMAGEDECODER_HEIF_DEPENDENCIES = kodi libde265 libheif tinyxml2
+
+$(eval $(cmake-package))
diff --git a/package/kodi/Config.in b/package/kodi/Config.in
index a21733ea78..30f04f0552 100644
--- a/package/kodi/Config.in
+++ b/package/kodi/Config.in
@@ -290,6 +290,10 @@ menu "Audio encoder addons"
 	source "package/kodi-audioencoder-wav/Config.in"
 endmenu
 
+menu "Image decoder addons"
+	source "package/kodi-imagedecoder-heif/Config.in"
+endmenu
+
 menu "Peripheral addons"
 	source "package/kodi-peripheral-joystick/Config.in"
 	source "package/kodi-peripheral-xarcade/Config.in"
-- 
2.39.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 7/7] package/kodi-imagedecoder-raw: new package

[Bernd Kuhls]

Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
---
 package/kodi-imagedecoder-raw/Config.in             |  9 +++++++++
 .../kodi-imagedecoder-raw.hash                      |  3 +++
 .../kodi-imagedecoder-raw/kodi-imagedecoder-raw.mk  | 13 +++++++++++++
 package/kodi/Config.in                              |  1 +
 4 files changed, 26 insertions(+)
 create mode 100644 package/kodi-imagedecoder-raw/Config.in
 create mode 100644 package/kodi-imagedecoder-raw/kodi-imagedecoder-raw.hash
 create mode 100644 package/kodi-imagedecoder-raw/kodi-imagedecoder-raw.mk

diff --git a/package/kodi-imagedecoder-raw/Config.in b/package/kodi-imagedecoder-raw/Config.in
new file mode 100644
index 0000000000..b71e8d019e
--- /dev/null
+++ b/package/kodi-imagedecoder-raw/Config.in
@@ -0,0 +1,9 @@
+config BR2_PACKAGE_KODI_IMAGEDECODER_RAW
+	bool "kodi-imagedecoder-raw"
+	select BR2_PACKAGE_JPEG
+	select BR2_PACKAGE_LCMS2
+	select BR2_PACKAGE_LIBRAW
+	help
+	  RAW image decoder add-on for Kodi
+
+	  https://github.com/xbmc/imagedecoder.raw
diff --git a/package/kodi-imagedecoder-raw/kodi-imagedecoder-raw.hash b/package/kodi-imagedecoder-raw/kodi-imagedecoder-raw.hash
new file mode 100644
index 0000000000..8be6ed98da
--- /dev/null
+++ b/package/kodi-imagedecoder-raw/kodi-imagedecoder-raw.hash
@@ -0,0 +1,3 @@
+# Locally computed
+sha256  6235c0be431bbb814b3e464753af9ad17febf6001f77cbf030e6c6e1cdc41a04  kodi-imagedecoder-raw-20.1.0-Nexus.tar.gz
+sha256  310782e1abd43c4de6217c513e328bddf999d39302d67c6e05b10a59959827af  LICENSE.md
diff --git a/package/kodi-imagedecoder-raw/kodi-imagedecoder-raw.mk b/package/kodi-imagedecoder-raw/kodi-imagedecoder-raw.mk
new file mode 100644
index 0000000000..171956df41
--- /dev/null
+++ b/package/kodi-imagedecoder-raw/kodi-imagedecoder-raw.mk
@@ -0,0 +1,13 @@
+################################################################################
+#
+# kodi-imagedecoder-raw
+#
+################################################################################
+
+KODI_IMAGEDECODER_RAW_VERSION = 20.1.0-Nexus
+KODI_IMAGEDECODER_RAW_SITE = $(call github,xbmc,imagedecoder.raw,$(KODI_IMAGEDECODER_RAW_VERSION))
+KODI_IMAGEDECODER_RAW_LICENSE = GPL-2.0+
+KODI_IMAGEDECODER_RAW_LICENSE_FILES = LICENSE.md
+KODI_IMAGEDECODER_RAW_DEPENDENCIES = kodi jpeg lcms2 libraw
+
+$(eval $(cmake-package))
diff --git a/package/kodi/Config.in b/package/kodi/Config.in
index 30f04f0552..710add0568 100644
--- a/package/kodi/Config.in
+++ b/package/kodi/Config.in
@@ -292,6 +292,7 @@ endmenu
 
 menu "Image decoder addons"
 	source "package/kodi-imagedecoder-heif/Config.in"
+	source "package/kodi-imagedecoder-raw/Config.in"
 endmenu
 
 menu "Peripheral addons"
-- 
2.39.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/7] package/libde265: new package

[Thomas Petazzoni via buildroot]

On Sat,  8 Jul 2023 22:04:41 +0200
Bernd Kuhls <bernd@kuhls.net> wrote:

> Optional dependency of the upcoming libheif package.
> 
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
> ---
>  DEVELOPERS                     |  1 +
>  package/Config.in              |  1 +
>  package/libde265/Config.in     | 12 ++++++++++++
>  package/libde265/libde265.hash |  3 +++
>  package/libde265/libde265.mk   | 13 +++++++++++++
>  5 files changed, 30 insertions(+)
>  create mode 100644 package/libde265/Config.in
>  create mode 100644 package/libde265/libde265.hash
>  create mode 100644 package/libde265/libde265.mk

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 2/7] package/libheif: new package

[Thomas Petazzoni via buildroot]

Hello Bernd,

I've applied, but I have some comments below. Giuliu, there is also a
question for you.

On Sat,  8 Jul 2023 22:04:42 +0200
Bernd Kuhls <bernd@kuhls.net> wrote:

> diff --git a/package/libheif/Config.in b/package/libheif/Config.in
> new file mode 100644
> index 0000000000..9ce507fd24
> --- /dev/null
> +++ b/package/libheif/Config.in
> @@ -0,0 +1,14 @@
> +config BR2_PACKAGE_LIBHEIF
> +	bool "libheif"
> +	# avoid build error
> +	# Internal error in emit_expr_encoded at dw2gencfi.c:215
> +	depends on !BR2_m68k_cf

Giulio, do we have a BR2_TOOLCHAIN_HAS_..._BUG for this? Are other
packages affected by this? I see quite a few BR2_m68k_cf conditionals
sprinkled all over the places in Buildroot.

> +	depends on BR2_INSTALL_LIBSTDCPP

I've added a dependency on gcc >= 4.8, because this package uses C++11.
I have verified it builds fine with GCC 4.8.

Applied with this tweak.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 3/7] package/gd: add optional support for libheif

[Thomas Petazzoni via buildroot]

On Sat,  8 Jul 2023 22:04:43 +0200
Bernd Kuhls <bernd@kuhls.net> wrote:

> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
> ---
>  package/gd/gd.mk | 7 +++++++
>  1 file changed, 7 insertions(+)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 4/7] package/imagemagick: add optional support for libheif

[Thomas Petazzoni via buildroot]

On Sat,  8 Jul 2023 22:04:44 +0200
Bernd Kuhls <bernd@kuhls.net> wrote:

> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
> ---
>  package/imagemagick/imagemagick.mk | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 5/7] package/libvips: add optional support for libheif

[Thomas Petazzoni via buildroot]

On Sat,  8 Jul 2023 22:04:45 +0200
Bernd Kuhls <bernd@kuhls.net> wrote:

> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
> ---
>  package/libvips/libvips.mk | 7 +++++++
>  1 file changed, 7 insertions(+)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 6/7] package/kodi-imagedecoder-heif: new package

[Thomas Petazzoni via buildroot]

On Sat,  8 Jul 2023 22:04:46 +0200
Bernd Kuhls <bernd@kuhls.net> wrote:

> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
> ---
>  package/kodi-imagedecoder-heif/Config.in            |  9 +++++++++
>  .../kodi-imagedecoder-heif.hash                     |  3 +++
>  .../kodi-imagedecoder-heif.mk                       | 13 +++++++++++++
>  package/kodi/Config.in                              |  4 ++++
>  4 files changed, 29 insertions(+)
>  create mode 100644 package/kodi-imagedecoder-heif/Config.in
>  create mode 100644 package/kodi-imagedecoder-heif/kodi-imagedecoder-heif.hash
>  create mode 100644 package/kodi-imagedecoder-heif/kodi-imagedecoder-heif.mk

Applied to master, after adding the missing "depends on" in the
Config.in file as well as the Config.in comment.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 7/7] package/kodi-imagedecoder-raw: new package

[Thomas Petazzoni via buildroot]

On Sat,  8 Jul 2023 22:04:47 +0200
Bernd Kuhls <bernd@kuhls.net> wrote:

> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
> ---
>  package/kodi-imagedecoder-raw/Config.in             |  9 +++++++++
>  .../kodi-imagedecoder-raw.hash                      |  3 +++
>  .../kodi-imagedecoder-raw/kodi-imagedecoder-raw.mk  | 13 +++++++++++++
>  package/kodi/Config.in                              |  1 +
>  4 files changed, 26 insertions(+)
>  create mode 100644 package/kodi-imagedecoder-raw/Config.in
>  create mode 100644 package/kodi-imagedecoder-raw/kodi-imagedecoder-raw.hash
>  create mode 100644 package/kodi-imagedecoder-raw/kodi-imagedecoder-raw.mk

Applied to master after adding "depends on" + Config.in comment. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 2/7] package/libheif: new package

[Giulio Benetti]

Hi Thomas, All,

On 30/07/23 12:26, Thomas Petazzoni via buildroot wrote:
> Hello Bernd,
> 
> I've applied, but I have some comments below. Giuliu, there is also a
> question for you.
> 
> On Sat,  8 Jul 2023 22:04:42 +0200
> Bernd Kuhls <bernd@kuhls.net> wrote:
> 
>> diff --git a/package/libheif/Config.in b/package/libheif/Config.in
>> new file mode 100644
>> index 0000000000..9ce507fd24
>> --- /dev/null
>> +++ b/package/libheif/Config.in
>> @@ -0,0 +1,14 @@
>> +config BR2_PACKAGE_LIBHEIF
>> +	bool "libheif"
>> +	# avoid build error
>> +	# Internal error in emit_expr_encoded at dw2gencfi.c:215
>> +	depends on !BR2_m68k_cf
> 
> Giulio, do we have a BR2_TOOLCHAIN_HAS_..._BUG for this? Are other
> packages affected by this? I see quite a few BR2_m68k_cf conditionals
> sprinkled all over the places in Buildroot.

there is a possible toolchain gcc bug:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79509

but they point this to be a binutils bug, so I'm going to open a bug
in Sourceware. I can't find it already, so yes, it must be open.
We then need to add a BR2_TOOLCHAIN_HAS_BINUTILS_BUG_ and then I can
check against it with the workaround(-fno-dwarf2-cfi-asm) and see if
someone will fix it in binutils and backport patches.
BUT I see only now that for BR2_m68k_cf C/CXXFLAGS have by default
-fno-dwarf2-cfi-asm enabled and if that doesn't make the trick I need
to find another work-around, or maybe it's completely another bug at
this point. Soon I'll be on holidays and I will have more time so
I will look into it.

Best regards
-- 
Giulio Benetti
CEO&CTO@Benetti Engineering sas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 2/7] package/libheif: new package

[Thomas Petazzoni via buildroot]

On Sun, 30 Jul 2023 12:56:42 +0200
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:

> there is a possible toolchain gcc bug:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79509
> 
> but they point this to be a binutils bug, so I'm going to open a bug
> in Sourceware. I can't find it already, so yes, it must be open.
> We then need to add a BR2_TOOLCHAIN_HAS_BINUTILS_BUG_ and then I can
> check against it with the workaround(-fno-dwarf2-cfi-asm) and see if
> someone will fix it in binutils and backport patches.
> BUT I see only now that for BR2_m68k_cf C/CXXFLAGS have by default
> -fno-dwarf2-cfi-asm enabled and if that doesn't make the trick I need
> to find another work-around, or maybe it's completely another bug at
> this point. Soon I'll be on holidays and I will have more time so
> I will look into it.

Thanks for the feedback. I don't think we really need to find a
workaround, as I don't think we care much about m68k_cf support. It's
just that I prefer to have a clear relationship between an exclusion in
Buildroot (don't build this package) and a gcc or binutils bug, rather
than random architecture exclusions.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot