[Buildroot] [PATCH 1/2] package/fwts: Fix build with BR2_OPTIMIZE_0

[Buildroot] [PATCH 1/2] package/fwts: Fix build with BR2_OPTIMIZE_0

[Bernd Kuhls]

Fixes:
http://autobuild.buildroot.net/results/fab/fabd031d38cb618cdb11b4a86cd853b0da61695b/

Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
---
 package/fwts/fwts.mk | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/fwts/fwts.mk b/package/fwts/fwts.mk
index f04c7a848f..3af54a1afd 100644
--- a/package/fwts/fwts.mk
+++ b/package/fwts/fwts.mk
@@ -15,6 +15,10 @@ FWTS_DEPENDENCIES = host-bison host-flex host-pkgconf libglib2 libbsd \
 	$(if $(BR2_PACKAGE_BASH_COMPLETION),bash-completion) \
 	$(if $(BR2_PACKAGE_DTC),dtc)
 
+ifeq ($(BR2_OPTIMIZE_0),y)
+FWTS_CONF_ENV = CFLAGS="$(TARGET_CFLAGS) -O1"
+endif
+
 ifeq ($(BR2_PACKAGE_FWTS_EFI_RUNTIME_MODULE),y)
 FWTS_MODULE_SUBDIRS = efi_runtime
 $(eval $(kernel-module))
-- 
2.39.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 2/2] package/fwts: bump version to 23.07.00

[Bernd Kuhls]

Release notes:
https://wiki.ubuntu.com/FirmwareTestSuite/ReleaseNotes

Updated license hash due to copyright year bump and formatting changes:
https://git.launchpad.net/fwts/commit/debian/copyright?id=64d2ea181d887d877104cd08defbd3427015070a
https://git.launchpad.net/fwts/commit/debian/copyright?id=88edd4da5885e182a339c57c4d70768f6fab695b

Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
---
 package/fwts/fwts.hash | 4 ++--
 package/fwts/fwts.mk   | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/package/fwts/fwts.hash b/package/fwts/fwts.hash
index 612bc768dd..8525d47ecb 100644
--- a/package/fwts/fwts.hash
+++ b/package/fwts/fwts.hash
@@ -1,5 +1,5 @@
 # Hash from: http://fwts.ubuntu.com/release/SHA256SUMS
-sha256  fee1c323fb9725c2b99c348c434d63196391cad66566d34b42707e55d14d7f25  fwts-V22.09.00.tar.gz
+sha256  a15e11c42856e9dfcf7ac23ed370618d2777eb996dd7843accf12d45b21b551c  fwts-V23.07.00.tar.gz
 
 # Hash for license file
-sha256  fbbea748555635dd8c7e6e2f99cddd778f5ee3f9e3510775183bf9799076e5e5  debian/copyright
+sha256  b9e44b1f9f65178e037a59a31b051b51dbd6a531d27c8775d3438a6ce53fc874  debian/copyright
diff --git a/package/fwts/fwts.mk b/package/fwts/fwts.mk
index 3af54a1afd..f06609777d 100644
--- a/package/fwts/fwts.mk
+++ b/package/fwts/fwts.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-FWTS_VERSION = 22.09.00
+FWTS_VERSION = 23.07.00
 FWTS_SOURCE = fwts-V$(FWTS_VERSION).tar.gz
 FWTS_SITE = http://fwts.ubuntu.com/release
 FWTS_STRIP_COMPONENTS = 0
-- 
2.39.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/2] package/fwts: Fix build with BR2_OPTIMIZE_0

[Thomas Petazzoni via buildroot]

On Sun,  9 Jul 2023 11:50:57 +0200
Bernd Kuhls <bernd@kuhls.net> wrote:

> Fixes:
> http://autobuild.buildroot.net/results/fab/fabd031d38cb618cdb11b4a86cd853b0da61695b/
> 
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
> ---
>  package/fwts/fwts.mk | 4 ++++
>  1 file changed, 4 insertions(+)

I've applied, but of course it isn't really nice. Has this issue been
reported upstream?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 2/2] package/fwts: bump version to 23.07.00

[Thomas Petazzoni via buildroot]

On Sun,  9 Jul 2023 11:50:58 +0200
Bernd Kuhls <bernd@kuhls.net> wrote:

> Release notes:
> https://wiki.ubuntu.com/FirmwareTestSuite/ReleaseNotes
> 
> Updated license hash due to copyright year bump and formatting changes:
> https://git.launchpad.net/fwts/commit/debian/copyright?id=64d2ea181d887d877104cd08defbd3427015070a
> https://git.launchpad.net/fwts/commit/debian/copyright?id=88edd4da5885e182a339c57c4d70768f6fab695b
> 
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
> ---
>  package/fwts/fwts.hash | 4 ++--
>  package/fwts/fwts.mk   | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/2] package/fwts: Fix build with BR2_OPTIMIZE_0

[Bernd Kuhls]

Am Sun, 9 Jul 2023 18:29:38 +0200 schrieb Thomas Petazzoni via buildroot:

> I've applied, but of course it isn't really nice. Has this issue been
> reported upstream?

Hi Thomas,

yes, back in 2017: https://bugs.launchpad.net/fwts/+bug/1687049

That bug report was solved by using -O2.

Investigating further I found https://gcc.gnu.org/bugzilla/show_bug.cgi?
id=102502#c4 which, to the best of my limited C knowledge, indicates that 
some assert code will not work with -O0 by design. At this point I 
stopped my research and disabled -O0 ;)

Regards, Bernd

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/2] package/fwts: Fix build with BR2_OPTIMIZE_0

[Thomas Petazzoni via buildroot]

Hello,

On Sun, 09 Jul 2023 18:42:31 +0200
Bernd Kuhls <bernd@kuhls.net> wrote:

> yes, back in 2017: https://bugs.launchpad.net/fwts/+bug/1687049
> 
> That bug report was solved by using -O2.
> 
> Investigating further I found https://gcc.gnu.org/bugzilla/show_bug.cgi?
> id=102502#c4 which, to the best of my limited C knowledge, indicates that 
> some assert code will not work with -O0 by design. At this point I 
> stopped my research and disabled -O0 ;)

Alright, thanks for the additional details!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/2] package/fwts: Fix build with BR2_OPTIMIZE_0

[Peter Korsgaard]

>>>>> "Bernd" == Bernd Kuhls <bernd@kuhls.net> writes:

 > Fixes:
 > http://autobuild.buildroot.net/results/fab/fabd031d38cb618cdb11b4a86cd853b0da61695b/

 > Signed-off-by: Bernd Kuhls <bernd@kuhls.net>

Committed to 2023.02.x and 2023.05.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot