* Re: [Buildroot] [PATCH v4 00/10] group llvm projects and bump to version 15.0.3
[not found] <20230615134315.494330-1-sebastian.weyer__49449.699586124$1686836642$gmane$org@smile.fr>
@ 2023-07-20 19:00 ` Bernd Kuhls
2023-07-20 21:06 ` Thomas Petazzoni via buildroot
0 siblings, 1 reply; 5+ messages in thread
From: Bernd Kuhls @ 2023-07-20 19:00 UTC (permalink / raw)
To: buildroot
Am Thu, 15 Jun 2023 15:43:04 +0200 schrieb Sebastian Weyer:
> This series attempts two things:
> - Move the different llvm subprojects into one folder
Hi Sebastian,
quoting the user manual:
http://buildroot.uclibc.org/downloads/manual/
manual.html#_package_directory
"New subdirectories are discouraged, however."
Regards, Bernd
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Buildroot] [PATCH v4 00/10] group llvm projects and bump to version 15.0.3
2023-07-20 19:00 ` [Buildroot] [PATCH v4 00/10] group llvm projects and bump to version 15.0.3 Bernd Kuhls
@ 2023-07-20 21:06 ` Thomas Petazzoni via buildroot
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Petazzoni via buildroot @ 2023-07-20 21:06 UTC (permalink / raw)
To: Bernd Kuhls; +Cc: buildroot
Hello Bernd,
On Thu, 20 Jul 2023 21:00:54 +0200
Bernd Kuhls <bernd@kuhls.net> wrote:
> quoting the user manual:
> http://buildroot.uclibc.org/downloads/manual/
> manual.html#_package_directory
>
> "New subdirectories are discouraged, however."
Correct, with one exception: when a reasonable number of packages share
some common variables, especially the version variable. It's the case
for qt5, but it's also the case for those llvm-project packages, in
which case we tend to accept having a subdirectory.
Best regards,
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH v4 00/10] group llvm projects and bump to version 15.0.3
@ 2023-06-15 13:43 Sebastian Weyer
2023-07-18 0:01 ` Adam Duskett
2023-07-20 21:05 ` Thomas Petazzoni via buildroot
0 siblings, 2 replies; 5+ messages in thread
From: Sebastian Weyer @ 2023-06-15 13:43 UTC (permalink / raw)
To: buildroot; +Cc: Sebastian Weyer
This series attempts two things:
- Move the different llvm subprojects into one folder
and share version and site information.
- Bump the version to the latest 15.0.3
Starting with version 12 different subprojects added
dependencies or sources that would be available when
building from the "monorepo". These have been added
as new host packages.
This update is needed in order to be able to use some packages in the
future as for example mesa3d's RustiCL.
v4:
- change some inaccurate commit messages
- bump spirv-llvm-translator version at the same time as other llvm
packages
- remove package/llvm/0002-Add-missing-cstdint-header-to-Signals.h.patch
as it has been integrated in the newer version
v3:
- move libclc before llvm 15.0.3 version bump commit
- force llvm-cmake and llvm-libunwind version to 15.0.3 since
LLVM_PROJECT_VERSION is still at 11.1.0
- Keep cp as install command since there is no CMakefiles.txt
- llvm, clang, lld: keep LLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN since
this option is still used to check C++17 compiler support:
llvm/cmake/modules/CheckCompilerVersion.cmake
Changes v1 -> v2:
- Rebased onto current master
- Bump to 15.0.3 instead of 15.0.1
- llvm: use CMAKE_HOST_C_COMPILER instead of HOSTCC
- libclc: Add missing change to package/Config.in
Lang Daniel (10):
package/llvm-project: new group for llvm packages
package/llvm: move to llvm-project folder
package/lld: move to llvm-project subfolder
package/clang: move to llvm-project subfolder
package/compiler-rt: move to llvm-project subfolder
package/libclc: move to llvm-project subfolder
package/llvm-project/llvm-cmake: new package
package/llvm-project/llvm-libunwind: new package
package/llvm-project: bump to version 15.0.3
DEVELOPERS: add Daniel Lang for llvm-project
DEVELOPERS | 19 ++++++-----
package/Config.in | 8 ++---
package/Config.in.host | 2 +-
...hains-Gnu-Use-GCC_INSTALL_PREFIX-in-.patch | 0
package/{ => llvm-project}/clang/Config.in | 10 +++---
package/{ => llvm-project}/clang/clang.hash | 2 +-
package/{ => llvm-project}/clang/clang.mk | 15 +++-----
.../{ => llvm-project}/compiler-rt/Config.in | 6 ++--
.../compiler-rt/compiler-rt.hash | 2 +-
.../compiler-rt/compiler-rt.mk | 9 +++--
.../0001-support-out-of-tree-build.patch | 0
package/{ => llvm-project}/libclc/Config.in | 6 ++--
package/{ => llvm-project}/libclc/libclc.hash | 2 +-
package/{ => llvm-project}/libclc/libclc.mk | 4 +--
package/{ => llvm-project}/lld/Config.in.host | 6 ++--
package/{ => llvm-project}/lld/lld.hash | 2 +-
package/{ => llvm-project}/lld/lld.mk | 13 ++-----
.../llvm-project/llvm-cmake/llvm-cmake.hash | 2 ++
package/llvm-project/llvm-cmake/llvm-cmake.mk | 17 ++++++++++
.../llvm-libunwind/llvm-libunwind.hash | 3 ++
.../llvm-libunwind/llvm-libunwind.mk | 18 ++++++++++
package/llvm-project/llvm-project.mk | 11 ++++++
package/{ => llvm-project}/llvm/Config.in | 10 +++---
package/{ => llvm-project}/llvm/llvm.hash | 2 +-
package/{ => llvm-project}/llvm/llvm.mk | 27 ++++++++-------
.../llvm/0001-nfc-Fix-missing-include.patch | 24 -------------
...-missing-cstdint-header-to-Signals.h.patch | 34 -------------------
package/mesa3d/Config.in | 10 +++---
.../spirv-llvm-translator.hash | 2 +-
.../spirv-llvm-translator.mk | 4 +--
30 files changed, 126 insertions(+), 144 deletions(-)
rename package/{ => llvm-project}/clang/0001-lib-Driver-ToolChains-Gnu-Use-GCC_INSTALL_PREFIX-in-.patch (100%)
rename package/{ => llvm-project}/clang/Config.in (82%)
rename package/{ => llvm-project}/clang/clang.hash (52%)
rename package/{ => llvm-project}/clang/clang.mk (89%)
rename package/{ => llvm-project}/compiler-rt/Config.in (87%)
rename package/{ => llvm-project}/compiler-rt/compiler-rt.hash (50%)
rename package/{ => llvm-project}/compiler-rt/compiler-rt.mk (82%)
rename package/{ => llvm-project}/libclc/0001-support-out-of-tree-build.patch (100%)
rename package/{ => llvm-project}/libclc/Config.in (73%)
rename package/{ => llvm-project}/libclc/libclc.hash (51%)
rename package/{ => llvm-project}/libclc/libclc.mk (92%)
rename package/{ => llvm-project}/lld/Config.in.host (74%)
rename package/{ => llvm-project}/lld/lld.hash (52%)
rename package/{ => llvm-project}/lld/lld.mk (61%)
create mode 100644 package/llvm-project/llvm-cmake/llvm-cmake.hash
create mode 100644 package/llvm-project/llvm-cmake/llvm-cmake.mk
create mode 100644 package/llvm-project/llvm-libunwind/llvm-libunwind.hash
create mode 100644 package/llvm-project/llvm-libunwind/llvm-libunwind.mk
create mode 100644 package/llvm-project/llvm-project.mk
rename package/{ => llvm-project}/llvm/Config.in (88%)
rename package/{ => llvm-project}/llvm/llvm.hash (52%)
rename package/{ => llvm-project}/llvm/llvm.mk (94%)
delete mode 100644 package/llvm/0001-nfc-Fix-missing-include.patch
delete mode 100644 package/llvm/0002-Add-missing-cstdint-header-to-Signals.h.patch
--
2.34.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Buildroot] [PATCH v4 00/10] group llvm projects and bump to version 15.0.3
2023-06-15 13:43 Sebastian Weyer
@ 2023-07-18 0:01 ` Adam Duskett
2023-07-20 21:05 ` Thomas Petazzoni via buildroot
1 sibling, 0 replies; 5+ messages in thread
From: Adam Duskett @ 2023-07-18 0:01 UTC (permalink / raw)
To: Sebastian Weyer; +Cc: buildroot
[-- Attachment #1.1: Type: text/plain, Size: 5903 bytes --]
Hey Sebastian!
Thanks for the patch series! I can't see anything wrong with it so:
Tested-by: Adam Duskett <aduskett@gmail.com>
On Thu, Jun 15, 2023 at 6:44 AM Sebastian Weyer <sebastian.weyer@smile.fr>
wrote:
> This series attempts two things:
> - Move the different llvm subprojects into one folder
> and share version and site information.
>
> - Bump the version to the latest 15.0.3
>
> Starting with version 12 different subprojects added
> dependencies or sources that would be available when
> building from the "monorepo". These have been added
> as new host packages.
>
> This update is needed in order to be able to use some packages in the
> future as for example mesa3d's RustiCL.
>
> v4:
> - change some inaccurate commit messages
> - bump spirv-llvm-translator version at the same time as other llvm
> packages
> - remove package/llvm/0002-Add-missing-cstdint-header-to-Signals.h.patch
> as it has been integrated in the newer version
>
> v3:
> - move libclc before llvm 15.0.3 version bump commit
> - force llvm-cmake and llvm-libunwind version to 15.0.3 since
> LLVM_PROJECT_VERSION is still at 11.1.0
> - Keep cp as install command since there is no CMakefiles.txt
> - llvm, clang, lld: keep LLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN since
> this option is still used to check C++17 compiler support:
> llvm/cmake/modules/CheckCompilerVersion.cmake
>
>
> Changes v1 -> v2:
> - Rebased onto current master
> - Bump to 15.0.3 instead of 15.0.1
> - llvm: use CMAKE_HOST_C_COMPILER instead of HOSTCC
> - libclc: Add missing change to package/Config.in
>
> Lang Daniel (10):
> package/llvm-project: new group for llvm packages
> package/llvm: move to llvm-project folder
> package/lld: move to llvm-project subfolder
> package/clang: move to llvm-project subfolder
> package/compiler-rt: move to llvm-project subfolder
> package/libclc: move to llvm-project subfolder
> package/llvm-project/llvm-cmake: new package
> package/llvm-project/llvm-libunwind: new package
> package/llvm-project: bump to version 15.0.3
> DEVELOPERS: add Daniel Lang for llvm-project
>
> DEVELOPERS | 19 ++++++-----
> package/Config.in | 8 ++---
> package/Config.in.host | 2 +-
> ...hains-Gnu-Use-GCC_INSTALL_PREFIX-in-.patch | 0
> package/{ => llvm-project}/clang/Config.in | 10 +++---
> package/{ => llvm-project}/clang/clang.hash | 2 +-
> package/{ => llvm-project}/clang/clang.mk | 15 +++-----
> .../{ => llvm-project}/compiler-rt/Config.in | 6 ++--
> .../compiler-rt/compiler-rt.hash | 2 +-
> .../compiler-rt/compiler-rt.mk | 9 +++--
> .../0001-support-out-of-tree-build.patch | 0
> package/{ => llvm-project}/libclc/Config.in | 6 ++--
> package/{ => llvm-project}/libclc/libclc.hash | 2 +-
> package/{ => llvm-project}/libclc/libclc.mk | 4 +--
> package/{ => llvm-project}/lld/Config.in.host | 6 ++--
> package/{ => llvm-project}/lld/lld.hash | 2 +-
> package/{ => llvm-project}/lld/lld.mk | 13 ++-----
> .../llvm-project/llvm-cmake/llvm-cmake.hash | 2 ++
> package/llvm-project/llvm-cmake/llvm-cmake.mk | 17 ++++++++++
> .../llvm-libunwind/llvm-libunwind.hash | 3 ++
> .../llvm-libunwind/llvm-libunwind.mk | 18 ++++++++++
> package/llvm-project/llvm-project.mk | 11 ++++++
> package/{ => llvm-project}/llvm/Config.in | 10 +++---
> package/{ => llvm-project}/llvm/llvm.hash | 2 +-
> package/{ => llvm-project}/llvm/llvm.mk | 27 ++++++++-------
> .../llvm/0001-nfc-Fix-missing-include.patch | 24 -------------
> ...-missing-cstdint-header-to-Signals.h.patch | 34 -------------------
> package/mesa3d/Config.in | 10 +++---
> .../spirv-llvm-translator.hash | 2 +-
> .../spirv-llvm-translator.mk | 4 +--
> 30 files changed, 126 insertions(+), 144 deletions(-)
> rename package/{ =>
> llvm-project}/clang/0001-lib-Driver-ToolChains-Gnu-Use-GCC_INSTALL_PREFIX-in-.patch
> (100%)
> rename package/{ => llvm-project}/clang/Config.in (82%)
> rename package/{ => llvm-project}/clang/clang.hash (52%)
> rename package/{ => llvm-project}/clang/clang.mk (89%)
> rename package/{ => llvm-project}/compiler-rt/Config.in (87%)
> rename package/{ => llvm-project}/compiler-rt/compiler-rt.hash (50%)
> rename package/{ => llvm-project}/compiler-rt/compiler-rt.mk (82%)
> rename package/{ =>
> llvm-project}/libclc/0001-support-out-of-tree-build.patch (100%)
> rename package/{ => llvm-project}/libclc/Config.in (73%)
> rename package/{ => llvm-project}/libclc/libclc.hash (51%)
> rename package/{ => llvm-project}/libclc/libclc.mk (92%)
> rename package/{ => llvm-project}/lld/Config.in.host (74%)
> rename package/{ => llvm-project}/lld/lld.hash (52%)
> rename package/{ => llvm-project}/lld/lld.mk (61%)
> create mode 100644 package/llvm-project/llvm-cmake/llvm-cmake.hash
> create mode 100644 package/llvm-project/llvm-cmake/llvm-cmake.mk
> create mode 100644 package/llvm-project/llvm-libunwind/llvm-libunwind.hash
> create mode 100644 package/llvm-project/llvm-libunwind/llvm-libunwind.mk
> create mode 100644 package/llvm-project/llvm-project.mk
> rename package/{ => llvm-project}/llvm/Config.in (88%)
> rename package/{ => llvm-project}/llvm/llvm.hash (52%)
> rename package/{ => llvm-project}/llvm/llvm.mk (94%)
> delete mode 100644 package/llvm/0001-nfc-Fix-missing-include.patch
> delete mode 100644
> package/llvm/0002-Add-missing-cstdint-header-to-Signals.h.patch
>
> --
> 2.34.1
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
>
[-- Attachment #1.2: Type: text/html, Size: 8492 bytes --]
[-- Attachment #2: Type: text/plain, Size: 150 bytes --]
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Buildroot] [PATCH v4 00/10] group llvm projects and bump to version 15.0.3
2023-06-15 13:43 Sebastian Weyer
2023-07-18 0:01 ` Adam Duskett
@ 2023-07-20 21:05 ` Thomas Petazzoni via buildroot
1 sibling, 0 replies; 5+ messages in thread
From: Thomas Petazzoni via buildroot @ 2023-07-20 21:05 UTC (permalink / raw)
To: Sebastian Weyer; +Cc: Lang Daniel, Romain Naour, Adam Duskett, buildroot
Hello Sebastian,
On Thu, 15 Jun 2023 15:43:04 +0200
Sebastian Weyer <sebastian.weyer@smile.fr> wrote:
> Lang Daniel (10):
> package/llvm-project: new group for llvm packages
> package/llvm: move to llvm-project folder
> package/lld: move to llvm-project subfolder
> package/clang: move to llvm-project subfolder
> package/compiler-rt: move to llvm-project subfolder
> package/libclc: move to llvm-project subfolder
> package/llvm-project/llvm-cmake: new package
> package/llvm-project/llvm-libunwind: new package
> package/llvm-project: bump to version 15.0.3
> DEVELOPERS: add Daniel Lang for llvm-project
Thanks a lot, I have applied the entire patch series, with some fairly
small changes:
- I have squashed the patch touching the DEVELOPERS file into the first
patch adding package/llvm-project in the first place. This ensures
this directory isn't introduced as an "orphan" directory.
- I have taken care of updating the .checkpackageignore file throughout
the patch series, which was not taken into account here.
- The final patch doing the big bump forgot the case of
BR2_PACKAGE_QT5TOOLS_QDOC_TOOL which has a dependency on host-clang
and therefore now depends on host gcc >= 7. And I see I forgot to
also update the dependency on gcc >= 7. I'll fix that up.
In fact, as noted in the definition of this option, there is still
something wrong here: this qt5tools option only needs host-clang, but
for some reason, we can only build host-clang when the target
architecture is supported, which doesn't make much sense. It would be
nice to look into this.
Thanks a lot for your efforts on this, and sorry for the long delay to
review and merge this.
Best regards,
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-07-20 22:07 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20230615134315.494330-1-sebastian.weyer__49449.699586124$1686836642$gmane$org@smile.fr>
2023-07-20 19:00 ` [Buildroot] [PATCH v4 00/10] group llvm projects and bump to version 15.0.3 Bernd Kuhls
2023-07-20 21:06 ` Thomas Petazzoni via buildroot
2023-06-15 13:43 Sebastian Weyer
2023-07-18 0:01 ` Adam Duskett
2023-07-20 21:05 ` Thomas Petazzoni via buildroot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox