Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH v2] package/mhz: add new package
@ 2023-07-31 12:20 Robert Marko
  2023-07-31 12:24 ` Baruch Siach via buildroot
  2023-07-31 12:49 ` Thomas Petazzoni via buildroot
  0 siblings, 2 replies; 4+ messages in thread
From: Robert Marko @ 2023-07-31 12:20 UTC (permalink / raw)
  To: buildroot; +Cc: Robert Marko, Thomas Petazzoni

mhz is a tool to mathematically calculate the real running CPU frequency
and as such has proved as invaluable tool for developing CPUFreq and
similar features in the kernel.

Its source finally got a license recently so it can be packaged.

Signed-off-by: Robert Marko <robimarko@gmail.com>
---
Changes in v2:
* Use the Makefile from source and override CC and CFLAGS
---
 package/Config.in     |  1 +
 package/mhz/Config.in |  6 ++++++
 package/mhz/mhz.hash  |  2 ++
 package/mhz/mhz.mk    | 21 +++++++++++++++++++++
 4 files changed, 30 insertions(+)
 create mode 100644 package/mhz/Config.in
 create mode 100644 package/mhz/mhz.hash
 create mode 100644 package/mhz/mhz.mk

diff --git a/package/Config.in b/package/Config.in
index a60a1a8858..b9b6dd2580 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -549,6 +549,7 @@ endmenu
 	source "package/memtest86/Config.in"
 	source "package/memtester/Config.in"
 	source "package/memtool/Config.in"
+	source "package/mhz/Config.in"
 	source "package/minicom/Config.in"
 	source "package/msr-tools/Config.in"
 	source "package/nanocom/Config.in"
diff --git a/package/mhz/Config.in b/package/mhz/Config.in
new file mode 100644
index 0000000000..2f4af5026e
--- /dev/null
+++ b/package/mhz/Config.in
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_MHZ
+	bool "mhz"
+	help
+	  CPU frequency measurement utility.
+
+	  https://github.com/wtarreau/mhz.git
diff --git a/package/mhz/mhz.hash b/package/mhz/mhz.hash
new file mode 100644
index 0000000000..6b39eb4bb7
--- /dev/null
+++ b/package/mhz/mhz.hash
@@ -0,0 +1,2 @@
+# Locally calculated
+sha256  1e07bb0d455d63fd33fb87a24f65a803c7c2d920fde4e5b5378b8c1b07de3b47  mhz-11aac2399780a1f7ea9f007b14af0464797d5cf1-br1.tar.gz
diff --git a/package/mhz/mhz.mk b/package/mhz/mhz.mk
new file mode 100644
index 0000000000..924bf0793e
--- /dev/null
+++ b/package/mhz/mhz.mk
@@ -0,0 +1,21 @@
+################################################################################
+#
+# mhz
+#
+################################################################################
+
+MHZ_VERSION = 11aac2399780a1f7ea9f007b14af0464797d5cf1
+MHZ_SITE = https://github.com/wtarreau/mhz.git
+MHZ_SITE_METHOD = git
+MHZ_LICENSE = MIT/X11
+MHZ_LICENSE_FILES = LICENSE
+
+define MHZ_BUILD_CMDS
+	$(TARGET_MAKE_ENV) $(MAKE) CC="$(TARGET_CC)" CFLAGS="$(TARGET_CFLAGS) $(TARGET_LDFLAGS)" -C $(@D)
+endef
+
+define MHZ_INSTALL_TARGET_CMDS
+	$(INSTALL) $(@D)/mhz $(TARGET_DIR)/usr/bin/mhz
+endef
+
+$(eval $(generic-package))
-- 
2.41.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH v2] package/mhz: add new package
  2023-07-31 12:20 [Buildroot] [PATCH v2] package/mhz: add new package Robert Marko
@ 2023-07-31 12:24 ` Baruch Siach via buildroot
  2023-07-31 12:51   ` Thomas Petazzoni via buildroot
  2023-07-31 12:49 ` Thomas Petazzoni via buildroot
  1 sibling, 1 reply; 4+ messages in thread
From: Baruch Siach via buildroot @ 2023-07-31 12:24 UTC (permalink / raw)
  To: Robert Marko; +Cc: Thomas Petazzoni, buildroot

Hi Robert,

On Mon, Jul 31 2023, Robert Marko wrote:
> mhz is a tool to mathematically calculate the real running CPU frequency
> and as such has proved as invaluable tool for developing CPUFreq and
> similar features in the kernel.
>
> Its source finally got a license recently so it can be packaged.
>
> Signed-off-by: Robert Marko <robimarko@gmail.com>
> ---
> Changes in v2:
> * Use the Makefile from source and override CC and CFLAGS
> ---
>  package/Config.in     |  1 +
>  package/mhz/Config.in |  6 ++++++
>  package/mhz/mhz.hash  |  2 ++
>  package/mhz/mhz.mk    | 21 +++++++++++++++++++++
>  4 files changed, 30 insertions(+)
>  create mode 100644 package/mhz/Config.in
>  create mode 100644 package/mhz/mhz.hash
>  create mode 100644 package/mhz/mhz.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index a60a1a8858..b9b6dd2580 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -549,6 +549,7 @@ endmenu
>  	source "package/memtest86/Config.in"
>  	source "package/memtester/Config.in"
>  	source "package/memtool/Config.in"
> +	source "package/mhz/Config.in"
>  	source "package/minicom/Config.in"
>  	source "package/msr-tools/Config.in"
>  	source "package/nanocom/Config.in"
> diff --git a/package/mhz/Config.in b/package/mhz/Config.in
> new file mode 100644
> index 0000000000..2f4af5026e
> --- /dev/null
> +++ b/package/mhz/Config.in
> @@ -0,0 +1,6 @@
> +config BR2_PACKAGE_MHZ
> +	bool "mhz"
> +	help
> +	  CPU frequency measurement utility.
> +
> +	  https://github.com/wtarreau/mhz.git
> diff --git a/package/mhz/mhz.hash b/package/mhz/mhz.hash
> new file mode 100644
> index 0000000000..6b39eb4bb7
> --- /dev/null
> +++ b/package/mhz/mhz.hash
> @@ -0,0 +1,2 @@
> +# Locally calculated
> +sha256  1e07bb0d455d63fd33fb87a24f65a803c7c2d920fde4e5b5378b8c1b07de3b47  mhz-11aac2399780a1f7ea9f007b14af0464797d5cf1-br1.tar.gz

License file hash is missing here.

> diff --git a/package/mhz/mhz.mk b/package/mhz/mhz.mk
> new file mode 100644
> index 0000000000..924bf0793e
> --- /dev/null
> +++ b/package/mhz/mhz.mk
> @@ -0,0 +1,21 @@
> +################################################################################
> +#
> +# mhz
> +#
> +################################################################################
> +
> +MHZ_VERSION = 11aac2399780a1f7ea9f007b14af0464797d5cf1
> +MHZ_SITE = https://github.com/wtarreau/mhz.git
> +MHZ_SITE_METHOD = git

You should use the github helper instead. Something like

  MHZ_SITE = $(call github,wtarreau,mhz,$(MHZ_VERSION))

> +MHZ_LICENSE = MIT/X11
> +MHZ_LICENSE_FILES = LICENSE
> +
> +define MHZ_BUILD_CMDS
> +	$(TARGET_MAKE_ENV) $(MAKE) CC="$(TARGET_CC)" CFLAGS="$(TARGET_CFLAGS) $(TARGET_LDFLAGS)" -C $(@D)

Are you sure you need TARGET_LDFLAGS here?

baruch

> +endef
> +
> +define MHZ_INSTALL_TARGET_CMDS
> +	$(INSTALL) $(@D)/mhz $(TARGET_DIR)/usr/bin/mhz
> +endef
> +
> +$(eval $(generic-package))


-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH v2] package/mhz: add new package
  2023-07-31 12:20 [Buildroot] [PATCH v2] package/mhz: add new package Robert Marko
  2023-07-31 12:24 ` Baruch Siach via buildroot
@ 2023-07-31 12:49 ` Thomas Petazzoni via buildroot
  1 sibling, 0 replies; 4+ messages in thread
From: Thomas Petazzoni via buildroot @ 2023-07-31 12:49 UTC (permalink / raw)
  To: Robert Marko; +Cc: buildroot

Hello Robert,

On Mon, 31 Jul 2023 14:20:22 +0200
Robert Marko <robimarko@gmail.com> wrote:

> mhz is a tool to mathematically calculate the real running CPU frequency
> and as such has proved as invaluable tool for developing CPUFreq and
> similar features in the kernel.
> 
> Its source finally got a license recently so it can be packaged.
> 
> Signed-off-by: Robert Marko <robimarko@gmail.com>
> ---
> Changes in v2:
> * Use the Makefile from source and override CC and CFLAGS
> ---
>  package/Config.in     |  1 +
>  package/mhz/Config.in |  6 ++++++
>  package/mhz/mhz.hash  |  2 ++
>  package/mhz/mhz.mk    | 21 +++++++++++++++++++++
>  4 files changed, 30 insertions(+)
>  create mode 100644 package/mhz/Config.in
>  create mode 100644 package/mhz/mhz.hash
>  create mode 100644 package/mhz/mhz.mk

On top of what Baruch said, you also need to add an entry in the
DEVELOPERS file.

> +define MHZ_INSTALL_TARGET_CMDS
> +	$(INSTALL) $(@D)/mhz $(TARGET_DIR)/usr/bin/mhz

	$(INSTALL) -D -m0755 $(@D)/mhz $(TARGET_DIR)/usr/bin/mhz

is preferred here.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH v2] package/mhz: add new package
  2023-07-31 12:24 ` Baruch Siach via buildroot
@ 2023-07-31 12:51   ` Thomas Petazzoni via buildroot
  0 siblings, 0 replies; 4+ messages in thread
From: Thomas Petazzoni via buildroot @ 2023-07-31 12:51 UTC (permalink / raw)
  To: Baruch Siach; +Cc: Robert Marko, buildroot

On Mon, 31 Jul 2023 15:24:14 +0300
Baruch Siach <baruch@tkos.co.il> wrote:

> > +define MHZ_BUILD_CMDS
> > +	$(TARGET_MAKE_ENV) $(MAKE) CC="$(TARGET_CC)" CFLAGS="$(TARGET_CFLAGS) $(TARGET_LDFLAGS)" -C $(@D)  
> 
> Are you sure you need TARGET_LDFLAGS here?

What about:

	$(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D)

This will also pass LDFLAGS, which is used by the upstream Makefile.

Thoams
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-07-31 12:52 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-31 12:20 [Buildroot] [PATCH v2] package/mhz: add new package Robert Marko
2023-07-31 12:24 ` Baruch Siach via buildroot
2023-07-31 12:51   ` Thomas Petazzoni via buildroot
2023-07-31 12:49 ` Thomas Petazzoni via buildroot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox