From: Thomas Devoogdt <thomas@devoogdt.com>
To: buildroot@buildroot.org
Cc: Eric Le Bihan <eric.le.bihan.dev@free.fr>,
Samuel Martin <s.martin49@gmail.com>,
Adrian Perez de Castro <aperez@igalia.com>,
Thomas Devoogdt <thomas.devoogdt@barco.com>
Subject: [Buildroot] [PATCH v6 4/4] pkg-cmake: make ninja the default for all packages
Date: Wed, 2 Aug 2023 13:14:47 +0200 [thread overview]
Message-ID: <20230802111447.41714-4-thomas@devoogdt.com> (raw)
In-Reply-To: <20230802111447.41714-1-thomas@devoogdt.com>
From: Thomas Devoogdt <thomas.devoogdt@barco.com>
Use ninja as the default generator.
A fun fact is that we of course have to disable ninja when building ninja.
Signed-off-by: Thomas Devoogdt <thomas.devoogdt@barco.com>
---
v5: add this optional commit
v6: rebase
---
package/ninja/ninja.mk | 1 +
package/pkg-cmake.mk | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/package/ninja/ninja.mk b/package/ninja/ninja.mk
index b7bc1a4f1c..85dd2e05aa 100644
--- a/package/ninja/ninja.mk
+++ b/package/ninja/ninja.mk
@@ -9,6 +9,7 @@ NINJA_VERSION = $(NINJA_VERSION_MAJOR).g95dee.kitware.jobserver-1
NINJA_SITE = $(call github,Kitware,ninja,v$(NINJA_VERSION))
NINJA_LICENSE = Apache-2.0
NINJA_LICENSE_FILES = COPYING
+NINJA_CMAKE_NINJA = NO
define HOST_NINJA_INSTALL_CMDS
$(INSTALL) -m 0755 -D $(@D)/ninja $(HOST_DIR)/bin/ninja
diff --git a/package/pkg-cmake.mk b/package/pkg-cmake.mk
index 36ab88d3a1..dab87c81f4 100644
--- a/package/pkg-cmake.mk
+++ b/package/pkg-cmake.mk
@@ -52,7 +52,7 @@ endif
define inner-cmake-package
$(3)_SUPPORTS_IN_SOURCE_BUILD ?= YES
-
+$(3)_CMAKE_NINJA ?= YES
ifeq ($$($(3)_SUPPORTS_IN_SOURCE_BUILD),YES)
$(2)_BUILDDIR = $$($(2)_SRCDIR)
--
2.34.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-08-02 11:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-16 8:21 [Buildroot] [PATCH v5 1/4] pkg-cmake: add option to select the Ninja generator Thomas Devoogdt
2023-05-16 8:21 ` [Buildroot] [PATCH v5 2/4] package/webkitgtk: use the CMAKE_NINJA flag Thomas Devoogdt
2023-05-16 8:21 ` [Buildroot] [PATCH v5 3/4] package/wpewebkit: " Thomas Devoogdt
2023-05-16 8:21 ` [Buildroot] [PATCH v5 4/4] [optional patch] pkg-cmake: make ninja the default for all packages Thomas Devoogdt
2023-08-02 11:14 ` [Buildroot] [PATCH v6 1/4] pkg-cmake: add option to select the Ninja generator Thomas Devoogdt
2023-08-02 11:14 ` [Buildroot] [PATCH v6 2/4] package/webkitgtk: use the CMAKE_NINJA flag Thomas Devoogdt
2023-08-06 14:16 ` Yann E. MORIN
2023-08-02 11:14 ` [Buildroot] [PATCH v6 3/4] package/wpewebkit: " Thomas Devoogdt
2023-08-06 14:17 ` Yann E. MORIN
2023-08-02 11:14 ` Thomas Devoogdt [this message]
2023-08-06 14:19 ` [Buildroot] [PATCH v6 4/4] pkg-cmake: make ninja the default for all packages Yann E. MORIN
2023-08-06 20:54 ` Yann E. MORIN
2023-08-06 14:15 ` [Buildroot] [PATCH v6 1/4] pkg-cmake: add option to select the Ninja generator Yann E. MORIN
2023-10-02 17:33 ` Yann E. MORIN
2023-10-02 20:26 ` Thomas Devoogdt
2023-10-02 20:43 ` Yann E. MORIN
2023-10-07 18:10 ` Thomas Devoogdt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230802111447.41714-4-thomas@devoogdt.com \
--to=thomas@devoogdt.com \
--cc=aperez@igalia.com \
--cc=buildroot@buildroot.org \
--cc=eric.le.bihan.dev@free.fr \
--cc=s.martin49@gmail.com \
--cc=thomas.devoogdt@barco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox