From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Thomas Devoogdt <thomas@devoogdt.com>
Cc: Eric Le Bihan <eric.le.bihan.dev@free.fr>,
Samuel Martin <s.martin49@gmail.com>,
John Keeping <john@metanate.com>,
Thomas Devoogdt <thomas.devoogdt@barco.com>,
buildroot@buildroot.org,
Adrian Perez de Castro <aperez@igalia.com>
Subject: Re: [Buildroot] [PATCH v6 1/4] pkg-cmake: add option to select the Ninja generator
Date: Mon, 2 Oct 2023 19:33:10 +0200 [thread overview]
Message-ID: <20231002173310.GA2957@scaer> (raw)
In-Reply-To: <20230806141506.GS421096@scaer>
Thomas, All,
On 2023-08-06 16:15 +0200, Yann E. MORIN spake thusly:
> On 2023-08-02 13:14 +0200, Thomas Devoogdt spake thusly:
> > From: Thomas Devoogdt <thomas.devoogdt@barco.com>
> > Cmake supports multiple generators. Ninja is a small build system with a
> > focus on speed. It is mainly used with the meson build system, but also
> > cmake has very good support for it. This adds optional support for the
> > Ninja build system.
[--SNIP--]
> Please review the new code. If I broke something, please send followup
> fixup patches with appropriate explanations (there's a kind of déjà-vu
> here...)
While reviewing another patch, I now noticed that we did lose something
with the introduction of this ninja backend. that I totally missed when
I applied it.
Indeed, previously, the install step was done with the install/fast
rule:
$(2)_INSTALL_STAGING_OPTS ?= DESTDIR=$$(STAGING_DIR) install/fast
$(2)_INSTALL_TARGET_OPTS ?= DESTDIR=$$(TARGET_DIR) install/fast
But this got removed with your patch, with nothing to replace it.
See commit dfcc18f84b0d (pkg-cmake: Skip compilation in installation
step) for the rationale of using install/fast.
Could you look into restoring this, please?
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-10-02 17:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-16 8:21 [Buildroot] [PATCH v5 1/4] pkg-cmake: add option to select the Ninja generator Thomas Devoogdt
2023-05-16 8:21 ` [Buildroot] [PATCH v5 2/4] package/webkitgtk: use the CMAKE_NINJA flag Thomas Devoogdt
2023-05-16 8:21 ` [Buildroot] [PATCH v5 3/4] package/wpewebkit: " Thomas Devoogdt
2023-05-16 8:21 ` [Buildroot] [PATCH v5 4/4] [optional patch] pkg-cmake: make ninja the default for all packages Thomas Devoogdt
2023-08-02 11:14 ` [Buildroot] [PATCH v6 1/4] pkg-cmake: add option to select the Ninja generator Thomas Devoogdt
2023-08-02 11:14 ` [Buildroot] [PATCH v6 2/4] package/webkitgtk: use the CMAKE_NINJA flag Thomas Devoogdt
2023-08-06 14:16 ` Yann E. MORIN
2023-08-02 11:14 ` [Buildroot] [PATCH v6 3/4] package/wpewebkit: " Thomas Devoogdt
2023-08-06 14:17 ` Yann E. MORIN
2023-08-02 11:14 ` [Buildroot] [PATCH v6 4/4] pkg-cmake: make ninja the default for all packages Thomas Devoogdt
2023-08-06 14:19 ` Yann E. MORIN
2023-08-06 20:54 ` Yann E. MORIN
2023-08-06 14:15 ` [Buildroot] [PATCH v6 1/4] pkg-cmake: add option to select the Ninja generator Yann E. MORIN
2023-10-02 17:33 ` Yann E. MORIN [this message]
2023-10-02 20:26 ` Thomas Devoogdt
2023-10-02 20:43 ` Yann E. MORIN
2023-10-07 18:10 ` Thomas Devoogdt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231002173310.GA2957@scaer \
--to=yann.morin.1998@free.fr \
--cc=aperez@igalia.com \
--cc=buildroot@buildroot.org \
--cc=eric.le.bihan.dev@free.fr \
--cc=john@metanate.com \
--cc=s.martin49@gmail.com \
--cc=thomas.devoogdt@barco.com \
--cc=thomas@devoogdt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox