Re: [Buildroot] [PATCH v6 1/4] pkg-cmake: add option to select the Ninja generator

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Thomas, All,

On 2023-10-02 22:26 +0200, Thomas Devoogdt spake thusly:
> I will check what I can do. A quick search gives me this flag:
> [1]https://cmake.org/cmake/help/latest/variable/CMAKE_SKIP_INSTALL_ALL_DEPENDENCY.html ,
> which is probably what we want. Otherwise I don't see much additional install options.

If I understood it properly, this makes 'install' behave as
'install/fast' by default, so looks like we should indeed be passing
this option instead. If that does not make sense for the ninja case,
then we'd set it only for the makefiles case.

> And calling the make install/fast target
> directly is not very generator generic.

If we reinstate 'install/fast' as it was previously, we'd do that only
for the makefiels case, of course.

Regards,
Yann E. MORIN.

> Kr,
> Thomas 
> Op ma 2 okt. 2023 19:33 schreef Yann E. MORIN < [2]yann.morin.1998@free.fr>:
> 
>   Thomas, All,
> 
>   On 2023-08-06 16:15 +0200, Yann E. MORIN spake thusly:
>   > On 2023-08-02 13:14 +0200, Thomas Devoogdt spake thusly:
>   > > From: Thomas Devoogdt < [3]thomas.devoogdt@barco.com>
>   > > Cmake supports multiple generators. Ninja is a small build system with a
>   > > focus on speed. It is mainly used with the meson build system, but also
>   > > cmake has very good support for it. This adds optional support for the
>   > > Ninja build system.
>   [--SNIP--]
>   > Please review the new code. If I broke something, please send followup
>   > fixup patches with appropriate explanations (there's a kind of déjà-vu
>   > here...)
> 
>   While reviewing another patch, I now noticed that we did lose something
>   with the introduction of this ninja backend. that I totally missed when
>   I applied it.
> 
>   Indeed, previously, the install step was done with the install/fast
>   rule:
> 
>       $(2)_INSTALL_STAGING_OPTS      ?= DESTDIR=$$(STAGING_DIR) install/fast
>       $(2)_INSTALL_TARGET_OPTS       ?= DESTDIR=$$(TARGET_DIR) install/fast
> 
>   But this got removed with your patch, with nothing to replace it.
> 
>   See commit dfcc18f84b0d (pkg-cmake: Skip compilation in installation
>   step) for the rationale of using install/fast.
> 
>   Could you look into restoring this, please?
> 
>   Regards,
>   Yann E. MORIN.
> 
>   --
>   .-----------------.--------------------.------------------.--------------------.
>   |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
>   | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___           
>      |
>   | +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
>   | [4]http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
>   '------------------------------^-------^------------------^--------------------'
> 
> Links:
> 1. https://cmake.org/cmake/help/latest/variable/CMAKE_SKIP_INSTALL_ALL_DEPENDENCY.html
> 2. mailto:yann.morin.1998@free.fr
> 3. mailto:thomas.devoogdt@barco.com
> 4. http://ymorin.is-a-geek.org/

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot