* [Buildroot] [PATCH 1/2] package/netsnmp: add systemd service file
@ 2023-05-01 20:36 David Johnson via buildroot
2023-05-01 20:36 ` [Buildroot] [PATCH 2/2] package/netsnmp: add a snmp user so snmpd doesn't run as root David Johnson via buildroot
2023-08-09 18:47 ` [Buildroot] [PATCH 1/2] package/netsnmp: add systemd service file Thomas Petazzoni via buildroot
0 siblings, 2 replies; 3+ messages in thread
From: David Johnson via buildroot @ 2023-05-01 20:36 UTC (permalink / raw)
To: buildroot; +Cc: David Johnson
Signed-off-by: David Johnson <dave-git@centerclick.org>
---
package/netsnmp/netsnmp.mk | 10 ++++++++++
package/netsnmp/snmpd.service | 15 +++++++++++++++
2 files changed, 25 insertions(+)
create mode 100644 package/netsnmp/snmpd.service
diff --git a/package/netsnmp/netsnmp.mk b/package/netsnmp/netsnmp.mk
index 15bc318e36..0218e65b91 100644
--- a/package/netsnmp/netsnmp.mk
+++ b/package/netsnmp/netsnmp.mk
@@ -41,6 +41,12 @@ NETSNMP_INSTALL_TARGET_OPTS = DESTDIR=$(TARGET_DIR) LIB_LDCONFIG_CMD=true instal
NETSNMP_MAKE = $(MAKE1)
NETSNMP_CONFIG_SCRIPTS = net-snmp-config
+ifeq ($(BR2_INIT_SYSTEMD),y)
+NETSNMP_CONF_OPTS += --with-systemd
+else
+NETSNMP_CONF_OPTS += --without-systemd
+endif
+
ifeq ($(BR2_ENDIAN),"BIG")
NETSNMP_CONF_OPTS += --with-endianness=big
else
@@ -104,6 +110,10 @@ define NETSNMP_INSTALL_INIT_SYSV
$(INSTALL) -D -m 0755 package/netsnmp/S59snmpd \
$(TARGET_DIR)/etc/init.d/S59snmpd
endef
+define NETSNMP_INSTALL_INIT_SYSTEMD
+ $(INSTALL) -D -m 0644 package/netsnmp/snmpd.service \
+ $(TARGET_DIR)/usr/lib/systemd/system/snmpd.service
+endef
endif
$(eval $(autotools-package))
diff --git a/package/netsnmp/snmpd.service b/package/netsnmp/snmpd.service
new file mode 100644
index 0000000000..2a1e6e9715
--- /dev/null
+++ b/package/netsnmp/snmpd.service
@@ -0,0 +1,15 @@
+[Unit]
+Description=SNMP Daemon
+After=network.target
+ConditionPathExists=/etc/snmp/snmpd.conf
+
+[Service]
+Type=simple
+Environment=MIBDIRS=/usr/share/snmp/mibs
+Environment=SNMPDOPTS='-Lsd -Lf /dev/null -p /var/run/snmpd.pid 127.0.0.1'
+EnvironmentFile=-/etc/default/snmpd
+PassEnvironment=MIBDIRS
+ExecStart=/usr/sbin/snmpd -f $SNMPDOPTS
+
+[Install]
+WantedBy=multi-user.target
--
2.30.2
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 2/2] package/netsnmp: add a snmp user so snmpd doesn't run as root
2023-05-01 20:36 [Buildroot] [PATCH 1/2] package/netsnmp: add systemd service file David Johnson via buildroot
@ 2023-05-01 20:36 ` David Johnson via buildroot
2023-08-09 18:47 ` [Buildroot] [PATCH 1/2] package/netsnmp: add systemd service file Thomas Petazzoni via buildroot
1 sibling, 0 replies; 3+ messages in thread
From: David Johnson via buildroot @ 2023-05-01 20:36 UTC (permalink / raw)
To: buildroot; +Cc: David Johnson
Signed-off-by: David Johnson <dave-git@centerclick.org>
---
package/netsnmp/S59snmpd | 2 +-
package/netsnmp/netsnmp.mk | 4 ++++
package/netsnmp/snmpd.service | 2 +-
3 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/package/netsnmp/S59snmpd b/package/netsnmp/S59snmpd
index 96ed8237ac..aece896670 100644
--- a/package/netsnmp/S59snmpd
+++ b/package/netsnmp/S59snmpd
@@ -17,7 +17,7 @@ export PATH=/sbin:/usr/sbin:/bin:/usr/bin
# Defaults
export MIBDIRS=/usr/share/snmp/mibs
SNMPDRUN=yes
-SNMPDOPTS='-Lsd -Lf /dev/null -p /var/run/snmpd.pid 127.0.0.1'
+SNMPDOPTS='-Lsd -Lf /dev/null -p /var/run/snmpd.pid -u snmp -g snmp 127.0.0.1'
TRAPDRUN=no
TRAPDOPTS='-Lsd -p /var/run/snmptrapd.pid'
diff --git a/package/netsnmp/netsnmp.mk b/package/netsnmp/netsnmp.mk
index 0218e65b91..c7df49f947 100644
--- a/package/netsnmp/netsnmp.mk
+++ b/package/netsnmp/netsnmp.mk
@@ -41,6 +41,10 @@ NETSNMP_INSTALL_TARGET_OPTS = DESTDIR=$(TARGET_DIR) LIB_LDCONFIG_CMD=true instal
NETSNMP_MAKE = $(MAKE1)
NETSNMP_CONFIG_SCRIPTS = net-snmp-config
+define NETSNMP_USERS
+ snmp -1 snmp -1 * - - - snmpd user
+endef
+
ifeq ($(BR2_INIT_SYSTEMD),y)
NETSNMP_CONF_OPTS += --with-systemd
else
diff --git a/package/netsnmp/snmpd.service b/package/netsnmp/snmpd.service
index 2a1e6e9715..6647b10c32 100644
--- a/package/netsnmp/snmpd.service
+++ b/package/netsnmp/snmpd.service
@@ -6,7 +6,7 @@ ConditionPathExists=/etc/snmp/snmpd.conf
[Service]
Type=simple
Environment=MIBDIRS=/usr/share/snmp/mibs
-Environment=SNMPDOPTS='-Lsd -Lf /dev/null -p /var/run/snmpd.pid 127.0.0.1'
+Environment=SNMPDOPTS='-Lsd -Lf /dev/null -p /var/run/snmpd.pid -u snmp -g snmp 127.0.0.1'
EnvironmentFile=-/etc/default/snmpd
PassEnvironment=MIBDIRS
ExecStart=/usr/sbin/snmpd -f $SNMPDOPTS
--
2.30.2
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH 1/2] package/netsnmp: add systemd service file
2023-05-01 20:36 [Buildroot] [PATCH 1/2] package/netsnmp: add systemd service file David Johnson via buildroot
2023-05-01 20:36 ` [Buildroot] [PATCH 2/2] package/netsnmp: add a snmp user so snmpd doesn't run as root David Johnson via buildroot
@ 2023-08-09 18:47 ` Thomas Petazzoni via buildroot
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni via buildroot @ 2023-08-09 18:47 UTC (permalink / raw)
To: David Johnson via buildroot; +Cc: David Johnson
On Mon, 1 May 2023 16:36:46 -0400
David Johnson via buildroot <buildroot@buildroot.org> wrote:
> Signed-off-by: David Johnson <dave-git@centerclick.org>
> ---
> package/netsnmp/netsnmp.mk | 10 ++++++++++
> package/netsnmp/snmpd.service | 15 +++++++++++++++
> 2 files changed, 25 insertions(+)
> create mode 100644 package/netsnmp/snmpd.service
Sorry for the super long delay, but I've now applied both of your
patches to our next branch. Thanks for this contribution!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-08-09 18:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-01 20:36 [Buildroot] [PATCH 1/2] package/netsnmp: add systemd service file David Johnson via buildroot
2023-05-01 20:36 ` [Buildroot] [PATCH 2/2] package/netsnmp: add a snmp user so snmpd doesn't run as root David Johnson via buildroot
2023-08-09 18:47 ` [Buildroot] [PATCH 1/2] package/netsnmp: add systemd service file Thomas Petazzoni via buildroot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox