[Buildroot] [PATCH v2 0/1] Fix Rock 5B build, broken by gcc 12 warnings

[Buildroot] [PATCH v2 0/1] Fix Rock 5B build, broken by gcc 12 warnings

[Kilian Zinnecker via buildroot]

Building the image for the Radxa Rock 5B currently breaks: The gcc
version was recently changed to version 12 and gcc 12 seems to stop
compiling, if certain warnings occur. See the broken build here:

https://gitlab.com/buildroot.org/buildroot/-/jobs/4795673759

This patch series adds two patches from the mainline Linux kernel,
which fix two of the warnings. However, also custom code parts of the
used custom kernel break due to warnings from gcc 12. The best
solution would be that the vendor fixes those issues. However, until
the vendor provides fixes (if ever), the affected code parts (i.e.,
custom board support for WiFi) are disabled.

Kilian Zinnecker (1):
  configs/rock5b: Add patches to fix gcc12 warnings

 board/radxa/rock5b/linux.fragment             |  1 +
 ...st-ether_addr-prototypes-to-silence-.patch | 62 +++++++++++++++++++
 ...x-building-error-on-Werror-array-com.patch | 45 ++++++++++++++
 configs/rock5b_defconfig                      |  1 +
 4 files changed, 109 insertions(+)
 create mode 100644 board/radxa/rock5b/patches/linux/0001-etherdevice-Adjust-ether_addr-prototypes-to-silence-.patch
 create mode 100644 board/radxa/rock5b/patches/linux/0002-mm-page_alloc-fix-building-error-on-Werror-array-com.patch

-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v2 1/1] configs/rock5b: Add patches to fix gcc12 warnings

[Kilian Zinnecker via buildroot]

This patch introduces patches for the custom kernel, as it is
currently used for the Radxa Rock 5B. The patches fix two gcc
compiler warnings, which result in a build error, if the kernel
is used with gcc version 12.
Since also the code of custom board drivers for WiFi support is
affected, and no fixes are provided by the vendor, the custom WiFi
support is disabled.

Signed-off-by: Kilian Zinnecker <kilian.zinnecker@mail.de>
---
 board/radxa/rock5b/linux.fragment             |  1 +
 ...st-ether_addr-prototypes-to-silence-.patch | 62 +++++++++++++++++++
 ...x-building-error-on-Werror-array-com.patch | 45 ++++++++++++++
 configs/rock5b_defconfig                      |  1 +
 4 files changed, 109 insertions(+)
 create mode 100644 board/radxa/rock5b/patches/linux/0001-etherdevice-Adjust-ether_addr-prototypes-to-silence-.patch
 create mode 100644 board/radxa/rock5b/patches/linux/0002-mm-page_alloc-fix-building-error-on-Werror-array-com.patch

diff --git a/board/radxa/rock5b/linux.fragment b/board/radxa/rock5b/linux.fragment
index 811d42a79b..d455b492b9 100644
--- a/board/radxa/rock5b/linux.fragment
+++ b/board/radxa/rock5b/linux.fragment
@@ -1 +1,2 @@
 CONFIG_R8169=y
+CONFIG_WL_ROCKCHIP=n
diff --git a/board/radxa/rock5b/patches/linux/0001-etherdevice-Adjust-ether_addr-prototypes-to-silence-.patch b/board/radxa/rock5b/patches/linux/0001-etherdevice-Adjust-ether_addr-prototypes-to-silence-.patch
new file mode 100644
index 0000000000..8c1cec2f47
--- /dev/null
+++ b/board/radxa/rock5b/patches/linux/0001-etherdevice-Adjust-ether_addr-prototypes-to-silence-.patch
@@ -0,0 +1,62 @@
+From 2618a0dae09ef37728dab89ff60418cbe25ae6bd Mon Sep 17 00:00:00 2001
+From: Kees Cook <keescook@chromium.org>
+Date: Sat, 12 Feb 2022 09:14:49 -0800
+Subject: [PATCH] etherdevice: Adjust ether_addr* prototypes to silence
+ -Wstringop-overead
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+With GCC 12, -Wstringop-overread was warning about an implicit cast from
+char[6] to char[8]. However, the extra 2 bytes are always thrown away,
+alignment doesn't matter, and the risk of hitting the edge of unallocated
+memory has been accepted, so this prototype can just be converted to a
+regular char *. Silences:
+
+net/core/dev.c: In function ‘bpf_prog_run_generic_xdp’: net/core/dev.c:4618:21: warning: ‘ether_addr_equal_64bits’ reading 8 bytes from a region of size 6 [-Wstringop-overread]
+ 4618 |         orig_host = ether_addr_equal_64bits(eth->h_dest, > skb->dev->dev_addr);
+      |                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+net/core/dev.c:4618:21: note: referencing argument 1 of type ‘const u8[8]’ {aka ‘const unsigned char[8]’}
+net/core/dev.c:4618:21: note: referencing argument 2 of type ‘const u8[8]’ {aka ‘const unsigned char[8]’}
+In file included from net/core/dev.c:91: include/linux/etherdevice.h:375:20: note: in a call to function ‘ether_addr_equal_64bits’
+  375 | static inline bool ether_addr_equal_64bits(const u8 addr1[6+2],
+      |                    ^~~~~~~~~~~~~~~~~~~~~~~
+
+Reported-by: Marc Kleine-Budde <mkl@pengutronix.de>
+Tested-by: Marc Kleine-Budde <mkl@pengutronix.de>
+Link: https://lore.kernel.org/netdev/20220212090811.uuzk6d76agw2vv73@pengutronix.de
+Cc: Jakub Kicinski <kuba@kernel.org>
+Cc: "David S. Miller" <davem@davemloft.net>
+Cc: netdev@vger.kernel.org
+Signed-off-by: Kees Cook <keescook@chromium.org>
+Signed-off-by: David S. Miller <davem@davemloft.net>
+---
+ include/linux/etherdevice.h | 5 ++---
+ 1 file changed, 2 insertions(+), 3 deletions(-)
+
+diff --git a/include/linux/etherdevice.h b/include/linux/etherdevice.h
+index 2ad71cc90b37..92b10e67d5f8 100644
+--- a/include/linux/etherdevice.h
++++ b/include/linux/etherdevice.h
+@@ -134,7 +134,7 @@ static inline bool is_multicast_ether_addr(const u8 *addr)
+ #endif
+ }
+ 
+-static inline bool is_multicast_ether_addr_64bits(const u8 addr[6+2])
++static inline bool is_multicast_ether_addr_64bits(const u8 *addr)
+ {
+ #if defined(CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS) && BITS_PER_LONG == 64
+ #ifdef __BIG_ENDIAN
+@@ -372,8 +372,7 @@ static inline bool ether_addr_equal(const u8 *addr1, const u8 *addr2)
+  * Please note that alignment of addr1 & addr2 are only guaranteed to be 16 bits.
+  */
+ 
+-static inline bool ether_addr_equal_64bits(const u8 addr1[6+2],
+-					   const u8 addr2[6+2])
++static inline bool ether_addr_equal_64bits(const u8 *addr1, const u8 *addr2)
+ {
+ #if defined(CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS) && BITS_PER_LONG == 64
+ 	u64 fold = (*(const u64 *)addr1) ^ (*(const u64 *)addr2);
+-- 
+2.34.1
+
diff --git a/board/radxa/rock5b/patches/linux/0002-mm-page_alloc-fix-building-error-on-Werror-array-com.patch b/board/radxa/rock5b/patches/linux/0002-mm-page_alloc-fix-building-error-on-Werror-array-com.patch
new file mode 100644
index 0000000000..34eae9c158
--- /dev/null
+++ b/board/radxa/rock5b/patches/linux/0002-mm-page_alloc-fix-building-error-on-Werror-array-com.patch
@@ -0,0 +1,45 @@
+From 69848f9488bc1088bcd9a73987dff8d2cb47a060 Mon Sep 17 00:00:00 2001
+From: Xiongwei Song <sxwjean@gmail.com>
+Date: Fri, 14 Jan 2022 14:07:24 -0800
+Subject: [PATCH] mm: page_alloc: fix building error on -Werror=array-compare
+
+commit ca831f29f8f25c97182e726429b38c0802200c8f upstream.
+
+Arthur Marsh reported we would hit the error below when building kernel
+with gcc-12:
+
+  CC      mm/page_alloc.o
+  mm/page_alloc.c: In function `mem_init_print_info':
+  mm/page_alloc.c:8173:27: error: comparison between two arrays [-Werror=array-compare]
+   8173 |                 if (start <= pos && pos < end && size > adj) \
+        |
+
+In C++20, the comparision between arrays should be warned.
+
+Link: https://lkml.kernel.org/r/20211125130928.32465-1-sxwjean@me.com
+Signed-off-by: Xiongwei Song <sxwjean@gmail.com>
+Reported-by: Arthur Marsh <arthur.marsh@internode.on.net>
+Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
+Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
+Cc: Khem Raj <raj.khem@gmail.com>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ mm/page_alloc.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/mm/page_alloc.c b/mm/page_alloc.c
+index f022e0024e8d..f3418edb136b 100644
+--- a/mm/page_alloc.c
++++ b/mm/page_alloc.c
+@@ -7678,7 +7678,7 @@ void __init mem_init_print_info(const char *str)
+ 	 */
+ #define adj_init_size(start, end, size, pos, adj) \
+ 	do { \
+-		if (start <= pos && pos < end && size > adj) \
++		if (&start[0] <= &pos[0] && &pos[0] < &end[0] && size > adj) \
+ 			size -= adj; \
+ 	} while (0)
+ 
+-- 
+2.34.1
+
diff --git a/configs/rock5b_defconfig b/configs/rock5b_defconfig
index 6e525d9676..eed656ef5f 100644
--- a/configs/rock5b_defconfig
+++ b/configs/rock5b_defconfig
@@ -5,6 +5,7 @@ BR2_ROOTFS_POST_IMAGE_SCRIPT="board/radxa/rock5b/post-image.sh"
 BR2_ROOTFS_POST_SCRIPT_ARGS=""
 BR2_TARGET_GENERIC_HOSTNAME="rock5b"
 BR2_TARGET_GENERIC_ISSUE="Welcome to the rock5b board"
+BR2_GLOBAL_PATCH_DIR="board/radxa/rock5b/patches"
 BR2_SYSTEM_DHCP="eth0"
 BR2_LINUX_KERNEL=y
 BR2_LINUX_KERNEL_CUSTOM_GIT=y
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 1/1] configs/rock5b: Add patches to fix gcc12 warnings

[Yann E. MORIN]

Kilian, All,

On 2023-08-20 17:20 +0200, Kilian Zinnecker via buildroot spake thusly:
> This patch introduces patches for the custom kernel, as it is
> currently used for the Radxa Rock 5B. The patches fix two gcc
> compiler warnings, which result in a build error, if the kernel
> is used with gcc version 12.
> Since also the code of custom board drivers for WiFi support is
> affected, and no fixes are provided by the vendor, the custom WiFi
> support is disabled.
> 
> Signed-off-by: Kilian Zinnecker <kilian.zinnecker@mail.de>
> ---
>  board/radxa/rock5b/linux.fragment             |  1 +
>  ...st-ether_addr-prototypes-to-silence-.patch | 62 +++++++++++++++++++
>  ...x-building-error-on-Werror-array-com.patch | 45 ++++++++++++++
>  configs/rock5b_defconfig                      |  1 +
>  4 files changed, 109 insertions(+)
>  create mode 100644 board/radxa/rock5b/patches/linux/0001-etherdevice-Adjust-ether_addr-prototypes-to-silence-.patch
>  create mode 100644 board/radxa/rock5b/patches/linux/0002-mm-page_alloc-fix-building-error-on-Werror-array-com.patch
> 
> diff --git a/board/radxa/rock5b/linux.fragment b/board/radxa/rock5b/linux.fragment
> index 811d42a79b..d455b492b9 100644
> --- a/board/radxa/rock5b/linux.fragment
> +++ b/board/radxa/rock5b/linux.fragment
> @@ -1 +1,2 @@
>  CONFIG_R8169=y
> +CONFIG_WL_ROCKCHIP=n

=n is not valid in kconfig to disable a symbol; instead, they must be
unset:

    # CONFIG_WL_ROCKCHIP=n

See for example:

    board/olimex/a20_olinuxino/linux-disable-lima.fragment
    board/solidrun/macchiatobin/uboot-fragment.config
    board/stmicroelectronics/stm32f769-disco/linux-sd.fragment
    board/solidrun/clearfog_gt_8k/uboot-fragment.config

> diff --git a/board/radxa/rock5b/patches/linux/0001-etherdevice-Adjust-ether_addr-prototypes-to-silence-.patch b/board/radxa/rock5b/patches/linux/0001-etherdevice-Adjust-ether_addr-prototypes-to-silence-.patch
> new file mode 100644
> index 0000000000..8c1cec2f47
> --- /dev/null
> +++ b/board/radxa/rock5b/patches/linux/0001-etherdevice-Adjust-ether_addr-prototypes-to-silence-.patch
> @@ -0,0 +1,62 @@
> +From 2618a0dae09ef37728dab89ff60418cbe25ae6bd Mon Sep 17 00:00:00 2001
> +From: Kees Cook <keescook@chromium.org>
> +Date: Sat, 12 Feb 2022 09:14:49 -0800
> +Subject: [PATCH] etherdevice: Adjust ether_addr* prototypes to silence
> + -Wstringop-overead
> +MIME-Version: 1.0
> +Content-Type: text/plain; charset=UTF-8
> +Content-Transfer-Encoding: 8bit
> +
> +With GCC 12, -Wstringop-overread was warning about an implicit cast from
> +char[6] to char[8]. However, the extra 2 bytes are always thrown away,
> +alignment doesn't matter, and the risk of hitting the edge of unallocated
> +memory has been accepted, so this prototype can just be converted to a
> +regular char *. Silences:
> +
> +net/core/dev.c: In function ‘bpf_prog_run_generic_xdp’: net/core/dev.c:4618:21: warning: ‘ether_addr_equal_64bits’ reading 8 bytes from a region of size 6 [-Wstringop-overread]
> + 4618 |         orig_host = ether_addr_equal_64bits(eth->h_dest, > skb->dev->dev_addr);
> +      |                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> +net/core/dev.c:4618:21: note: referencing argument 1 of type ‘const u8[8]’ {aka ‘const unsigned char[8]’}
> +net/core/dev.c:4618:21: note: referencing argument 2 of type ‘const u8[8]’ {aka ‘const unsigned char[8]’}
> +In file included from net/core/dev.c:91: include/linux/etherdevice.h:375:20: note: in a call to function ‘ether_addr_equal_64bits’
> +  375 | static inline bool ether_addr_equal_64bits(const u8 addr1[6+2],
> +      |                    ^~~~~~~~~~~~~~~~~~~~~~~
> +
> +Reported-by: Marc Kleine-Budde <mkl@pengutronix.de>
> +Tested-by: Marc Kleine-Budde <mkl@pengutronix.de>
> +Link: https://lore.kernel.org/netdev/20220212090811.uuzk6d76agw2vv73@pengutronix.de
> +Cc: Jakub Kicinski <kuba@kernel.org>
> +Cc: "David S. Miller" <davem@davemloft.net>
> +Cc: netdev@vger.kernel.org
> +Signed-off-by: Kees Cook <keescook@chromium.org>
> +Signed-off-by: David S. Miller <davem@davemloft.net>

    $ ./utils/docker-run make check-package
    board/radxa/rock5b/patches/linux/0001-etherdevice-Adjust-ether_addr-prototypes-to-silence-.patch:0: missing Upstream in the header (http://nightly.buildroot.org/#_additional_patch_documentation)
    board/radxa/rock5b/patches/linux/0002-mm-page_alloc-fix-building-error-on-Werror-array-com.patch:0: missing Upstream in the header (http://nightly.buildroot.org/#_additional_patch_documentation)

Also, it misses your own Sign-off line:

    Upstream: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=2618a0dae09ef37728dab89ff60418cbe25ae6bd
    Signed-off-by: Kilian Zinnecker <kilian.zinnecker@mail.de>

Regards,
Yann E. MORIN.

> +---
> + include/linux/etherdevice.h | 5 ++---
> + 1 file changed, 2 insertions(+), 3 deletions(-)
> +
> +diff --git a/include/linux/etherdevice.h b/include/linux/etherdevice.h
> +index 2ad71cc90b37..92b10e67d5f8 100644
> +--- a/include/linux/etherdevice.h
> ++++ b/include/linux/etherdevice.h
> +@@ -134,7 +134,7 @@ static inline bool is_multicast_ether_addr(const u8 *addr)
> + #endif
> + }
> + 
> +-static inline bool is_multicast_ether_addr_64bits(const u8 addr[6+2])
> ++static inline bool is_multicast_ether_addr_64bits(const u8 *addr)
> + {
> + #if defined(CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS) && BITS_PER_LONG == 64
> + #ifdef __BIG_ENDIAN
> +@@ -372,8 +372,7 @@ static inline bool ether_addr_equal(const u8 *addr1, const u8 *addr2)
> +  * Please note that alignment of addr1 & addr2 are only guaranteed to be 16 bits.
> +  */
> + 
> +-static inline bool ether_addr_equal_64bits(const u8 addr1[6+2],
> +-					   const u8 addr2[6+2])
> ++static inline bool ether_addr_equal_64bits(const u8 *addr1, const u8 *addr2)
> + {
> + #if defined(CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS) && BITS_PER_LONG == 64
> + 	u64 fold = (*(const u64 *)addr1) ^ (*(const u64 *)addr2);
> +-- 
> +2.34.1
> +
> diff --git a/board/radxa/rock5b/patches/linux/0002-mm-page_alloc-fix-building-error-on-Werror-array-com.patch b/board/radxa/rock5b/patches/linux/0002-mm-page_alloc-fix-building-error-on-Werror-array-com.patch
> new file mode 100644
> index 0000000000..34eae9c158
> --- /dev/null
> +++ b/board/radxa/rock5b/patches/linux/0002-mm-page_alloc-fix-building-error-on-Werror-array-com.patch
> @@ -0,0 +1,45 @@
> +From 69848f9488bc1088bcd9a73987dff8d2cb47a060 Mon Sep 17 00:00:00 2001
> +From: Xiongwei Song <sxwjean@gmail.com>
> +Date: Fri, 14 Jan 2022 14:07:24 -0800
> +Subject: [PATCH] mm: page_alloc: fix building error on -Werror=array-compare
> +
> +commit ca831f29f8f25c97182e726429b38c0802200c8f upstream.
> +
> +Arthur Marsh reported we would hit the error below when building kernel
> +with gcc-12:
> +
> +  CC      mm/page_alloc.o
> +  mm/page_alloc.c: In function `mem_init_print_info':
> +  mm/page_alloc.c:8173:27: error: comparison between two arrays [-Werror=array-compare]
> +   8173 |                 if (start <= pos && pos < end && size > adj) \
> +        |
> +
> +In C++20, the comparision between arrays should be warned.
> +
> +Link: https://lkml.kernel.org/r/20211125130928.32465-1-sxwjean@me.com
> +Signed-off-by: Xiongwei Song <sxwjean@gmail.com>
> +Reported-by: Arthur Marsh <arthur.marsh@internode.on.net>
> +Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> +Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
> +Cc: Khem Raj <raj.khem@gmail.com>
> +Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> +---
> + mm/page_alloc.c | 2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> +index f022e0024e8d..f3418edb136b 100644
> +--- a/mm/page_alloc.c
> ++++ b/mm/page_alloc.c
> +@@ -7678,7 +7678,7 @@ void __init mem_init_print_info(const char *str)
> + 	 */
> + #define adj_init_size(start, end, size, pos, adj) \
> + 	do { \
> +-		if (start <= pos && pos < end && size > adj) \
> ++		if (&start[0] <= &pos[0] && &pos[0] < &end[0] && size > adj) \
> + 			size -= adj; \
> + 	} while (0)
> + 
> +-- 
> +2.34.1
> +
> diff --git a/configs/rock5b_defconfig b/configs/rock5b_defconfig
> index 6e525d9676..eed656ef5f 100644
> --- a/configs/rock5b_defconfig
> +++ b/configs/rock5b_defconfig
> @@ -5,6 +5,7 @@ BR2_ROOTFS_POST_IMAGE_SCRIPT="board/radxa/rock5b/post-image.sh"
>  BR2_ROOTFS_POST_SCRIPT_ARGS=""
>  BR2_TARGET_GENERIC_HOSTNAME="rock5b"
>  BR2_TARGET_GENERIC_ISSUE="Welcome to the rock5b board"
> +BR2_GLOBAL_PATCH_DIR="board/radxa/rock5b/patches"
>  BR2_SYSTEM_DHCP="eth0"
>  BR2_LINUX_KERNEL=y
>  BR2_LINUX_KERNEL_CUSTOM_GIT=y
> -- 
> 2.34.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 1/1] configs/rock5b: Add patches to fix gcc12 warnings

[Kilian Zinnecker via buildroot]

Hello Yann,

[--SNIP--]

> > +CONFIG_WL_ROCKCHIP=n
> 
> =n is not valid in kconfig to disable a symbol; instead, they must be
> unset:
> 
>     # CONFIG_WL_ROCKCHIP=n
> 
> See for example:
> 
>     board/olimex/a20_olinuxino/linux-disable-lima.fragment
>     board/solidrun/macchiatobin/uboot-fragment.config
>     board/stmicroelectronics/stm32f769-disco/linux-sd.fragment
>     board/solidrun/clearfog_gt_8k/uboot-fragment.config

Thanks. I changed it accordingly.

[--SNIP--]

> > +Reported-by: Marc Kleine-Budde <mkl@pengutronix.de>
> > +Tested-by: Marc Kleine-Budde <mkl@pengutronix.de>
> > +Link:
> > https://lore.kernel.org/netdev/20220212090811.uuzk6d76agw2vv73@pengutroni
> > x.de +Cc: Jakub Kicinski <kuba@kernel.org>
> > +Cc: "David S. Miller" <davem@davemloft.net>
> > +Cc: netdev@vger.kernel.org
> > +Signed-off-by: Kees Cook <keescook@chromium.org>
> > +Signed-off-by: David S. Miller <davem@davemloft.net>
> 
>     $ ./utils/docker-run make check-package
>    
> board/radxa/rock5b/patches/linux/0001-etherdevice-Adjust-ether_addr-prototy
> pes-to-silence-.patch:0: missing Upstream in the header
> (http://nightly.buildroot.org/#_additional_patch_documentation)
> board/radxa/rock5b/patches/linux/0002-mm-page_alloc-fix-building-error-on-W
> error-array-com.patch:0: missing Upstream in the header
> (http://nightly.buildroot.org/#_additional_patch_documentation)
> 
> Also, it misses your own Sign-off line:
> 
>     Upstream:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?
> id=2618a0dae09ef37728dab89ff60418cbe25ae6bd Signed-off-by: Kilian Zinnecker
> <kilian.zinnecker@mail.de>

Thanks, I was absolutely unaware, that adding a signed-of-by in case one 
commits other's patches as patch files was necessary and also that an upstream 
link must be provided. I tried again - hopefully I did it right.

I send a v3 of the patch.

Thanks and best regards,
Kilian


_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 1/1] configs/rock5b: Add patches to fix gcc12 warnings

[Yann E. MORIN]

Kilian, All,

On 2023-08-20 21:09 +0200, Kilian Zinnecker spake thusly:
> > Also, it misses your own Sign-off line:
> Thanks, I was absolutely unaware, that adding a signed-of-by in case one 
> commits other's patches as patch files was necessary

Yes, the SoB line shows who handled the patch along the way it took to
us; you are part of the chain. In the DCO, that's be clause (b):

    https://developercertificate.org/

    By making a contribution to this project, I certify that:

    (b) The contribution is based upon previous work that, to the best
        of my knowledge, is covered under an appropriate open source
        license and I have the right under that license to submit that
        work with modifications, whether created in whole or in part
        by me, under the same open source license (unless I am
        permitted to submit under a different license), as indicated
        in the file; or

> and also that an upstream 
> link must be provided.

Having an upstream tag helps track whether a specific patch is still
needed when the versions of components are updated.

This upstream tag is a relatively recent addition, so people are getting
hit by it, no worries (I caught it as I have a git hook that runs a
bunch of checks on each patch I apply or commit I make).

Regards,
Yann E. MORIN.

> I tried again - hopefully I did it right.
> 
> I send a v3 of the patch.
> 
> Thanks and best regards,
> Kilian
> 
> 

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot