* [Buildroot] [PATCH] package/libnvme: needs host-swig
@ 2023-10-26 15:57 Giulio Benetti
2023-10-29 11:33 ` Yann E. MORIN
0 siblings, 1 reply; 3+ messages in thread
From: Giulio Benetti @ 2023-10-26 15:57 UTC (permalink / raw)
To: buildroot; +Cc: Giulio Benetti
Fixes:
http://autobuild.buildroot.net/results/a63d18fd318783d7e3d1cede062c9c7cacb10282/
Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
package/libnvme/libnvme.mk | 2 ++
1 file changed, 2 insertions(+)
diff --git a/package/libnvme/libnvme.mk b/package/libnvme/libnvme.mk
index 38394b9931..3b622839fa 100644
--- a/package/libnvme/libnvme.mk
+++ b/package/libnvme/libnvme.mk
@@ -10,6 +10,8 @@ LIBNVME_LICENSE = LGPL-2.1
LIBNVME_LICENSE_FILES = COPYING
LIBNVME_INSTALL_STAGING = YES
+LIBNVME_DEPENDENCIES += host-swig
+
LIBNVME_CONF_OPTS += \
-Dtests=false
--
2.34.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH] package/libnvme: needs host-swig
2023-10-26 15:57 [Buildroot] [PATCH] package/libnvme: needs host-swig Giulio Benetti
@ 2023-10-29 11:33 ` Yann E. MORIN
2023-10-29 20:43 ` Giulio Benetti
0 siblings, 1 reply; 3+ messages in thread
From: Yann E. MORIN @ 2023-10-29 11:33 UTC (permalink / raw)
To: Giulio Benetti; +Cc: buildroot
Giulio, All,
On 2023-10-26 17:57 +0200, Giulio Benetti spake thusly:
> Fixes:
> http://autobuild.buildroot.net/results/a63d18fd318783d7e3d1cede062c9c7cacb10282/
>
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
> package/libnvme/libnvme.mk | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/package/libnvme/libnvme.mk b/package/libnvme/libnvme.mk
> index 38394b9931..3b622839fa 100644
> --- a/package/libnvme/libnvme.mk
> +++ b/package/libnvme/libnvme.mk
> @@ -10,6 +10,8 @@ LIBNVME_LICENSE = LGPL-2.1
> LIBNVME_LICENSE_FILES = COPYING
> LIBNVME_INSTALL_STAGING = YES
>
> +LIBNVME_DEPENDENCIES += host-swig
swig is only needed to build the python bindings, no?
In which case it should be in the python conditional block, right?
Regards,
Yann E. MORIN.
> LIBNVME_CONF_OPTS += \
> -Dtests=false
>
> --
> 2.34.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH] package/libnvme: needs host-swig
2023-10-29 11:33 ` Yann E. MORIN
@ 2023-10-29 20:43 ` Giulio Benetti
0 siblings, 0 replies; 3+ messages in thread
From: Giulio Benetti @ 2023-10-29 20:43 UTC (permalink / raw)
To: Yann E. MORIN; +Cc: buildroot
On 29/10/23 12:33, Yann E. MORIN wrote:
> Giulio, All,
>
> On 2023-10-26 17:57 +0200, Giulio Benetti spake thusly:
>> Fixes:
>> http://autobuild.buildroot.net/results/a63d18fd318783d7e3d1cede062c9c7cacb10282/
>>
>> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
>> ---
>> package/libnvme/libnvme.mk | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/package/libnvme/libnvme.mk b/package/libnvme/libnvme.mk
>> index 38394b9931..3b622839fa 100644
>> --- a/package/libnvme/libnvme.mk
>> +++ b/package/libnvme/libnvme.mk
>> @@ -10,6 +10,8 @@ LIBNVME_LICENSE = LGPL-2.1
>> LIBNVME_LICENSE_FILES = COPYING
>> LIBNVME_INSTALL_STAGING = YES
>>
>> +LIBNVME_DEPENDENCIES += host-swig
>
> swig is only needed to build the python bindings, no?
> In which case it should be in the python conditional block, right?
Oh, yes, absolutely.
Thanks for reviewing.
Going to send V2
Kind regards
--
Giulio Benetti
CEO&CTO@Benetti Engineering sas
> Regards,
> Yann E. MORIN.
>
>> LIBNVME_CONF_OPTS += \
>> -Dtests=false
>>
>> --
>> 2.34.1
>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot@buildroot.org
>> https://lists.buildroot.org/mailman/listinfo/buildroot
>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-29 20:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-26 15:57 [Buildroot] [PATCH] package/libnvme: needs host-swig Giulio Benetti
2023-10-29 11:33 ` Yann E. MORIN
2023-10-29 20:43 ` Giulio Benetti
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox