[Buildroot] [PATCH] package/libnvme: needs host-swig

[Buildroot] [PATCH] package/libnvme: needs host-swig

[Giulio Benetti]

Fixes:
http://autobuild.buildroot.net/results/a63d18fd318783d7e3d1cede062c9c7cacb10282/

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 package/libnvme/libnvme.mk | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/package/libnvme/libnvme.mk b/package/libnvme/libnvme.mk
index 38394b9931..3b622839fa 100644
--- a/package/libnvme/libnvme.mk
+++ b/package/libnvme/libnvme.mk
@@ -10,6 +10,8 @@ LIBNVME_LICENSE = LGPL-2.1
 LIBNVME_LICENSE_FILES = COPYING
 LIBNVME_INSTALL_STAGING = YES
 
+LIBNVME_DEPENDENCIES += host-swig
+
 LIBNVME_CONF_OPTS += \
 	-Dtests=false
 
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/libnvme: needs host-swig

[Yann E. MORIN]

Giulio, All,

On 2023-10-26 17:57 +0200, Giulio Benetti spake thusly:
> Fixes:
> http://autobuild.buildroot.net/results/a63d18fd318783d7e3d1cede062c9c7cacb10282/
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
>  package/libnvme/libnvme.mk | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/package/libnvme/libnvme.mk b/package/libnvme/libnvme.mk
> index 38394b9931..3b622839fa 100644
> --- a/package/libnvme/libnvme.mk
> +++ b/package/libnvme/libnvme.mk
> @@ -10,6 +10,8 @@ LIBNVME_LICENSE = LGPL-2.1
>  LIBNVME_LICENSE_FILES = COPYING
>  LIBNVME_INSTALL_STAGING = YES
>  
> +LIBNVME_DEPENDENCIES += host-swig

swig is only needed to build the python bindings, no?
In which case it should be in the python conditional block, right?

Regards,
Yann E. MORIN.

>  LIBNVME_CONF_OPTS += \
>  	-Dtests=false
>  
> -- 
> 2.34.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/libnvme: needs host-swig

[Giulio Benetti]

On 29/10/23 12:33, Yann E. MORIN wrote:
> Giulio, All,
> 
> On 2023-10-26 17:57 +0200, Giulio Benetti spake thusly:
>> Fixes:
>> http://autobuild.buildroot.net/results/a63d18fd318783d7e3d1cede062c9c7cacb10282/
>>
>> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
>> ---
>>   package/libnvme/libnvme.mk | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/package/libnvme/libnvme.mk b/package/libnvme/libnvme.mk
>> index 38394b9931..3b622839fa 100644
>> --- a/package/libnvme/libnvme.mk
>> +++ b/package/libnvme/libnvme.mk
>> @@ -10,6 +10,8 @@ LIBNVME_LICENSE = LGPL-2.1
>>   LIBNVME_LICENSE_FILES = COPYING
>>   LIBNVME_INSTALL_STAGING = YES
>>   
>> +LIBNVME_DEPENDENCIES += host-swig
> 
> swig is only needed to build the python bindings, no?
> In which case it should be in the python conditional block, right?

Oh, yes, absolutely.

Thanks for reviewing.

Going to send V2

Kind regards
-- 
Giulio Benetti
CEO&CTO@Benetti Engineering sas

> Regards,
> Yann E. MORIN.
> 
>>   LIBNVME_CONF_OPTS += \
>>   	-Dtests=false
>>   
>> -- 
>> 2.34.1
>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot@buildroot.org
>> https://lists.buildroot.org/mailman/listinfo/buildroot
> 

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot