Re: [Buildroot] [PATCH v6 08/10] boot/versal-firmware: new boot firmware

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello,

On Fri, 20 Oct 2023 12:42:34 +0100
Neal Frager via buildroot <buildroot@buildroot.org> wrote:

> diff --git a/boot/versal-firmware/Config.in b/boot/versal-firmware/Config.in
> new file mode 100644
> index 0000000000..b7ca7b866f
> --- /dev/null
> +++ b/boot/versal-firmware/Config.in
> @@ -0,0 +1,38 @@
> +config BR2_TARGET_VERSAL_FIRMWARE
> +	bool "versal-firmware"
> +	select BR2_PACKAGE_HOST_TOOLCHAIN_BARE_METAL_BUILDROOT

Selecting host packages is not really needed, and this case it doesn't
even really make sense because this package anyway needs to be
configured to be told for which architecture the bare-metal toolchain
should be compiled.


> +VERSAL_FIRMWARE_VERSION = $(call qstrip,$(BR2_TARGET_VERSAL_FIRMWARE_VERSION))
> +VERSAL_FIRMWARE_SITE = \
> +	$(call github,Xilinx,embeddedsw,$(VERSAL_FIRMWARE_VERSION))
> +VERSAL_FIRMWARE_LICENSE = MIT
> +VERSAL_FIRMWARE_LICENSE_FILES = license.txt
> +VERSAL_FIRMWARE_INSTALL_IMAGES = YES
> +VERSAL_FIRMWARE_INSTALL_TARGET = NO
> +VERSAL_FIRMWARE_DEPENDENCIES = host-newlib-bare-metal

host-toolchain-bare-metal-buildroot

> +
> +CUSTOM_CFLAGS = $(call qstrip,$(BR2_TARGET_VERSAL_FIRMWARE_CUSTOM_CFLAGS))

Please prefix all variables with the package name, i.e VERSAL_FIRMWARE_<something>.

> +VERSAL_CFLAGS = "-Os -flto -ffat-lto-objects $(CUSTOM_CFLAGS)"

Please prefix all variables with the package name, i.e VERSAL_FIRMWARE_<something>.

> +
> +VERSAL_FIRMWARE_PDI = $(call qstrip,$(BR2_TARGET_VERSAL_FIRMWARE_PDI))
> +
> +ifneq ($(findstring ://,$(VERSAL_FIRMWARE_PDI)),)
> +VERSAL_FIRMWARE_EXTRA_DOWNLOADS = $(VERSAL_FIRMWARE_PDI)
> +BR_NO_CHECK_HASH_FOR += $(notdir $(VERSAL_FIRMWARE_PDI))
> +PDI_PATH = $(VERSAL_FIRMWARE_DL_DIR)/$(notdir $(VERSAL_FIRMWARE_PDI))

Please prefix all variables with the package name, i.e VERSAL_FIRMWARE_<something>.

> +else ifneq ($(VERSAL_FIRMWARE_PDI),)
> +PDI_PATH = $(shell readlink -f $(VERSAL_FIRMWARE_PDI))

Please prefix all variables with the package name, i.e VERSAL_FIRMWARE_<something>.

> +endif #VERSAL_FIRMWARE_PDI
> +
> +define VERSAL_FIRMWARE_BUILD_CMDS
> +	$(MAKE) -C $(@D)/lib/sw_apps/versal_plm/src/versal \
> +		COMPILER=$(HOST_DIR)/bin/microblazeel-xilinx-elf-gcc \
> +		ARCHIVER=$(HOST_DIR)/bin/microblazeel-xilinx-elf-gcc-ar \
> +		CC=$(HOST_DIR)/bin/microblazeel-xilinx-elf-gcc \
> +		CFLAGS=$(VERSAL_CFLAGS)
> +		
> +	$(MAKE) -C $(@D)/lib/sw_apps/versal_psmfw/src/versal \
> +		COMPILER=$(HOST_DIR)/bin/microblazeel-xilinx-elf-gcc \
> +		ARCHIVER=$(HOST_DIR)/bin/microblazeel-xilinx-elf-gcc-ar \
> +		CC=$(HOST_DIR)/bin/microblazeel-xilinx-elf-gcc \
> +		CFLAGS=$(VERSAL_CFLAGS)
> +endef
> +
> +PLM_PATH = $(@D)/lib/sw_apps/versal_plm/src/versal/plm.elf
> +PSMFW_PATH = $(@D)/lib/sw_apps/versal_psmfw/src/versal/psmfw.elf

Please prefix all variables with the package name, i.e VERSAL_FIRMWARE_<something>.

> diff --git a/boot/versal-firmware/xilinx_v2023.1/0001-sw_apps-versal_plm-add-support-of-parallel-build.patch b/boot/versal-firmware/xilinx_v2023.1/0001-sw_apps-versal_plm-add-support-of-parallel-build.patch
> new file mode 100644
> index 0000000000..84fffc1d82
> --- /dev/null
> +++ b/boot/versal-firmware/xilinx_v2023.1/0001-sw_apps-versal_plm-add-support-of-parallel-build.patch
> @@ -0,0 +1,157 @@
> +From 245509f87776c7727973480f08ead6f293a2f3b2 Mon Sep 17 00:00:00 2001
> +From: Neal Frager <neal.frager@amd.com>
> +Date: Mon, 4 Sep 2023 07:08:02 +0100
> +Subject: [PATCH 1/2] sw_apps:versal_plm: add support of parallel build

No patch numbering (reported by "make check-package")


> +Subject: [PATCH 2/2] sw_apps:versal_psmfw: add support of parallel build

No patch numbering (reported by "make check-package")

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot