Re: [Buildroot] [PATCH v5 3/3] package/webkitgtk: bump to version 2.42.2

[Adrian Perez de Castro <aperez@igalia.com>]

[-- Attachment #1.1: Type: text/plain, Size: 2493 bytes --]

Hi Thomas,

Thanks for the patch set with the fixes and the update to 2.42.x, I have
reviewed and tested the other two patches (they are good!) but this one
needs one more change before it can be merged, please read the comment
below.

On Fri, 10 Nov 2023 17:46:17 +0100 Thomas Devoogdt <thomas@devoogdt.com> wrote:
> Update to a new major release.
> 
> Release notes:
> 
> https://webkitgtk.org/2023/09/15/webkitgtk2.42.0-released.html
> https://webkitgtk.org/2023/09/27/webkitgtk2.42.1-released.html
> https://webkitgtk.org/2023/11/10/webkitgtk2.42.2-released.html
> 
> Security notes:
> 
> https://webkitgtk.org/security/WSA-2023-0008.html
> 
> - USE_JPEGXL is enabled by default now [1], so add a libjxl if used.
> 
> - ENABLE_GLES2 has been dropped, so drop it also here [2].
>   Instead, enable USE_OPENGL_OR_ES if libgles is present. Beware that also
>   libegl is needed for USE_OPENGL_OR_ES, but that one is most of the time a
>   dependency for libgles, so leave it out here.
> 
> - Also raise the minimal GCC version to 10.2, which is required since webkitgtk-2.42.x [3].
>   Similar to commit ec1ff802df9a0f17dd2b734ba536a5e206aa5aa4,
>   we do check on >= GCC 10, because we can't check on >= GCC 10.2.
> 
> [1] https://github.com/WebKit/WebKit/commit/93865414f33190c57e293a80492e10edc461d7f0
> [2] https://github.com/WebKit/WebKit/commit/cfe917fec45bf72c371087ece034feee8454f1b4
> [3] https://github.com/WebKit/WebKit/commit/133498aaee8f44443d9e3b2a08be4a4b77b93fc9
> 
> Signed-off-by: Thomas Devoogdt <thomas.devoogdt@barco.com>
> ---
>  v2: n/a
>  v3:
>  - replace for package/webkitgtk: add a USE_OPENGL_OR_ES config option
>  - 2.42.0 needs an extra bunch of patches, so bump to immediately to 2.42.1
>  v4:
>  - fixed incomplete git massage (a ____ line splits the git message apparently)
>  - re-added patches with upstream cherry-pick and hash
>  v5:
>  - 2.42.1 needs an extra bunch of patches, so bump to immediately to 2.42.2

Patch "0002-WPE-GTK-ExtensionsGLOpenGLES.cpp-uses-GLES3-symbols-.patch" also
needs to be removed: it does not apply because the fix has been imported
upstream and is part of the 2.42.x releases.

> ---
>  ...e-when-gstreamer-support-is-disabled.patch | 36 -------------------
>  package/webkitgtk/Config.in                   |  6 ++--
>  package/webkitgtk/webkitgtk.hash              |  6 ++--
>  package/webkitgtk/webkitgtk.mk                | 16 ++++++---
>  4 files changed, 17 insertions(+), 47 deletions(-)
>
> [...]

Cheers,
—Adrián

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot