Re: [Buildroot] [PATCH v5 2/3] package/webkitgtk: select wpebackend-fdo if wayland target is enabled

From: Adrian Perez de Castro <aperez@igalia.com>
To: Thomas Devoogdt <thomas@devoogdt.com>
Cc: Thomas Devoogdt <thomas@devoogdt.com>,
	buildroot@buildroot.org,
	Thomas Devoogdt <thomas.devoogdt@barco.com>,
	"Yann E . MORIN" <yann.morin.1998@free.fr>
Subject: Re: [Buildroot] [PATCH v5 2/3] package/webkitgtk: select wpebackend-fdo if wayland target is enabled
Date: Fri, 1 Dec 2023 00:48:34 +0200	[thread overview]
Message-ID: <20231201004834.GH232434@igalia.com> (raw)
In-Reply-To: <20231114150725.GD1974649@igalia.com>


[-- Attachment #1.1: Type: text/plain, Size: 2648 bytes --]

On Tue, 14 Nov 2023 15:07:25 +0200 Adrian Perez de Castro <aperez@igalia.com> wrote:
> On Fri, 10 Nov 2023 17:46:16 +0100 Thomas Devoogdt <thomas@devoogdt.com> wrote:
> > libwep & wpebackend-fdo are mandatory if ENABLE_WAYLAND_TARGET and EGL_FOUND
> > https://github.com/WebKit/WebKit/blob/2e35890b1fa9da39ffaa88e0acd973beb55d4ad2/Source/cmake/OptionsGTK.cmake#L388-L400
> > 
> > egl is mandatory if ENABLE_WAYLAND_TARGET
> > https://github.com/WebKit/WebKit/blob/2e35890b1fa9da39ffaa88e0acd973beb55d4ad2/Source/cmake/OptionsGTK.cmake#L462-L473
> > 
> > So wpebackend-fdo (-> libwpe) has to be selected if BR2_PACKAGE_LIBGTK3_WAYLAND.
> > 
> > Signed-off-by: Thomas Devoogdt <thomas.devoogdt@barco.com>
> 
> Tested-By: Adrian Perez de Castro <aperez@igalia.com>

Acked-by: Adrian Perez de Castro <aperez@igalia.com>
 
> > ---
> > v2: n/a
> > v3,4,5: no change (added from another patch serie)
> > ---
> >  package/webkitgtk/Config.in    | 1 +
> >  package/webkitgtk/webkitgtk.mk | 2 +-
> >  2 files changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/package/webkitgtk/Config.in b/package/webkitgtk/Config.in
> > index 927792b1e4..cb10784133 100644
> > --- a/package/webkitgtk/Config.in
> > +++ b/package/webkitgtk/Config.in
> > @@ -53,6 +53,7 @@ config BR2_PACKAGE_WEBKITGTK
> >  	select BR2_PACKAGE_WEBP
> >  	select BR2_PACKAGE_WEBP_DEMUX
> >  	select BR2_PACKAGE_WOFF2
> > +	select BR2_PACKAGE_WPEBACKEND_FDO if BR2_PACKAGE_LIBGTK3_WAYLAND
> >  	select BR2_PACKAGE_XLIB_LIBXCOMPOSITE if BR2_PACKAGE_LIBGTK3_X11
> >  	select BR2_PACKAGE_XLIB_LIBXDAMAGE if BR2_PACKAGE_LIBGTK3_X11
> >  	select BR2_PACKAGE_XLIB_LIBXRENDER if BR2_PACKAGE_LIBGTK3_X11
> > diff --git a/package/webkitgtk/webkitgtk.mk b/package/webkitgtk/webkitgtk.mk
> > index 88bdfae27b..9c68fe73cf 100644
> > --- a/package/webkitgtk/webkitgtk.mk
> > +++ b/package/webkitgtk/webkitgtk.mk
> > @@ -115,7 +115,7 @@ ifeq ($(BR2_PACKAGE_LIBGTK3_X11):$(BR2_PACKAGE_LIBGTK3_WAYLAND):$(BR2_PACKAGE_LI
> >  WEBKITGTK_DEPENDENCIES += libegl
> >  endif
> >  
> > -ifeq ($(BR2_PACKAGE_LIBGTK3_WAYLAND)$(BR2_PACKAGE_WPEBACKEND_FDO),yy)
> > +ifeq ($(BR2_PACKAGE_WPEBACKEND_FDO),y)
> >  WEBKITGTK_CONF_OPTS += -DUSE_WPE_RENDERER=ON
> >  WEBKITGTK_DEPENDENCIES += wpebackend-fdo
> >  else
> > -- 
> > 2.34.1
> > 
> > _______________________________________________
> > buildroot mailing list
> > buildroot@buildroot.org
> > https://lists.buildroot.org/mailman/listinfo/buildroot
> > 
> 
> Cheers,
> —Adrián
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

Cheers,
—Adrián

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot