From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Thomas Devoogdt <thomas@devoogdt.com>
Cc: Adrian Perez de Castro <aperez@igalia.com>,
Thomas Devoogdt <thomas.devoogdt@barco.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v5 1/3] package/webkitgtk: make gbm support optional
Date: Sat, 27 Jan 2024 17:35:04 +0100 [thread overview]
Message-ID: <ZbUwuCcPe2f06d9-@landeda> (raw)
In-Reply-To: <20231110164617.569602-1-thomas@devoogdt.com>
Thomas, All,
On 2023-11-10 17:46 +0100, Thomas Devoogdt spake thusly:
> This was added upstream in commit:
>
> https://github.com/WebKit/WebKit/commit/22e4c0386605d84f42f2d46fd20bdc46e3078498
>
> The 'USE_OPENGL_OR_ES' flag is default ON, which will enable 'USE_GBM',
> so ensure that we unset 'USE_GBM' if we don't have libgbm.
>
> Signed-off-by: Thomas Devoogdt <thomas.devoogdt@barco.com>
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> v2,3,4,5: no change
> ---
> package/webkitgtk/webkitgtk.mk | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/package/webkitgtk/webkitgtk.mk b/package/webkitgtk/webkitgtk.mk
> index bb6df3d592..88bdfae27b 100644
> --- a/package/webkitgtk/webkitgtk.mk
> +++ b/package/webkitgtk/webkitgtk.mk
> @@ -88,6 +88,13 @@ else
> WEBKITGTK_CONF_OPTS += -DENABLE_GLES2=OFF
> endif
>
> +ifeq ($(BR2_PACKAGE_HAS_LIBGBM),y)
> +WEBKITGTK_CONF_OPTS += -DUSE_GBM=ON
> +WEBKITGTK_DEPENDENCIES += libgbm
> +else
> +WEBKITGTK_CONF_OPTS += -DUSE_GBM=OFF
> +endif
> +
> ifeq ($(BR2_PACKAGE_LIBGTK3_X11),y)
> WEBKITGTK_CONF_OPTS += -DENABLE_X11_TARGET=ON
> WEBKITGTK_DEPENDENCIES += libgl \
> --
> 2.34.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-01-27 16:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Thomas Devoogdt <20231001165218.1960930-3-thomas.devoogdt@barco.com>
2023-11-10 16:46 ` [Buildroot] [PATCH v5 1/3] package/webkitgtk: make gbm support optional Thomas Devoogdt
2023-11-10 16:46 ` [Buildroot] [PATCH v5 2/3] package/webkitgtk: select wpebackend-fdo if wayland target is enabled Thomas Devoogdt
2023-11-14 13:07 ` Adrian Perez de Castro
2023-11-30 22:48 ` Adrian Perez de Castro
2024-02-28 16:19 ` Peter Korsgaard
2024-01-27 16:30 ` Yann E. MORIN
2023-11-10 16:46 ` [Buildroot] [PATCH v5 3/3] package/webkitgtk: bump to version 2.42.2 Thomas Devoogdt
2023-11-14 13:11 ` Adrian Perez de Castro
2023-11-14 20:06 ` Thomas Devoogdt
2023-11-30 22:44 ` Adrian Perez de Castro
2023-11-30 22:47 ` Adrian Perez de Castro
2024-01-27 16:35 ` Yann E. MORIN
2024-02-28 16:24 ` Peter Korsgaard
2023-11-14 13:06 ` [Buildroot] [PATCH v5 1/3] package/webkitgtk: make gbm support optional Adrian Perez de Castro
2023-11-30 22:48 ` Adrian Perez de Castro
2024-02-28 16:19 ` Peter Korsgaard
2024-01-27 16:35 ` Yann E. MORIN [this message]
2023-10-01 16:52 [Buildroot] [PATCH v4 " Thomas Devoogdt
2023-10-01 16:52 ` [Buildroot] [PATCH v4 2/3] package/webkitgtk: select wpebackend-fdo if wayland target is enabled Thomas Devoogdt
2023-10-01 16:52 ` [Buildroot] [PATCH v4 3/3] package/webkitgtk: bump to version 2.42.1 Thomas Devoogdt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZbUwuCcPe2f06d9-@landeda \
--to=yann.morin.1998@free.fr \
--cc=aperez@igalia.com \
--cc=buildroot@buildroot.org \
--cc=thomas.devoogdt@barco.com \
--cc=thomas@devoogdt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox