From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Marleen Vos via buildroot <buildroot@buildroot.org>
Cc: Marleen Vos <marleen.vos@mind.be>, marleen.vos@essensium.com
Subject: Re: [Buildroot] [PATCH 2/7] board/stmicroelectronics: generalise BR2_TARGET_ARM_TRUSTED_FIRMWARE_ADDITIONAL_VARIABLES regex
Date: Tue, 6 Feb 2024 14:23:41 +0100 [thread overview]
Message-ID: <20240206142341.691cf57c@windsurf> (raw)
In-Reply-To: <20231219121508.1695768-3-marleen.vos@mind.be>
On Tue, 19 Dec 2023 13:15:03 +0100
Marleen Vos via buildroot <buildroot@buildroot.org> wrote:
> From: Marleen Vos <marleen.vos@mind.be>
>
> The regex was a bit too strict in which characters it allowed. Thus,
> if e.g. a file name appears in the
> BR2_TARGET_ARM_TRUSTED_FIRMWARE_ADDITIONAL_VARIABLES string, it no
> longer matches, and we end up with an empty ATF_VARIABLES. This makes
> the subsequent grep fail, and the post-image.sh script fails without
> any error message (thanks to the -e option).
>
> Simplify the regex to match everything except the closing quotation
> mark. Note that Kconfig doesn't allow quotation marks at all inside a
> string (even escaped ones), so this regular expression is always OK.
>
> Signed-off-by: Marleen Vos <marleen.vos@mind.be>
> ---
> board/stmicroelectronics/common/stm32mp157/post-image.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-02-06 13:23 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-19 12:15 [Buildroot] [PATCH 0/7] Updates for boards based on stm32mp157, related to arm-trusted-firmware Marleen Vos via buildroot
2023-12-19 12:15 ` [Buildroot] [PATCH 1/7] DEVELOPERS: added marleen.vos@mind.be for boards/configs based on stm32mp15 Marleen Vos via buildroot
2024-02-06 13:23 ` Thomas Petazzoni via buildroot
2023-12-19 12:15 ` [Buildroot] [PATCH 2/7] board/stmicroelectronics: generalise BR2_TARGET_ARM_TRUSTED_FIRMWARE_ADDITIONAL_VARIABLES regex Marleen Vos via buildroot
2024-02-06 13:23 ` Thomas Petazzoni via buildroot [this message]
2023-12-19 12:15 ` [Buildroot] [PATCH 3/7] configs/stm32mp157*: bump ATF to v2.6 Marleen Vos via buildroot
2024-02-06 13:23 ` Thomas Petazzoni via buildroot
2023-12-19 12:15 ` [Buildroot] [PATCH 4/7] boot/arm-trusted-firmware: add config option to use latest lts-v2.8.13 Marleen Vos via buildroot
2024-02-06 13:25 ` Thomas Petazzoni via buildroot
2024-02-06 13:38 ` Arnout Vandecappelle via buildroot
2024-02-06 13:39 ` Thomas Petazzoni via buildroot
2024-02-06 13:59 ` Arnout Vandecappelle via buildroot
2024-02-06 16:38 ` Thomas Petazzoni via buildroot
2023-12-19 12:15 ` [Buildroot] [PATCH 5/7] configs/stm32mp157a_dk1_defconfig: update arm-trusted-firmware to lts-v2.8.13 Marleen Vos via buildroot
2024-02-06 16:38 ` Thomas Petazzoni via buildroot
2023-12-19 12:15 ` [Buildroot] [PATCH 6/7] configs/stm32mp157c_dk2_defconfig: " Marleen Vos via buildroot
2024-02-06 16:38 ` Thomas Petazzoni via buildroot
2023-12-19 12:15 ` [Buildroot] [PATCH 7/7] boot/arm-trusted-firmware: bump latest version to v2.10 Marleen Vos via buildroot
2024-02-06 13:39 ` Thomas Petazzoni via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240206142341.691cf57c@windsurf \
--to=buildroot@buildroot.org \
--cc=marleen.vos@essensium.com \
--cc=marleen.vos@mind.be \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox