Re: [Buildroot] [PATCH 4/7] boot/arm-trusted-firmware: add config option to use latest lts-v2.8.13

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Marleen,

On Tue, 19 Dec 2023 13:15:05 +0100
Marleen Vos via buildroot <buildroot@buildroot.org> wrote:

> From: Marleen Vos <marleen.vos@mind.be>
> 
> Patch 0001-feat-build-add-support-for-new-binutils-versions.patch as
> found in v2.8 patch dir has already been applied in lts-v2.8.13
> Patch 0002-build-tools-avoid-unnecessary-link.patch from v2.8 has
> been included as 0001-build-tools-avoid-unnecessary-link.patch for
> lts-v2.8.13
> 
> Signed-off-by: Marleen Vos <marleen.vos@mind.be>

Thanks for the good arguments from Arnout, we got convinced and applied
your patch to master, with a few changes, see below.

> +config BR2_TARGET_ARM_TRUSTED_FIRMWARE_LATEST_LTS_v2_8_VERSION

                                                     ^^^ we dropped the "v" from here

>  sha256  327c65b1bc231608a7a808b068b00c1a22310e9fc86158813cd10a9711d5725e  arm-trusted-firmware-v2.7.tar.gz
> +sha256  e55ae7105c996b60f748b2eb6adeaf5ac8946425e1d4294ecc1c56aebf435274  trusted-firmware-a-lts-v2.8.13.tar.gz

We were surprised by the files having different base names here. Turns
out the hash of trusted-firmware-a-lts-v2.8.13.tar.gz was in fact never
checked, which is why you didn't release that
trusted-firmware-a-lts-v2.8.13.tar.gz was an incorrect file name. So we
added a preliminary commit to make sure that this hash will be checked,
and fixed the file name.

See:

  https://gitlab.com/buildroot.org/buildroot/-/commit/c6ab9328e13c6c9a1538b4a33824525a990b623d
  https://gitlab.com/buildroot.org/buildroot/-/commit/2a310666e06c9c5edd6879d32295c63b7851c817

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot