Re: [Buildroot] [PATCH 4/7] boot/arm-trusted-firmware: add config option to use latest lts-v2.8.13

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Marleen,

On Tue, 19 Dec 2023 13:15:05 +0100
Marleen Vos via buildroot <buildroot@buildroot.org> wrote:

> From: Marleen Vos <marleen.vos@mind.be>
> 
> Patch 0001-feat-build-add-support-for-new-binutils-versions.patch as
> found in v2.8 patch dir has already been applied in lts-v2.8.13
> Patch 0002-build-tools-avoid-unnecessary-link.patch from v2.8 has
> been included as 0001-build-tools-avoid-unnecessary-link.patch for
> lts-v2.8.13
> 
> Signed-off-by: Marleen Vos <marleen.vos@mind.be>
> ---
>  boot/arm-trusted-firmware/Config.in           |  6 ++
>  .../arm-trusted-firmware.hash                 |  1 +
>  ...1-build-tools-avoid-unnecessary-link.patch | 77 +++++++++++++++++++
>  3 files changed, 84 insertions(+)
>  create mode 100644 boot/arm-trusted-firmware/lts-v2.8.13/0001-build-tools-avoid-unnecessary-link.patch

Thanks a lot for this patch. However, I don't think we want to add
explicit choice options for all "random" versions of TF-A. Instead, if
you want to use this lts-v2.8.13 version for STM32MP1 defconfigs, you
should simply set BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_VERSION_VALUE
to lts-v2.8.13, and have a BR2_GLOBAL_PATCH_DIR with the patch that you
need to apply on top of it.

Due to this, I will mark your patches 4, 5 and 6 in this series as
Changes Requested. If you have the chance to do this update and send a
new iteration, it would be nice!

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot