Re: [Buildroot] [PATCH v4 07/20] boot/ti-k3-image-gen: manage HS hardware

[Andreas Dannenberg via buildroot <buildroot@buildroot.org>]

Hi Alexander,

On Sun, Feb 18, 2024 at 12:45:47AM +0100, Alexander Sverdlin wrote:
> Hi Dario,
> 
> On Sat, 2024-02-17 at 17:02 +0100, Dario Binacchi wrote:
> > The patch sets the configurations required by TI HS systems. Some of these
> > configurations (i. e. HS SYSFW image signing key, HS Software Revision)
> > are provided by the ti-k3-core-secdev package in the binaries directory.
> > 
> > Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> 
> so for test I've reverted the previous "boot/ti-k3-core-secdev: new package"
> commit, then...
> 
> > ---
> > 
> > no changes since v3:
> > 
> > Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> > ---
> >  boot/ti-k3-image-gen/Config.in          |  1 +
> >  boot/ti-k3-image-gen/ti-k3-image-gen.mk | 16 ++++++++++++++--
> >  2 files changed, 15 insertions(+), 2 deletions(-)
> > 
> > diff --git a/boot/ti-k3-image-gen/Config.in b/boot/ti-k3-image-gen/Config.in
> > index d76cef82e911..38d1598d9fc0 100644
> > --- a/boot/ti-k3-image-gen/Config.in
> > +++ b/boot/ti-k3-image-gen/Config.in
> > @@ -2,6 +2,7 @@ config BR2_TARGET_TI_K3_IMAGE_GEN
> >  	bool "ti-k3-image-gen"
> >  	depends on BR2_TARGET_TI_K3_R5_LOADER
> >  	select BR2_TARGET_TI_K3_BOOT_FIRMWARE
> > +	select BR2_TARGET_TI_K3_CORE_SECDEV if BR2_TARGET_TI_K3_IMAGE_GEN_SECTYPE_HS_FS || BR2_TARGET_TI_K3_IMAGE_GEN_SECTYPE_HS
> 
> ... removed this, ...
> 
> >  	# We need FIT support in uboot-tools, which is why we select a
> >  	# host package
> >  	select BR2_PACKAGE_HOST_UBOOT_TOOLS
> > diff --git a/boot/ti-k3-image-gen/ti-k3-image-gen.mk b/boot/ti-k3-image-gen/ti-k3-image-gen.mk
> > index 64be9a18f2c4..74b4fcb4bf89 100644
> > --- a/boot/ti-k3-image-gen/ti-k3-image-gen.mk
> > +++ b/boot/ti-k3-image-gen/ti-k3-image-gen.mk
> > @@ -29,10 +29,21 @@ TI_K3_IMAGE_GEN_FW_TYPE = $(call qstrip,$(BR2_TARGET_TI_K3_IMAGE_GEN_FW_TYPE))
> >  TI_K3_IMAGE_GEN_SOC = $(call qstrip,$(BR2_TARGET_TI_K3_IMAGE_GEN_SOC))
> >  TI_K3_IMAGE_GEN_SECTYPE = $(call qstrip,$(BR2_TARGET_TI_K3_IMAGE_GEN_SECTYPE))
> >  
> > -TI_K3_IMAGE_GEN_SYSFW = $(TI_K3_IMAGE_GEN_FW_TYPE)-firmware-$(TI_K3_IMAGE_GEN_SOC)-$(TI_K3_IMAGE_GEN_SECTYPE).bin
> > +ifeq ($(BR2_TARGET_TI_K3_IMAGE_GEN_SECTYPE_GP),y)
> > +TI_K3_IMAGE_GEN_SYSFW = \
> > +	$(TI_K3_IMAGE_GEN_FW_TYPE)-firmware-$(TI_K3_IMAGE_GEN_SOC)-$(TI_K3_IMAGE_GEN_SECTYPE).bin
> > +else
> > +TI_K3_IMAGE_GEN_DEPENDENCIES += ti-k3-core-secdev
> 
> ... the above line, ...
> 
> > +
> > +TI_K3_IMAGE_GEN_SYSFW = \
> > +	$(TI_K3_IMAGE_GEN_FW_TYPE)-firmware-$(TI_K3_IMAGE_GEN_SOC)-$(TI_K3_IMAGE_GEN_SECTYPE)-enc.bin \
> > +	$(TI_K3_IMAGE_GEN_FW_TYPE)-firmware-$(TI_K3_IMAGE_GEN_SOC)-$(TI_K3_IMAGE_GEN_SECTYPE)-cert.bin
> > +endif
> >  
> >  define TI_K3_IMAGE_GEN_CONFIGURE_CMDS
> > -	cp $(BINARIES_DIR)/ti-sysfw/$(TI_K3_IMAGE_GEN_SYSFW) $(@D)
> > +	$(foreach t,$(TI_K3_IMAGE_GEN_SYSFW),\
> > +		cp $(BINARIES_DIR)/ti-sysfw/$(t) $(@D)/
> > +	)
> >  endef
> >  
> >  define TI_K3_IMAGE_GEN_BUILD_CMDS
> > @@ -40,6 +51,7 @@ define TI_K3_IMAGE_GEN_BUILD_CMDS
> >  	$(BR2_MAKE) -C $(@D) \
> >  		SOC=$(TI_K3_IMAGE_GEN_SOC) \
> >  		SOC_TYPE=$(TI_K3_IMAGE_GEN_SECTYPE) \
> > +		TI_SECURE_DEV_PKG=$(BINARIES_DIR)/ti-k3-core-secdev \
> 
> ... and this line...
> 
> >  		CONFIG=evm \
> >  		CROSS_COMPILE=$(HOST_DIR)/bin/arm-none-eabi- \
> >  		SBL=$(BINARIES_DIR)/r5-u-boot-spl.bin \
> 
> ... and everything still builds and boots fine on SK-AM62B (HS-FS):
> 
> U-Boot SPL 2024.01 (Feb 18 2024 - 00:02:43 +0100)
> SYSFW ABI: 3.1 (firmware rev 0x0008 '8.6.4--v08.06.04 (Chill Capybar')
> SPL initial stack usage: 13400 bytes
> Trying to boot from MMC2
> Authentication passed
> Authentication passed
> Authentication passed
> Authentication passed
> Authentication passed
> Starting ATF on ARM64 core...
> 
> NOTICE:  BL31: v2.7(release):v2.7
> NOTICE:  BL31: Built : 23:57:43, Feb 17 2024
> I/TC: 
> I/TC: OP-TEE version: Unknown_4.0 (gcc version 12.3.0 (Buildroot 2023.11-1199-g470b2069e4)) #1 Sat Feb 17 22:57:38 UTC 2024 aarch64
> I/TC: WARNING: This OP-TEE configuration might be insecure!
> I/TC: WARNING: Please check https://optee.readthedocs.io/en/latest/architecture/porting_guidelines.html
> I/TC: Primary CPU initializing
> I/TC: SYSFW ABI: 3.1 (firmware rev 0x0008 '8.6.4--v08.06.04 (Chill Capybar')
> I/TC: HUK Initialized
> I/TC: Activated SA2UL device
> I/TC: Enabled firewalls for SA2UL TRNG device
> I/TC: SA2UL TRNG initialized
> I/TC: SA2UL Drivers initialized
> I/TC: Primary CPU switching to normal world boot
> 
> U-Boot SPL 2024.01 (Feb 18 2024 - 00:03:30 +0100)
> SYSFW ABI: 3.1 (firmware rev 0x0008 '8.6.4--v08.06.04 (Chill Capybar')
> SPL initial stack usage: 1872 bytes
> Trying to boot from MMC2
> Authentication passed
> Authentication passed
> 
> 
> U-Boot 2024.01 (Feb 18 2024 - 00:03:30 +0100)
> 
> SoC:   AM62X SR1.0 HS-FS
> Model: Texas Instruments AM625 SK
> DRAM:  2 GiB
> Core:  56 devices, 23 uclasses, devicetree: separate
> MMC:   mmc@fa10000: 0, mmc@fa00000: 1
> Loading Environment from nowhere... OK
> In:    serial@2800000
> Out:   serial@2800000
> Err:   serial@2800000
> Net:   eth0: ethernet@8000000port@1
> Hit any key to stop autoboot:  0 
> switch to partitions #0, OK
> mmc1 is current device
> SD/MMC found on device 1
> Failed to load 'uEnv.txt'
> Scanning for bootflows in all bootdevs
> Seq  Method       State   Uclass    Part  Name                      Filename
> ---  -----------  ------  --------  ----  ------------------------  ----------------
> Scanning global bootmeth 'efi_mgr':
> No EFI system partition
> No EFI system partition
> Failed to persist EFI variables
> Scanning bootdev 'mmc@fa00000.bootdev':
>   0  extlinux     ready   mmc          1  mmc@fa00000.bootdev.part_ /extlinux/extlinux.conf
> ** Booting bootflow 'mmc@fa00000.bootdev.part_1' with extlinux
> 1:      am62x-sk-buildroot
> Retrieving file: /Image
> append: console=ttyS2,115200n8 root=/dev/mmcblk1p2 rw rootfstype=ext4 rootwait earlycon=ns16550a,mmio32,0x02800000
> Retrieving file: /k3-am62x.dtb
> ## Flattened Device Tree blob at ffb14700
>    Booting using the fdt blob at 0xffb14700
> Working FDT set to ffb14700
>    Loading Device Tree to 000000008ffed000, end 000000008ffff687 ... OK
> Working FDT set to 8ffed000
> 
> Starting kernel ...
> 
> [    0.000000] Booting Linux on physical CPU 0x0000000000 [0x410fd034]

Just wanting to double-check one quick detail. Did you have to make any
additional modifications to boot-mode related U-Boot settings or ENV
variables? Or did the "new normal" of CONFIG_BOOTSTD just work for you? 


--
Andreas Dannenberg
Texas Instruments Inc



> [    0.000000] Linux version 6.6.1 (...) (aarch64-buildroot-linux-gnu-gcc.br_real (Buildroot 2023.11-1199-g470b2069e4) 12.3.0, GNU ld (GNU Binutils) 2.40) #1 SMP PREEMPT Sun Feb 18 
> 00:37:47 CET 2024
> 
> 
> 
> -- 
> Alexander Sverdlin.
> 
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot