Re: [Buildroot] [PATCH v4 14/20] boot/uboot: set BINMAN_INDIRS for TI K3 DM

From: Alexander Sverdlin <alexander.sverdlin@gmail.com>
To: Dario Binacchi <dario.binacchi@amarulasolutions.com>,
	 buildroot@buildroot.org
Cc: michael@amarulasolutions.com, Asaf Kahlon <asafka7@gmail.com>,
	Xuanhao Shi <X15000177@gmail.com>,
	James Hilliard <james.hilliard1@gmail.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Romain Naour <romain.naour@smile.fr>,
	Andreas Dannenberg <dannenberg@ti.com>,
	linux-amarula@amarulasolutions.com, bryce@redpinelabs.com,
	Anand Gadiyar <gadiyar@ti.com>
Subject: Re: [Buildroot] [PATCH v4 14/20] boot/uboot: set BINMAN_INDIRS for TI K3 DM
Date: Sat, 17 Feb 2024 21:44:29 +0100	[thread overview]
Message-ID: <95a8a71f608575339cd61ba5ed09b93d8714c01c.camel@gmail.com> (raw)
In-Reply-To: <20240217160244.1320482-15-dario.binacchi@amarulasolutions.com>

Hi Dario,

On Sat, 2024-02-17 at 17:02 +0100, Dario Binacchi wrote:
> As explained in [1], adding support for AM62x LP SK in U-Boot, requires
> binman for building bootloader images. The BINMAN_INDIRS environment
> variable is used to provide a space-separated list of directories to
> search for binary blobs.
> 
> [1] https://patchwork.ozlabs.org/project/uboot/patch/20231030110138.1347603-3-n-yadav@ti.com/
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> 
> ---
> 
> no changes since v1:
> 
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> ---
>  boot/uboot/uboot.mk | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/boot/uboot/uboot.mk b/boot/uboot/uboot.mk
> index dda606a88059..cf70f86a4132 100644
> --- a/boot/uboot/uboot.mk
> +++ b/boot/uboot/uboot.mk
> @@ -189,7 +189,8 @@ endif
>  ifeq ($(BR2_TARGET_UBOOT_NEEDS_TI_K3_DM),y)
>  UBOOT_TI_K3_DM_SOCNAME = $(call qstrip,$(BR2_TARGET_UBOOT_TI_K3_DM_SOCNAME))
>  UBOOT_DEPENDENCIES += ti-k3-boot-firmware
> -UBOOT_MAKE_OPTS += DM=$(BINARIES_DIR)/ti-dm/$(UBOOT_TI_K3_DM_SOCNAME)/ipc_echo_testb_mcu1_0_release_strip.xer5f
> +UBOOT_MAKE_OPTS += DM=$(BINARIES_DIR)/ti-dm/$(UBOOT_TI_K3_DM_SOCNAME)/ipc_echo_testb_mcu1_0_release_strip.xer5f \

Is the above actually still required with binman?
The names are hardcoded in U-Boot in arch/arm/dts/k3-am625-sk-binman.dtsi

> +	BINMAN_INDIRS=$(BINARIES_DIR)

This seems to be the only required part.

>  endif
>  
>  ifeq ($(BR2_TARGET_UBOOT_NEEDS_OPENSBI),y)

-- 
Alexander Sverdlin.

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot