Re: [Buildroot] [PATCH v4 00/20] Add support for AM62x-SK HS-FS devices

[Andreas Dannenberg via buildroot <buildroot@buildroot.org>]

On Mon, Feb 19, 2024 at 12:24:52PM +0100, Romain Naour wrote:
> Hello Michael,
> 
> Le 19/02/2024 à 12:02, Michael Nazzareno Trimarchi a écrit :
> > Hi Romain
> > 
> > On Mon, Feb 19, 2024 at 10:30 AM Romain Naour <romain.naour@smile.fr> wrote:
> >>
> >> Hello Dario,
> >>
> >> Le 17/02/2024 à 17:02, Dario Binacchi a écrit :
> >>> The SK-AM62B-P1 is the newest version of SK-AM62 which includes
> >>> high-security field-securable (HS-FS) silicon to optionally customize keys
> >>> and encryption for security applications.
> >>> This requires enabling the BR2_TARGET_TI_K3_IMAGE_GEN_SECTYPE_HS_FS option,
> >>> which, however, was buggy. This series fixes the errors and bumps the Linux
> >>> kernel and U-Boot required for such a new device.
> >>>
> >>> This series, which in my humble opinion, should have been immediately
> >>> considered to correct the compilation errors in case of HS-FS devcies, has
> >>> seen an increase in patches in version 4 to remove the ti-k3-image-gen
> >>> package thanks to Binman. Additionally, it shares some modifications and
> >>> views on how to implement certain changes with the series
> >>> https://patchwork.ozlabs.org/project/buildroot/list/?series=394840.
> >>> Therefore, I think it is necessary not to run them in parallel but to decide
> >>> whether to merge one before the other or to consider a single series where
> >>> the patches can be coherent with each other. I am available for both solutions.
> >>> Let me know.
> >>
> >> Thanks for this new version. I beleive both series should be merged into one
> >> since we want to follow u-boot switch to binman, add more TI K3 SoC support and
> >> keeping exising am62x ans am64x working in GP or HS/HS-FS.
> >>
> > 
> > Because the Dario patchset was sent before (end of November), it's
> > reasonable to review and adjust that one
> > and apply your changes for ti_j721e_sk on top of it. It think that is
> > a standard way to make people happy about
> > their work and contribution.
> 
> Actually, the two series are about the same topic: TI K3 SoC support (GP, HS,
> HS-FS) not only AM62x-SK HS-FS devices
> 
> But due to the complexity of the BSP, the boot flow (4 way to boot!) and the
> switch from custom tool to binman... this series is really difficult to review
> without having a good understanding of TI K3 architecture peculiarity and having
> one of each TI evaluation boards 🙂

Although I helped conceive some of this and the associated tooling early
on, some of the what may look strange architectural decisions were driven
by different use cases and requirements for the different devices
(especially around automotive fast/early boot, but also security) in
combination with limited on-chip SRAM... So this where we are at now. A
future AM6x device variant will have yet another boot flow, but I can
already say it will be very much simplified over what we have today :)

> The series (based on Dario's work) about ti_j721e_sk suggested to remove TI
> custom tools replaced by binman along with other improvements.
> 
> I'll way for v5 and rebase the ti_j721e_sk on top of it.

Thank you Romain for your buy-in. Let's focus on getting Dario's series
in good shape and then move onto yours. I'd also like to re-introduce
graphics (I had that working before) but I need to wait for all the
"baseline" stuff to settle first.


--
Andreas Dannenberg
Texas Instruments Inc



> 
> Best regards,
> Romain
> 
> 
> > 
> > Michael
> > 
> >> My main concern is to avoid adding a new package for a tool that is already
> >> deprecated ti-k3-image-gen (not sure if ti-k3-core-secdev is really deprecated) [1].
> >>
> >> Also the topic is not only "AM62x-SK HS-FS devices" but "TI K3 HS-FS devices".
> >>
> >> [1] http://lists.busybox.net/pipermail/buildroot/2024-February/685820.html
> >>
> >> Best regards,
> >> Romain
> >>
> >>>
> >>> Dario Binacchi (20):
> >>>   configs/ti_am62x_sk_defconfig: fix BR2_TARGET_OPTEE_OS_PLATFORM
> >>>     setting
> >>>   configs/ti_am64x_sk_defconfig: fix BR2_TARGET_OPTEE_OS_PLATFORM
> >>>     setting
> >>>   configs/ti_am62x_sk_defconfig: explicitly set the ti-k3-r5-loader
> >>>     version
> >>>   configs/ti_am64x_sk_defconfig: explicitly set the ti-k3-r5-loader
> >>>     version
> >>>   boot/ti-k3-r5-loader: bump to version 2024.01
> >>>   boot/ti-k3-core-secdev: new package
> >>>   boot/ti-k3-image-gen: manage HS hardware
> >>>   package/python-jsonschema: add host variant
> >>>   package/python-attrs: add host variant
> >>>   package/python-referencing: add host variant
> >>>   package/python-rpds-py: add host variant
> >>>   package/python-jsonschema-specifications: add host variant
> >>>   boot/ti-k3-r5-loader: set binman environment
> >>>   boot/uboot: set BINMAN_INDIRS for TI K3 DM
> >>>   configs/ti_am62x_sk_defconfig: bump U-Boot version to 2024.01
> >>>   configs/ti_am62x_sk_defconfig: bump Linux version to 6.6.1
> >>>   boot: move ti-k3-* packages to 'ti-k3' directory
> >>>   boot/ti-k3: move TI_K3_{SECTYPE,SOC} out of the image-gen scope
> >>>   boot/ti-k3/ti-k3-r5-loader: install tiboot3.bin
> >>>   configs/ti_am62x_sk_defconfig: don't use ti-k3-image-gen anymore
> >>>
> >>>  DEVELOPERS                                    |  1 +
> >>>  board/ti/am62x-sk/genimage.cfg                |  7 +-
> >>>  board/ti/am62x-sk/post-build.sh               | 49 ++++++++++++
> >>>  board/ti/am62x-sk/post-image.sh               |  5 ++
> >>>  boot/Config.in                                |  4 +-
> >>>  boot/ti-k3-image-gen/Config.in                | 77 -------------------
> >>>  boot/ti-k3/Config.in                          | 59 ++++++++++++++
> >>>  boot/ti-k3/common.mk                          |  1 +
> >>>  .../{ => ti-k3}/ti-k3-boot-firmware/Config.in |  0
> >>>  .../ti-k3-boot-firmware.hash                  |  0
> >>>  .../ti-k3-boot-firmware.mk                    |  0
> >>>  boot/ti-k3/ti-k3-core-secdev/Config.in        |  9 +++
> >>>  .../ti-k3-core-secdev/ti-k3-core-secdev.hash  |  3 +
> >>>  .../ti-k3-core-secdev/ti-k3-core-secdev.mk    | 22 ++++++
> >>>  boot/ti-k3/ti-k3-image-gen/Config.in          | 25 ++++++
> >>>  .../ti-k3-image-gen/ti-k3-image-gen.hash      |  0
> >>>  .../ti-k3-image-gen/ti-k3-image-gen.mk        | 20 ++++-
> >>>  boot/{ => ti-k3}/ti-k3-r5-loader/Config.in    |  4 +-
> >>>  .../ti-k3-r5-loader/ti-k3-r5-loader.hash      |  2 +-
> >>>  .../ti-k3-r5-loader/ti-k3-r5-loader.mk        | 16 +++-
> >>>  boot/uboot/Config.in                          |  7 +-
> >>>  boot/uboot/uboot.mk                           |  3 +-
> >>>  configs/ti_am62x_sk_defconfig                 | 23 +++---
> >>>  configs/ti_am64x_sk_defconfig                 |  8 +-
> >>>  package/python-attrs/python-attrs.mk          |  6 ++
> >>>  .../python-jsonschema-specifications.mk       |  5 ++
> >>>  .../python-jsonschema/python-jsonschema.mk    |  6 ++
> >>>  .../python-referencing/python-referencing.mk  |  5 ++
> >>>  package/python-rpds-py/python-rpds-py.mk      |  1 +
> >>>  29 files changed, 263 insertions(+), 105 deletions(-)
> >>>  create mode 100755 board/ti/am62x-sk/post-build.sh
> >>>  create mode 100755 board/ti/am62x-sk/post-image.sh
> >>>  delete mode 100644 boot/ti-k3-image-gen/Config.in
> >>>  create mode 100644 boot/ti-k3/Config.in
> >>>  create mode 100644 boot/ti-k3/common.mk
> >>>  rename boot/{ => ti-k3}/ti-k3-boot-firmware/Config.in (100%)
> >>>  rename boot/{ => ti-k3}/ti-k3-boot-firmware/ti-k3-boot-firmware.hash (100%)
> >>>  rename boot/{ => ti-k3}/ti-k3-boot-firmware/ti-k3-boot-firmware.mk (100%)
> >>>  create mode 100644 boot/ti-k3/ti-k3-core-secdev/Config.in
> >>>  create mode 100644 boot/ti-k3/ti-k3-core-secdev/ti-k3-core-secdev.hash
> >>>  create mode 100644 boot/ti-k3/ti-k3-core-secdev/ti-k3-core-secdev.mk
> >>>  create mode 100644 boot/ti-k3/ti-k3-image-gen/Config.in
> >>>  rename boot/{ => ti-k3}/ti-k3-image-gen/ti-k3-image-gen.hash (100%)
> >>>  rename boot/{ => ti-k3}/ti-k3-image-gen/ti-k3-image-gen.mk (67%)
> >>>  rename boot/{ => ti-k3}/ti-k3-r5-loader/Config.in (97%)
> >>>  rename boot/{ => ti-k3}/ti-k3-r5-loader/ti-k3-r5-loader.hash (54%)
> >>>  rename boot/{ => ti-k3}/ti-k3-r5-loader/ti-k3-r5-loader.mk (85%)
> >>>
> >>
> 
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot