Re: [Buildroot] [PATCH 1/1] kconfig/lxdialog: fix check() with GCC14

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Robert Marko <robimarko@gmail.com>
Cc: Petr Vorel <petr.vorel@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] kconfig/lxdialog: fix check() with GCC14
Date: Mon, 8 Apr 2024 22:36:21 +0200	[thread overview]
Message-ID: <20240408223621.39b37892@windsurf> (raw)
In-Reply-To: <20240403121807.2087547-1-robimarko@gmail.com>

Hello Robert,

On Wed,  3 Apr 2024 14:18:07 +0200
Robert Marko <robimarko@gmail.com> wrote:

> GCC14 now treats implicit int types as error so when check() from
> check-lxdialog.sh is called to check whether we can link against ncurses
> it will fail silently and the help text indicating to install ncurses is
> printed.
> 
> However, this is not due to missing ncurses but once the stderr redirect
> to /dev/null is removed we can see the root cause:
> <stdin>:2:1: error: return type defaults to ‘int’ [-Wimplicit-int]
> 
> So, in order for menuconfig to work with GCC14 lets just specify the
> return type of main() as int.
> 
> Signed-off-by: Robert Marko <robimarko@gmail.com>

Thanks a lot for the patch. However, making changes in support/kconfig/
in Buildroot requires a bit more care. Indeed, this code is taken from
the Linux kernel code, and we try to keep a well-defined list of
changes on top of the original code from the kernel.

As explained in support/kconfig/README.buildroot, the current code in
support/kconfig/ is taken from Linux 4.17-rc2, on top of which the
patches in support/kconfig/patches/ have been applied.

So from this, you have two options:

(1) Add a new patch in support/kconfig/patches/ which implements the
    change you need for GCC14 compatibility

(2) Update the code in support/kconfig/ to the latest code available in
    the Linux kernel scripts/kconfig directory, rebase our patches, and
    verify it all works.

Obviously, (1) is the easiest path. (2) is nicer long term, as we
benefit from all new features/fixes added by the Linux kernel
developers. Turns out that in the upstream kernel, the
check-lxdialog.sh script has been removed and replaced by something
different, which no longer has this main() function definition.

Could you have a look at implementing either (1) or (2) ?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot