Re: [Buildroot] [PATCH 1/1] kconfig/lxdialog: fix check() with GCC14

From: Petr Vorel <petr.vorel@gmail.com>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Robert Marko <robimarko@gmail.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] kconfig/lxdialog: fix check() with GCC14
Date: Thu, 11 Apr 2024 02:15:04 +0200	[thread overview]
Message-ID: <20240411001504.GA283218@pevik> (raw)
In-Reply-To: <ZhWp-ftUZj1_npHh@landeda>

Hi Yann, Thomas, all,

> Thomas, Petr, All,

> On 2024-04-09 21:46 +0200, Thomas Petazzoni via buildroot spake thusly:
> > On Mon, 8 Apr 2024 23:38:07 +0200
> > Petr Vorel <petr.vorel@gmail.com> wrote:

> > > FYI I gave up kconfig update after big rewrites in the Linux kernel
> > > made by Masahiro Yamada (the new kbuild and kconfig maintainer), because the
> > > code changes were quite big but kconfig in Buildroot is IMHO not missing any
> > > significant usability function. But I can be wrong, Thomas let me know if you
> > > miss something significant which would justify the update. Obviously we would
> > > get some fixes, but also major rewrite, which would likely require changes in
> > > other parts of Buildroot.

> > I have no idea what are the new interesting features that have been
> > added in the upstream scripts/kconfig/ (if any). However, keeping our
> > support/kconfig/ reasonably up-to-date is not only about new features,
> > it's also about staying compatible with reasonably recent
> > libraries/tools (more recent ncurses, Gtk, Qt, more recent GCC, like
> > this issue illustrates).

> The kernel's kconfig has dropped the possibility to include files from
> within a choice, so what we're doing now in a few places will not work;
>   - toolchain/toolchain-external/Config.in
>   - package/openssl/Config.in

Ah, you mean choice within choice .. endchoice.  Thanks for info. That's
unfortunate. Any idea which commits reverted it? I'm not sure if it will be
possible to easily revert it back (there are many changes in kconfig).
Also replacing 'source' with some placeholder and using some preprocessing
in extra make target (dependency for gconfig/xconfig/menuconfig/nconfig/config)
might not be as trivial as it looks like.

> and so on...

Do you remember any other problem?

> Unless that was reverted upstream...

I doubt, but that needs to be find out.

Also, maybe slightly easier way could be to use init-kconfig [1],
used in kdevops [2] (imported via 'git subtree' into the usual scripts/kconfig/
directory). At least we could try to migrate at least some of our patches there.

Kind regards,
Petr

> Regards,
> Yann E. MORIN.

[1] https://github.com/mcgrof/init-kconfig
[2] https://github.com/mcgrof/kdevops
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot