Re: [Buildroot] [PATCH 1/1] kconfig/lxdialog: fix check() with GCC14

From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Petr Vorel <petr.vorel@gmail.com>
Cc: Robert Marko <robimarko@gmail.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] kconfig/lxdialog: fix check() with GCC14
Date: Thu, 11 Apr 2024 07:02:39 +0200	[thread overview]
Message-ID: <Zhdu7zT3FZl7sk1q@landeda> (raw)
In-Reply-To: <20240411001504.GA283218@pevik>

Petr, All,

> > The kernel's kconfig has dropped the possibility to include files from
> > within a choice, so what we're doing now in a few places will not work;
> >   - toolchain/toolchain-external/Config.in
> >   - package/openssl/Config.in
> Ah, you mean choice within choice .. endchoice.  Thanks for info. That's
               ^^^^^^
s/choice/source/

Yes, "source" in a choice...endchoice block.

> unfortunate. Any idea which commits reverted it?

That was commit in the kernel, 4 years ago:

    09d5873e4d1f7 kconfig: allow only 'config', 'comment', and 'if' inside 'choice'

> I'm not sure if it will be
> possible to easily revert it back (there are many changes in kconfig).

Indeed.

> Also replacing 'source' with some placeholder and using some preprocessing
> in extra make target (dependency for gconfig/xconfig/menuconfig/nconfig/config)
> might not be as trivial as it looks like.

No, it is not...

> Do you remember any other problem?

Not right now. There were a few other major changes, but AFAICS we would
not be impacted.

> Also, maybe slightly easier way could be to use init-kconfig [1],

init-kconfig has not been touched in 2 years. There is no point in
switching from our mothballed copy, to another mothballed copy...

And in any case, they advertise as being "a passive fork of Linux
kconfig", and their "goal is not to fork kconfig and evolve it
separately".

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot