[Buildroot] [PATCH v1 1/8] package/libsoup3: fix reference to atomic

[Buildroot] [PATCH v1 1/8] package/libsoup3: fix reference to atomic

[Thomas Devoogdt]

gthread-posix.c:(.text+0x137c): undefined reference to `__atomic_compare_exchange_4'
collect2: error: ld returned 1 exit status

Fixes:
 - http://autobuild.buildroot.net/results/4fb9f4c49777dde3abc30bb9f324816d3ed87567

Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com>
---
 package/libsoup3/libsoup3.mk | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/package/libsoup3/libsoup3.mk b/package/libsoup3/libsoup3.mk
index 10caa5bea4..99eee466b3 100644
--- a/package/libsoup3/libsoup3.mk
+++ b/package/libsoup3/libsoup3.mk
@@ -30,6 +30,11 @@ LIBSOUP3_CONF_OPTS = \
 	-Dtests=false \
 	-Dtls_check=false
 
+# Uses __atomic_compare_exchange_4
+ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
+LIBSOUP3_LDFLAGS += -latomic
+endif
+
 ifeq ($(BR2_PACKAGE_BROTLI),y)
 LIBSOUP3_CONF_OPTS += -Dbrotli=enabled
 LIBSOUP3_DEPENDENCIES += brotli
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v1 2/8] package/gssdp: fix reference to atomic

[Thomas Devoogdt]

gthread-posix.c:(.text+0x137c): undefined reference to `__atomic_compare_exchange_4'
collect2: error: ld returned 1 exit status

Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com>
---
 package/gssdp/gssdp.mk | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/package/gssdp/gssdp.mk b/package/gssdp/gssdp.mk
index 3b446496ea..0ba8672ac7 100644
--- a/package/gssdp/gssdp.mk
+++ b/package/gssdp/gssdp.mk
@@ -18,6 +18,13 @@ GSSDP_CONF_OPTS = \
 	-Dmanpages=false \
 	-Dsniffer=false
 
+GSSDP_LDFLAGS = $(TARGET_LDFLAGS)
+
+# Uses __atomic_compare_exchange_4
+ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
+GSSDP_LDFLAGS += -latomic
+endif
+
 ifeq ($(BR2_PACKAGE_GOBJECT_INTROSPECTION),y)
 GSSDP_CONF_OPTS += -Dintrospection=true -Dvapi=true
 GSSDP_DEPENDENCIES += host-vala gobject-introspection
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v1 3/8] package/gupnp: fix reference to atomic

[Thomas Devoogdt]

gthread-posix.c:(.text+0x137c): undefined reference to `__atomic_compare_exchange_4'
collect2: error: ld returned 1 exit status

Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com>
---
 package/gupnp/gupnp.mk | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/package/gupnp/gupnp.mk b/package/gupnp/gupnp.mk
index cfcc114189..8f91439ff5 100644
--- a/package/gupnp/gupnp.mk
+++ b/package/gupnp/gupnp.mk
@@ -15,6 +15,13 @@ GUPNP_INSTALL_STAGING = YES
 GUPNP_DEPENDENCIES = host-pkgconf libglib2 libxml2 gssdp util-linux
 GUPNP_CONF_OPTS = -Dexamples=false
 
+GUPNP_LDFLAGS = $(TARGET_LDFLAGS)
+
+# Uses __atomic_compare_exchange_4
+ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
+GUPNP_LDFLAGS += -latomic
+endif
+
 ifeq ($(BR2_PACKAGE_GOBJECT_INTROSPECTION),y)
 GUPNP_CONF_OPTS += -Dintrospection=true -Dvapi=true
 GUPNP_DEPENDENCIES += host-vala gobject-introspection
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v1 4/8] package/gupnp-av: fix reference to atomic

[Thomas Devoogdt]

gthread-posix.c:(.text+0x137c): undefined reference to `__atomic_compare_exchange_4'
collect2: error: ld returned 1 exit status

Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com>
---
 package/gupnp-av/gupnp-av.mk | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/package/gupnp-av/gupnp-av.mk b/package/gupnp-av/gupnp-av.mk
index 3821c4e170..a27f451a64 100644
--- a/package/gupnp-av/gupnp-av.mk
+++ b/package/gupnp-av/gupnp-av.mk
@@ -13,6 +13,13 @@ GUPNP_AV_LICENSE_FILES = COPYING
 GUPNP_AV_INSTALL_STAGING = YES
 GUPNP_AV_DEPENDENCIES = host-pkgconf libglib2 libxml2 gupnp
 
+GUPNP_AV_LDFLAGS = $(TARGET_LDFLAGS)
+
+# Uses __atomic_compare_exchange_4
+ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
+GUPNP_AV_LDFLAGS += -latomic
+endif
+
 ifeq ($(BR2_PACKAGE_GOBJECT_INTROSPECTION),y)
 GUPNP_AV_CONF_OPTS += -Dintrospection=true -Dvapi=true
 GUPNP_AV_DEPENDENCIES += host-vala gobject-introspection
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v1 5/8] package/gupnp-dlna: fix reference to atomic

[Thomas Devoogdt]

gthread-posix.c:(.text+0x137c): undefined reference to `__atomic_compare_exchange_4'
collect2: error: ld returned 1 exit status

Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com>
---
 package/gupnp-dlna/gupnp-dlna.mk | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/package/gupnp-dlna/gupnp-dlna.mk b/package/gupnp-dlna/gupnp-dlna.mk
index 0064700fd2..8de25e6347 100644
--- a/package/gupnp-dlna/gupnp-dlna.mk
+++ b/package/gupnp-dlna/gupnp-dlna.mk
@@ -15,6 +15,13 @@ GUPNP_DLNA_LICENSE_FILES = COPYING
 GUPNP_DLNA_INSTALL_STAGING = YES
 GUPNP_DLNA_DEPENDENCIES = host-pkgconf libglib2 libxml2
 
+GUPNP_DLNA_LDFLAGS = $(TARGET_LDFLAGS)
+
+# Uses __atomic_compare_exchange_4
+ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
+GUPNP_DLNA_LDFLAGS += -latomic
+endif
+
 ifeq ($(BR2_PACKAGE_GOBJECT_INTROSPECTION),y)
 GUPNP_DLNA_CONF_OPTS += -Dintrospection=true -Dvapi=true
 GUPNP_DLNA_DEPENDENCIES += host-vala gobject-introspection
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v1 6/8] package/at-spi2-core: fix reference to atomic

[Thomas Devoogdt]

gthread-posix.c:(.text+0x137c): undefined reference to `__atomic_compare_exchange_4'
collect2: error: ld returned 1 exit status

Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com>
---
 package/at-spi2-core/at-spi2-core.mk | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/package/at-spi2-core/at-spi2-core.mk b/package/at-spi2-core/at-spi2-core.mk
index 828280de1a..43befa99f0 100644
--- a/package/at-spi2-core/at-spi2-core.mk
+++ b/package/at-spi2-core/at-spi2-core.mk
@@ -38,4 +38,9 @@ endif
 
 AT_SPI2_CORE_LDFLAGS = $(TARGET_LDFLAGS) $(TARGET_NLS_LIBS)
 
+# Uses __atomic_compare_exchange_4
+ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
+AT_SPI2_CORE_LDFLAGS += -latomic
+endif
+
 $(eval $(meson-package))
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v1 7/8] package/gdk-pixbuf: fix reference to atomic

[Thomas Devoogdt]

gthread-posix.c:(.text+0x137c): undefined reference to `__atomic_compare_exchange_4'
collect2: error: ld returned 1 exit status

Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com>
---
 package/gdk-pixbuf/gdk-pixbuf.mk | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/package/gdk-pixbuf/gdk-pixbuf.mk b/package/gdk-pixbuf/gdk-pixbuf.mk
index e041d2cbde..9d272be382 100644
--- a/package/gdk-pixbuf/gdk-pixbuf.mk
+++ b/package/gdk-pixbuf/gdk-pixbuf.mk
@@ -31,6 +31,13 @@ HOST_GDK_PIXBUF_CONF_OPTS = \
 	-Drelocatable=true \
 	-Dman=false
 
+GDK_PIXBUF_LDFLAGS = $(TARGET_LDFLAGS)
+
+# Uses __atomic_compare_exchange_4
+ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
+GDK_PIXBUF_LDFLAGS += -latomic
+endif
+
 ifeq ($(BR2_STATIC_LIBS),y)
 GDK_PIXBUF_CONF_OPTS += -Dbuiltin_loaders=all
 endif
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v1 8/8] package/libqmi: fix reference to atomic

[Thomas Devoogdt]

gthread-posix.c:(.text+0x137c): undefined reference to `__atomic_compare_exchange_4'
collect2: error: ld returned 1 exit status

Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com>
---
 package/libqmi/libqmi.mk | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/package/libqmi/libqmi.mk b/package/libqmi/libqmi.mk
index 524333feba..8aa2b4a5f2 100644
--- a/package/libqmi/libqmi.mk
+++ b/package/libqmi/libqmi.mk
@@ -14,6 +14,13 @@ LIBQMI_INSTALL_STAGING = YES
 LIBQMI_DEPENDENCIES = libglib2
 LIBQMI_CONF_OPTS = -Dman=false -Dfuzzer=false
 
+LIBQMI_LDFLAGS = $(TARGET_LDFLAGS)
+
+# Uses __atomic_compare_exchange_4
+ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
+LIBQMI_LDFLAGS += -latomic
+endif
+
 ifeq ($(BR2_PACKAGE_GOBJECT_INTROSPECTION),y)
 LIBQMI_DEPENDENCIES += gobject-introspection
 LIBQMI_CONF_OPTS += -Dintrospection=true
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v1 1/8] package/libsoup3: fix reference to atomic

[Thomas Petazzoni via buildroot]

Hello,

On Sat, 20 Apr 2024 20:58:46 +0200
Thomas Devoogdt <thomas@devoogdt.com> wrote:

> gthread-posix.c:(.text+0x137c): undefined reference to `__atomic_compare_exchange_4'
> collect2: error: ld returned 1 exit status
> 
> Fixes:
>  - http://autobuild.buildroot.net/results/4fb9f4c49777dde3abc30bb9f324816d3ed87567
> 
> Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com>

I think this whole patch series is not the right way to fix the
problem. Indeed, what's using libatomic here is libglib2, and with your
solution, you have to chase down *all* reverse dependencies of libglib2.

Instead, what I'd like to see is that the glib-2.0.pc (pkg-config) file
gets updated to include -latomic in the Libs.private flags, so that it
gets automatically picked up by all reverse dependencies of libglib2
when they are static linking.

This also brings the advantage that you're not linking say libsoup3
directly with libatomic, like you're doing with your patch. Instead, in
a dynamic linking case, we keep on having libsoup3 linked just with
libglib2, and libglib2 linked with libatomic. It's only in the static
linking case that when we're building a final executable that uses
libsoup3, we need to also bring libatomic.a into the mix.

Could you have a look at fixing glib-2.0.pc instead?

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v1 1/8] package/libsoup3: fix reference to atomic

[Fabrice Fontaine]

Hello Thomas,

Le jeu. 2 mai 2024 à 09:56, Thomas Petazzoni
<thomas.petazzoni@bootlin.com> a écrit :
>
> Hello,
>
> On Sat, 20 Apr 2024 20:58:46 +0200
> Thomas Devoogdt <thomas@devoogdt.com> wrote:
>
> > gthread-posix.c:(.text+0x137c): undefined reference to `__atomic_compare_exchange_4'
> > collect2: error: ld returned 1 exit status
> >
> > Fixes:
> >  - http://autobuild.buildroot.net/results/4fb9f4c49777dde3abc30bb9f324816d3ed87567
> >
> > Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com>
>
> I think this whole patch series is not the right way to fix the
> problem. Indeed, what's using libatomic here is libglib2, and with your
> solution, you have to chase down *all* reverse dependencies of libglib2.
>
> Instead, what I'd like to see is that the glib-2.0.pc (pkg-config) file
> gets updated to include -latomic in the Libs.private flags, so that it
> gets automatically picked up by all reverse dependencies of libglib2
> when they are static linking.
>
> This also brings the advantage that you're not linking say libsoup3
> directly with libatomic, like you're doing with your patch. Instead, in
> a dynamic linking case, we keep on having libsoup3 linked just with
> libglib2, and libglib2 linked with libatomic. It's only in the static
> linking case that when we're building a final executable that uses
> libsoup3, we need to also bring libatomic.a into the mix.
>
> Could you have a look at fixing glib-2.0.pc instead?

This patch is available since September 2023:
https://patchwork.ozlabs.org/project/buildroot/patch/20230917185116.182810-1-fontaine.fabrice@gmail.com/

>
> Thanks!
>
> Thomas
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com

Best Regards,

Fabrice
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v1 1/8] package/libsoup3: fix reference to atomic

[Thomas Petazzoni via buildroot]

On Thu, 2 May 2024 10:15:53 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> > Could you have a look at fixing glib-2.0.pc instead?  
> 
> This patch is available since September 2023:
> https://patchwork.ozlabs.org/project/buildroot/patch/20230917185116.182810-1-fontaine.fabrice@gmail.com/

Awesome, I went ahead and applied this patch!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v1 1/8] package/libsoup3: fix reference to atomic

[Thomas Devoogdt]

Ah,


Thanks, Thomas for pointing that out, and Fabrice for the patch.


Kr,

Thomas

Op do 2 mei 2024 om 10:30 schreef Thomas Petazzoni
<thomas.petazzoni@bootlin.com>:
>
> On Thu, 2 May 2024 10:15:53 +0200
> Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
>
> > > Could you have a look at fixing glib-2.0.pc instead?
> >
> > This patch is available since September 2023:
> > https://patchwork.ozlabs.org/project/buildroot/patch/20230917185116.182810-1-fontaine.fabrice@gmail.com/
>
> Awesome, I went ahead and applied this patch!
>
> Thomas
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com
>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot