Re: [Buildroot] [PATCH v1 7/8] support/kconfig: reference environment variables directly (remove 'option env=')

[Peter Seiderer via buildroot <buildroot@buildroot.org>]

Hello Thomas,

On Mon, 6 May 2024 21:06:23 +0200, Thomas Petazzoni via buildroot <buildroot@buildroot.org> wrote:

> On Mon,  6 May 2024 16:45:50 +0200
> Peter Seiderer via buildroot <buildroot@buildroot.org> wrote:
>
>
> >  config BR2_DEFCONFIG
> >  	string "Location to save buildroot config"
> > -	default BR2_DEFCONFIG_FROM_ENV if BR2_DEFCONFIG_FROM_ENV != ""
> > +	default "$(BR2_DEFCONFIG)" if "$(BR2_DEFCONFIG)" != ""
> >  	default "$(CONFIG_DIR)/defconfig"
> >  	help
> >  	  When running 'make savedefconfig', the defconfig file will be
> > @@ -197,7 +176,7 @@ config BR2_DEFCONFIG
> >
> >  config BR2_DL_DIR
> >  	string "Download dir"
> > -	default "$(TOPDIR)/dl"
> > +	default "\$(TOPDIR)/dl"
>
> So here the "\$(TOPDIR)" is because we actually don't want the "new"
> feature to kick in, and we want the value of this variable to be
> expanded not by kconfig, but by the makefile machinery?

Yes (sorry, the explaining sentence in the commit log got lost while
rebasing/squashing)..., without the escape the expanded value is
written out to the .config file...

>
> So this also means that when we do $(BR2_EXTERNAL_BLABLA_PATH) in our
> .config, it now also need to be \$(BR2_EXTERNAL_BLABLA_PATH) ? If so
> that's going to break a *lot* of things...

Needs to be tested ;-), but the problem is not in the .config files
but in the Config.in* files...

Regards,
Peter

>
> Thomas

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot