Re: [Buildroot] [PATCH v1 7/8] support/kconfig: reference environment variables directly (remove 'option env=')

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Peter, All,

On 2024-05-08 16:53 +0200, Peter Seiderer via buildroot spake thusly:
> On Mon, 6 May 2024 21:06:23 +0200, Thomas Petazzoni via buildroot <buildroot@buildroot.org> wrote:
> > On Mon,  6 May 2024 16:45:50 +0200
> > Peter Seiderer via buildroot <buildroot@buildroot.org> wrote:
> > > -	default "$(TOPDIR)/dl"
> > > +	default "\$(TOPDIR)/dl"
> > So here the "\$(TOPDIR)" is because we actually don't want the "new"
> > feature to kick in, and we want the value of this variable to be
> > expanded not by kconfig, but by the makefile machinery?
> Yes (sorry, the explaining sentence in the commit log got lost while
> rebasing/squashing)..., without the escape the expanded value is
> written out to the .config file...
> > So this also means that when we do $(BR2_EXTERNAL_BLABLA_PATH) in our
> > .config, it now also need to be \$(BR2_EXTERNAL_BLABLA_PATH) ? If so
> > that's going to break a *lot* of things...

This would also impact BR2_TARGET_GENERIC_ROOT_PASSWD, see the help
text: it can contain a literal string that starts with a $ sign.

> Needs to be tested ;-), but the problem is not in the .config files
> but in the Config.in* files...

So, that only impacts the 'default' entries, right? If a user actually
enters '$FOO' in a configurator, the appropriate, unexpanded value ends
up in the .config?

What would happen with:

    $ cat Config.in
    config BR2_FOO
        string "$(FOO)"

    $ FOO=27 BAR=42 make defconfig
    $ cat .config
    BR2_FOO=????

    $ FOO=27 BAR=42 make menuconfig
        BR2_FOO -> enter literal:  "$(BAR)"
    $ cat .config
    BR2_FOO=????

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot