Re: [Buildroot] [PATCH v1 0/8] support/kconfig: bump to linux-v6.9-rc5 version

[Peter Seiderer via buildroot <buildroot@buildroot.org>]

Hello Thomas,

On Mon, 6 May 2024 21:04:40 +0200, Thomas Petazzoni via buildroot <buildroot@buildroot.org> wrote:

> Hello,
>
> On Mon,  6 May 2024 16:45:43 +0200
> Peter Seiderer via buildroot <buildroot@buildroot.org> wrote:
>
> > The patches are orderd by the first 5 handling some minor nits (result of
> > the new kconfig beeing a little more strict about the syntax, can be
> > applied in advance):
> >
> >   - boot/barebox/Config.in: source argument needs quotation marks
> >   - package/cmocka/Config.in: bool argument needs quotation marks
> >   - package/dovecot/Config.in: source argument needs quotation marks
> >   - package/python-pydal/Config.in: bool argument needs quotation marks
> >   - package/x11r7/Config.in: source argument needs quotation marks
>
> I have applied those preparation patches that make sense regardless of
> what happens with the bump.

Thanks...

>
> > The kconfig version dump itself:
> >
> >   - support/kconfig: bump to linux-v6.9-rc5 version
>
> So this commit without the next two leads to a broken situation,
> correct? (Note: this is not a complaint, I agree with them being split).

Yes, but the next two patches can eventually squashed with this one, but did
keep separate for better patch review/iteration (suspected some more
discussion on this ones)...

>
> > And two 'real' changes due to kconfig language changes:
> >
> >   - support/kconfig: reference environment variables directly (remove 'option env=')
> >   - package/openssl: move libopenssl/libressl source statemetns outside of the choice
>
> But don't we have this situation of source statements inside a
> choice..endchoice in other places? I remember Yann saying that this was
> a problematic change for us in the upstream kconfig code.

Yes, that is the reasoning for the (suggested by Yann)

	patches/23-Revert-kconfig-allow-only-config-comment-and-if-insi.patch

With this one reverted I get the following warnings/errors:

  toolchain/toolchain-external/Config.in:12: syntax error
  toolchain/toolchain-external/Config.in:12: invalid statement
  toolchain/toolchain-external/Config.in:13: invalid statement
  toolchain/toolchain-external/Config.in:16: invalid statement
  toolchain/toolchain-external/Config.in:17: invalid statement
  toolchain/toolchain-external/Config.in:20: invalid statement
  toolchain/toolchain-external/Config.in:23: invalid statement
  toolchain/toolchain-external/Config.in:24: invalid statement
  toolchain/toolchain-external/Config.in:27: invalid statement
  toolchain/toolchain-external/Config.in:30: invalid statement
  toolchain/toolchain-external/Config.in:33: invalid statement
  toolchain/toolchain-external/Config.in:38: invalid statement
  toolchain/toolchain-external/Config.in:41: invalid statement
  system/Config.in:23: syntax error
  system/Config.in:23: invalid statement
  system/Config.in:157: syntax error
  system/Config.in:157: invalid statement
  package/openssl/Config.in:46: syntax error
  package/openssl/Config.in:46: invalid statement
  package/jpeg/Config.in:43: syntax error
  package/jpeg/Config.in:43: invalid statement

With the patch the remaining problematic source-inside-choice are
in package/openssl/Config.in, seems not all content is allowed
to be included...

Regards,
Peter

>
> Best regards,
>
> Thomas

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot