Re: [Buildroot] [PATCH v2 03/11] package/qt6/qt6shadertools: new package

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello,

Added some Buildroot maintainers in Cc, for a question below.

On Wed, 17 Apr 2024 10:05:24 +0200
Roy Kollen Svendsen <roykollensvendsen@gmail.com> wrote:

> Signed-off-by: Roy Kollen Svendsen <roy.kollen.svendsen@akersolutions.com>
> ---
> Changes v1 -> v2:
>   - don't add unnecessary Config.in.host
>   - add required BR2_PACKAGE_HOST_QT6BASE_GUI config element to qt6base/Config.in

It would be good to expand the commit log with some explanations on why
host-qt6base needs to be built with GUI support for this package to
build for the target. Indeed, this is a non-trivial packaging thing, so
it makes sense to clarify it explicitly.


> diff --git a/package/qt6/qt6base/Config.in b/package/qt6/qt6base/Config.in
> index 3b15d40c83..5b598aa938 100644
> --- a/package/qt6/qt6base/Config.in
> +++ b/package/qt6/qt6base/Config.in
> @@ -1,3 +1,6 @@
> +config BR2_PACKAGE_HOST_QT6BASE_GUI
> +	bool

My question to other maintainers: do we want this blind option that
allows to enable GUI support in the *host* qt6base to be present in the
Config.in file (normally reserved for options for the target package),
or do we want a simple Config.in.host, which even if it doesn't have a
visible option for host-qt6base would carry this blind option allowing
to enable GUI support in host-qt6base ?

Thanks for your feedback,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot