Re: [Buildroot] [PATCH v2 03/11] package/qt6/qt6shadertools: new package

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Roy Kollen Svendsen <roy.kollen.svendsen@akersolutions.com>,
	Samuel Martin <s.martin49@gmail.com>,
	Roy Kollen Svendsen <roykollensvendsen@gmail.com>,
	buildroot@buildroot.org, Zoltan Gyarmati <zgyarmati@zgyarmati.de>,
	Romain Naour <romain.naour@smile.fr>,
	Jesse Van Gavere <jesseevg@gmail.com>
Subject: Re: [Buildroot] [PATCH v2 03/11] package/qt6/qt6shadertools: new package
Date: Thu, 9 May 2024 22:43:37 +0200	[thread overview]
Message-ID: <20240509224337.253b2bde@windsurf> (raw)
In-Reply-To: <Zj00B8A-pgDg5rvn@landeda>

Hello,

On Thu, 9 May 2024 22:37:27 +0200
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote:

> We have a few other host packages that have a no-prompt boolean option,
> like dracut, eudev, patchelf, systemd.
> 
> The converse is non-existent; we only have ARCH_SUPPORTS for a few host
> packages for languages:
> 
>     $ git grep -E 'config BR2_PACKAGE_HOST_' -- '*/Config.in'
>     package/erlang/Config.in:config BR2_PACKAGE_HOST_ERLANG_ARCH_SUPPORTS
>     package/mono/Config.in:config BR2_PACKAGE_HOST_MONO_ARCH_SUPPORTS
>     package/openjdk/Config.in:config BR2_PACKAGE_HOST_OPENJDK_BIN_ARCH_SUPPORTS
>     package/protobuf/Config.in:config BR2_PACKAGE_HOST_PROTOBUF_ARCH_SUPPORTS
> 
> So, yes, I'd rather have BR2_PACKAGE_HOST_QT6BASE_GUI in its own
> Config.in.host.

ACK.

> Also, it is a bit weird that this is an option for a host package
> without a kconfig symbol for the host package itself...

I don't find it weird. We need host-qt6base with some specific
features (which we don't want to build in all cases, as it takes time),
but really host-qt6base doesn't have to be user-visible in menuconfig,
as it's merely a build dependency.

> Also, adding the support for GUI in host qt6base should be in its own
> patch, separate from the one introducing qt6shadertools.

Agreed.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot