Re: [Buildroot] [PATCH v2 03/11] package/qt6/qt6shadertools: new package

From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Roy Kollen Svendsen <roy.kollen.svendsen@akersolutions.com>,
	Samuel Martin <s.martin49@gmail.com>,
	Roy Kollen Svendsen <roykollensvendsen@gmail.com>,
	buildroot@buildroot.org, Zoltan Gyarmati <zgyarmati@zgyarmati.de>,
	Romain Naour <romain.naour@smile.fr>,
	Jesse Van Gavere <jesseevg@gmail.com>
Subject: Re: [Buildroot] [PATCH v2 03/11] package/qt6/qt6shadertools: new package
Date: Thu, 9 May 2024 22:37:27 +0200	[thread overview]
Message-ID: <Zj00B8A-pgDg5rvn@landeda> (raw)
In-Reply-To: <20240509164507.4682bee8@windsurf>

Thomas, Roy, All,

On 2024-05-09 16:45 +0200, Thomas Petazzoni via buildroot spake thusly:
[--SNIP--]
> > diff --git a/package/qt6/qt6base/Config.in b/package/qt6/qt6base/Config.in
> > index 3b15d40c83..5b598aa938 100644
> > --- a/package/qt6/qt6base/Config.in
> > +++ b/package/qt6/qt6base/Config.in
> > @@ -1,3 +1,6 @@
> > +config BR2_PACKAGE_HOST_QT6BASE_GUI
> > +	bool
> My question to other maintainers: do we want this blind option that
> allows to enable GUI support in the *host* qt6base to be present in the
> Config.in file (normally reserved for options for the target package),
> or do we want a simple Config.in.host, which even if it doesn't have a
> visible option for host-qt6base would carry this blind option allowing
> to enable GUI support in host-qt6base ?

We have a few other host packages that have a no-prompt boolean option,
like dracut, eudev, patchelf, systemd.

The converse is non-existent; we only have ARCH_SUPPORTS for a few host
packages for languages:

    $ git grep -E 'config BR2_PACKAGE_HOST_' -- '*/Config.in'
    package/erlang/Config.in:config BR2_PACKAGE_HOST_ERLANG_ARCH_SUPPORTS
    package/mono/Config.in:config BR2_PACKAGE_HOST_MONO_ARCH_SUPPORTS
    package/openjdk/Config.in:config BR2_PACKAGE_HOST_OPENJDK_BIN_ARCH_SUPPORTS
    package/protobuf/Config.in:config BR2_PACKAGE_HOST_PROTOBUF_ARCH_SUPPORTS

So, yes, I'd rather have BR2_PACKAGE_HOST_QT6BASE_GUI in its own
Config.in.host.

Also, it is a bit weird that this is an option for a host package
without a kconfig symbol for the host package itself...

Also, adding the support for GUI in host qt6base should be in its own
patch, separate from the one introducing qt6shadertools.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot