[Buildroot] [PATCH] package/linux-firmware: change Amlogic Bluetooth binary path

[Buildroot] [PATCH] package/linux-firmware: change Amlogic Bluetooth binary path

[Yang Li]

remove bluetooth subdirectory, and use generic pattern aml_*
to install all bluetooth binary.

Signed-off-by: Yang Li <yang.li@amlogic.com>
---
 package/linux-firmware/linux-firmware.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/linux-firmware/linux-firmware.mk b/package/linux-firmware/linux-firmware.mk
index 13dbc6d98c..22ebecf6c6 100644
--- a/package/linux-firmware/linux-firmware.mk
+++ b/package/linux-firmware/linux-firmware.mk
@@ -53,7 +53,7 @@ endif
 
 # Amlogic SoC Bluetooth
 ifeq ($(BR2_PACKAGE_LINUX_FIRMWARE_AMLOGIC),y)
-LINUX_FIRMWARE_FILES += amlogic/bluetooth/*.bin
+LINUX_FIRMWARE_FILES += amlogic/aml_*
 LINUX_FIRMWARE_ALL_LICENSE_FILES += LICENSE.amlogic
 endif
 
-- 
2.42.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/linux-firmware: change Amlogic Bluetooth binary path

[Thomas Petazzoni via buildroot]

Hello Yang,

Thanks for your patch, which I have applied, after doing some changes,
see below.

On Tue, 2 Jul 2024 20:17:37 +0800
Yang Li <yang.li@amlogic.com> wrote:

> remove bluetooth subdirectory, and use generic pattern aml_*
> to install all bluetooth binary.

This commit log was not sufficient. It does not explain since when the
bluetooth/ directory has been removed. This information is absolutely
*critical* as it allows us to figure out whether this fix needs to be
backported or not to previous version of Buildroot. Therefore, I have
changed the commit log to:

    package/linux-firmware: change Amlogic Bluetooth binary path
    
    Since upstream commit 7d931f8afa51d83e9eaee3a3f449bc2f86a5edf3, which
    first appeared in linux-firmware 20240709, the amlogic bluetooth
    firmware files have been moved from amlogic/bluetooth/ to directly
    amlogic/.

>  # Amlogic SoC Bluetooth
>  ifeq ($(BR2_PACKAGE_LINUX_FIRMWARE_AMLOGIC),y)
> -LINUX_FIRMWARE_FILES += amlogic/bluetooth/*.bin
> +LINUX_FIRMWARE_FILES += amlogic/aml_*

The change from *.bin to aml_* looked unnecessary. As far as I can see,
all files still have a .bin extension, so this change looked
gratuitous, and was not explained in the commit log. So I kept the
*.bin for now. If needed a future commit can be made, with a proper
explanation as to why aml_* is a better wildcard.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/linux-firmware: change Amlogic Bluetooth binary path

[Yang Li]

Dear Thomas

Thanks for your help.


On 2024/7/10 5:32, Thomas Petazzoni wrote:
> [????????? thomas.petazzoni@bootlin.com ????????? https://aka.ms/LearnAboutSenderIdentification?????????????]
>
> [ EXTERNAL EMAIL ]
>
> Hello Yang,
>
> Thanks for your patch, which I have applied, after doing some changes,
> see below.
>
> On Tue, 2 Jul 2024 20:17:37 +0800
> Yang Li <yang.li@amlogic.com> wrote:
>
>> remove bluetooth subdirectory, and use generic pattern aml_*
>> to install all bluetooth binary.
> This commit log was not sufficient. It does not explain since when the
> bluetooth/ directory has been removed. This information is absolutely
> *critical* as it allows us to figure out whether this fix needs to be
> backported or not to previous version of Buildroot. Therefore, I have
> changed the commit log to:
>
>      package/linux-firmware: change Amlogic Bluetooth binary path
>
>      Since upstream commit 7d931f8afa51d83e9eaee3a3f449bc2f86a5edf3, which
>      first appeared in linux-firmware 20240709, the amlogic bluetooth
>      firmware files have been moved from amlogic/bluetooth/ to directly
>      amlogic/.

It's great!

>>   # Amlogic SoC Bluetooth
>>   ifeq ($(BR2_PACKAGE_LINUX_FIRMWARE_AMLOGIC),y)
>> -LINUX_FIRMWARE_FILES += amlogic/bluetooth/*.bin
>> +LINUX_FIRMWARE_FILES += amlogic/aml_*
> The change from *.bin to aml_* looked unnecessary. As far as I can see,
> all files still have a .bin extension, so this change looked
> gratuitous, and was not explained in the commit log. So I kept the
> *.bin for now. If needed a future commit can be made, with a proper
> explanation as to why aml_* is a better wildcard.

Well, It's all right with me.

Thanks again.

> Thanks!
>
> Thomas
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/linux-firmware: change Amlogic Bluetooth binary path

[Peter Korsgaard]

>>>>> "Thomas" == Thomas Petazzoni via buildroot <buildroot@buildroot.org> writes:

 > Hello Yang,
 > Thanks for your patch, which I have applied, after doing some changes,
 > see below.

 > On Tue, 2 Jul 2024 20:17:37 +0800
 > Yang Li <yang.li@amlogic.com> wrote:

 >> remove bluetooth subdirectory, and use generic pattern aml_*
 >> to install all bluetooth binary.

 > This commit log was not sufficient. It does not explain since when the
 > bluetooth/ directory has been removed. This information is absolutely
 > *critical* as it allows us to figure out whether this fix needs to be
 > backported or not to previous version of Buildroot. Therefore, I have
 > changed the commit log to:

 >     package/linux-firmware: change Amlogic Bluetooth binary path
    
 >     Since upstream commit 7d931f8afa51d83e9eaee3a3f449bc2f86a5edf3, which
 >     first appeared in linux-firmware 20240709, the amlogic bluetooth
 >     firmware files have been moved from amlogic/bluetooth/ to directly
 >     amlogic/.

How does that work? Master has LINUX_FIRMWARE_VERSION = 20240410,
E.G. an earlier version than that?

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH] package/linux-firmware: change Amlogic Bluetooth binary path

[Yang Li]

remove bluetooth subdirectory, and use generic pattern aml_*
to install all bluetooth binary.

Signed-off-by: Yang Li <yang.li@amlogic.com>
---
 package/linux-firmware/linux-firmware.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/linux-firmware/linux-firmware.mk b/package/linux-firmware/linux-firmware.mk
index 13dbc6d98c..22ebecf6c6 100644
--- a/package/linux-firmware/linux-firmware.mk
+++ b/package/linux-firmware/linux-firmware.mk
@@ -53,7 +53,7 @@ endif
 
 # Amlogic SoC Bluetooth
 ifeq ($(BR2_PACKAGE_LINUX_FIRMWARE_AMLOGIC),y)
-LINUX_FIRMWARE_FILES += amlogic/bluetooth/*.bin
+LINUX_FIRMWARE_FILES += amlogic/aml_*
 LINUX_FIRMWARE_ALL_LICENSE_FILES += LICENSE.amlogic
 endif
 
-- 
2.42.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH] package/linux-firmware: change Amlogic Bluetooth binary path

[Yang Li]

remove bluetooth subdirectory, and use generic pattern aml_*
to install all bluetooth binary.

Signed-off-by: Yang Li <yang.li@amlogic.com>
---
 package/linux-firmware/linux-firmware.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/linux-firmware/linux-firmware.mk b/package/linux-firmware/linux-firmware.mk
index 13dbc6d98c..22ebecf6c6 100644
--- a/package/linux-firmware/linux-firmware.mk
+++ b/package/linux-firmware/linux-firmware.mk
@@ -53,7 +53,7 @@ endif
 
 # Amlogic SoC Bluetooth
 ifeq ($(BR2_PACKAGE_LINUX_FIRMWARE_AMLOGIC),y)
-LINUX_FIRMWARE_FILES += amlogic/bluetooth/*.bin
+LINUX_FIRMWARE_FILES += amlogic/aml_*
 LINUX_FIRMWARE_ALL_LICENSE_FILES += LICENSE.amlogic
 endif
 
-- 
2.42.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot