Re: [Buildroot] [PATCH 1/2] package/qt5/qt5webkit: fix JavaScriptCore parser error

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

On Wed, 13 Mar 2024 23:46:09 +0100
Alexis Lothoré via buildroot <buildroot@buildroot.org> wrote:

> From: Alexis Lothoré <alexis.lothore@bootlin.com>
> 
> qt5webkit build currently fails with the following error:
> 
> [...] parser.rb:587:in `block in parseSequence': undefined method `=~' for an instance of Annotation (NoMethodError)
>   from <internal:kernel>:187:in `loop'
>   from /home/alexis/src/buildroot_min/output/build/qt5webkit-5.212.0-alpha4/Source/JavaScriptCore/offlineasm/parser.rb:586:in `parseSequence'
>   from /home/alexis/src/buildroot_min/output/build/qt5webkit-5.212.0-alpha4/Source/JavaScriptCore/offlineasm/parser.rb:654:in `block in parseSequence'
>   from <internal:kernel>:187:in `loop'
>   from /home/alexis/src/buildroot_min/output/build/qt5webkit-5.212.0-alpha4/Source/JavaScriptCore/offlineasm/parser.rb:586:in `parseSequence'
>   from /home/alexis/src/buildroot_min/output/build/qt5webkit-5.212.0-alpha4/Source/JavaScriptCore/offlineasm/parser.rb:814:in `parseData'
>   from /home/alexis/src/buildroot_min/output/build/qt5webkit-5.212.0-alpha4/Source/JavaScriptCore/offlineasm/parser.rb:818:in `parse'
>   from /home/alexis/src/buildroot_min/output/build/qt5webkit-5.212.0-alpha4/Source/JavaScriptCore/offlineasm/parser.rb:780:in `block in parseSequence'
>   from <internal:kernel>:187:in `loop'
>   from /home/alexis/src/buildroot_min/output/build/qt5webkit-5.212.0-alpha4/Source/JavaScriptCore/offlineasm/parser.rb:586:in `parseSequence'
>   from /home/alexis/src/buildroot_min/output/build/qt5webkit-5.212.0-alpha4/Source/JavaScriptCore/offlineasm/parser.rb:625:in `block in parseSequence'
>   from <internal:kernel>:187:in `loop'
>   from /home/alexis/src/buildroot_min/output/build/qt5webkit-5.212.0-alpha4/Source/JavaScriptCore/offlineasm/parser.rb:586:in `parseSequence'
>   from /home/alexis/src/buildroot_min/output/build/qt5webkit-5.212.0-alpha4/Source/JavaScriptCore/offlineasm/parser.rb:814:in `parseData'
>   from /home/alexis/src/buildroot_min/output/build/qt5webkit-5.212.0-alpha4/Source/JavaScriptCore/offlineasm/parser.rb:818:in `parse'
>   from /home/alexis/src/buildroot_min/output/build/qt5webkit-5.212.0-alpha4/Source/JavaScriptCore/offlineasm/generate_offset_extractor.rb:68:in `<main>'
> 
> This issue is due to =~ being marked as deprecated since a few Ruby
> versions, and finally removed in 3.2.0 [1]. This now breaks the build since
> buildroot has moved to Ruby v3.3.0.
> The corresponding fix has already been issued in upstream Webkit project
> [2], but qt5webkit version tracked in buildroot does not have the
> corresponding webkit version pulled. Fix this build error by bringing the upstream
> patch. The patch is slightly modified (exclude part about Changelog file,
> which is absent from qt5webkit)
> 
> [1] https://www.ruby-lang.org/en/news/2022/12/25/ruby-3-2-0-released/
> [2] https://github.com/WebKit/WebKit/commit/c7d19a492d97f9282a546831beb918e03315f6ef
> 
> Signed-off-by: Alexis Lothoré <alexis.lothore@bootlin.com>
> ---
>  ...ngs-with-newer-Ruby-versions-https-b.patch | 48 +++++++++++++++++++
>  1 file changed, 48 insertions(+)
>  create mode 100644 package/qt5/qt5webkit/0007-Offlineasm-warnings-with-newer-Ruby-versions-https-b.patch

Applied to master after adding a reference to the autobuilder issue
being fixed by this commit. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot