Re: [Buildroot] [PATCH 2/2] package/qt5/qt5webkit: fix WebCore compatibility issue with updated libxml2

From: Peter Korsgaard <peter@korsgaard.com>
To: "Alexis Lothoré via buildroot" <buildroot@buildroot.org>
Cc: "Giulio Benetti" <giulio.benetti@benettiengineering.com>,
	"Alexis Lothoré" <alexis.lothore@bootlin.com>,
	"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
	"Julien Corjon" <corjon.j@ecagroup.com>
Subject: Re: [Buildroot] [PATCH 2/2] package/qt5/qt5webkit: fix WebCore compatibility issue with updated libxml2
Date: Wed, 31 Jul 2024 18:35:20 +0200	[thread overview]
Message-ID: <878qxhtt87.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20240313224610.2743219-3-alexis.lothore@bootlin.com> ("Alexis Lothoré via buildroot"'s message of "Wed, 13 Mar 2024 23:46:10 +0100")

>>>>> "Alexis" == Alexis Lothoré via buildroot <buildroot@buildroot.org> writes:

 > From: Alexis Lothoré <alexis.lothore@bootlin.com>
 > qt5webkit build currently breaks on the following error:

 > XSLStyleSheetLibxslt.cpp:148:129: error: invalid conversion from ‘void
 > (*)(void*, xmlError*)’ {aka ‘void (*)(void*, _xmlError*)’} to
 > ‘xmlStructuredErrorFunc’ {aka ‘void (*)(void*, const _xmlError*)’}
 > [-fpermissive]
 >   148 | XMLDocumentParserScope scope(cachedResourceLoader(),
 > XSLTProcessor::genericErrorFunc, XSLTProcessor::parseErrorFunc,
 > console);
 >       |                                                                                                                                 ^
 >       |                                                                                                                                 |
 >       |                                                                                                                                 void
 >       | (*)(void*, xmlError*) {aka void (*)(void*, _xmlError*)}

 > This error is due to an API update in libxml2, enforcing const on more
 > struct in version 2.12.0 (see [1]). Buildroot now tracks v2.12.5.
 > Upstream Webkit project has already issued the corresponding fix ([2]),
 > which updates corresponding internal prototypes depending on libxml2
 > version, but the qt5webkit version tracked in buildroot does not integrate
 > the corresponding Webkit version.

 > Fix this build issue by bringing the upstream patch "as is" from Webkit

 > [1] https://gitlab.gnome.org/GNOME/libxml2/-/releases/v2.12.0
 > [2] https://github.com/WebKit/WebKit/commit/1bad176b2496579d760852c80cff3ad9fb7c3a4b

 > Signed-off-by: Alexis Lothoré <alexis.lothore@bootlin.com>

Committed to 2024.02.x and 2024.05.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot