Re: [Buildroot] [PATCH 2/2] package/qt5/qt5webkit: fix WebCore compatibility issue with updated libxml2

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

On Wed, 13 Mar 2024 23:46:10 +0100
Alexis Lothoré via buildroot <buildroot@buildroot.org> wrote:

> From: Alexis Lothoré <alexis.lothore@bootlin.com>
> 
> qt5webkit build currently breaks on the following error:
> 
> XSLStyleSheetLibxslt.cpp:148:129: error: invalid conversion from ‘void (*)(void*, xmlError*)’ {aka ‘void (*)(void*, _xmlError*)’} to ‘xmlStructuredErrorFunc’ {aka ‘void (*)(void*, const _xmlError*)’} [-fpermissive]
>   148 |     XMLDocumentParserScope scope(cachedResourceLoader(), XSLTProcessor::genericErrorFunc, XSLTProcessor::parseErrorFunc, console);
>       |                                                                                                                                 ^
>       |                                                                                                                                 |
>       |                                                                                                                                 void (*)(void*, xmlError*) {aka void (*)(void*, _xmlError*)}
> 
> This error is due to an API update in libxml2, enforcing const on more
> struct in version 2.12.0 (see [1]). Buildroot now tracks v2.12.5.
> Upstream Webkit project has already issued the corresponding fix ([2]),
> which updates corresponding internal prototypes depending on libxml2
> version, but the qt5webkit version tracked in buildroot does not integrate
> the corresponding Webkit version.
> 
> Fix this build issue by bringing the upstream patch "as is" from Webkit
> 
> [1] https://gitlab.gnome.org/GNOME/libxml2/-/releases/v2.12.0
> [2] https://github.com/WebKit/WebKit/commit/1bad176b2496579d760852c80cff3ad9fb7c3a4b
> 
> Signed-off-by: Alexis Lothoré <alexis.lothore@bootlin.com>
> ---
>  ...-libxml2-version-2.12.0-due-to-API-c.patch | 61 +++++++++++++++++++
>  1 file changed, 61 insertions(+)
>  create mode 100644 package/qt5/qt5webkit/0008-Build-fails-with-libxml2-version-2.12.0-due-to-API-c.patch

Applied to master, thanks. I couldn't add any autobuilder reference,
because this issue was apparently "hidden" behind the issue fixed in
PATCH 1/2. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot