[Buildroot] [PATCH 1/1] package/prelink-cross: bump to version ff2561c02ade96c5d4d56ddd4e27ff064840a176

[Buildroot] [PATCH 1/1] package/prelink-cross: bump to version ff2561c02ade96c5d4d56ddd4e27ff064840a176

[James Hilliard]

Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
---
 package/prelink-cross/prelink-cross.hash | 2 +-
 package/prelink-cross/prelink-cross.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/prelink-cross/prelink-cross.hash b/package/prelink-cross/prelink-cross.hash
index 4aa3a86c45..286fef9fc3 100644
--- a/package/prelink-cross/prelink-cross.hash
+++ b/package/prelink-cross/prelink-cross.hash
@@ -1,3 +1,3 @@
 # Locally computed
-sha256  ce0d58b7c60a441fd61c52329e2c767f7888056c491f55627a5304b13fda743f  prelink-cross-440c0059a21f06b5577499a80b55482cb99d6d1c-git4.tar.gz
+sha256  a8fdf6e96032d2300102c549bdb4d961fef4e546874d79cda1f88fa07912e30c  prelink-cross-ff2561c02ade96c5d4d56ddd4e27ff064840a176-git4.tar.gz
 sha256  b8a2f73f743dc1a51aff23f1aacbca4b868564db52496fa3c0caba755bfd1eaf  COPYING
diff --git a/package/prelink-cross/prelink-cross.mk b/package/prelink-cross/prelink-cross.mk
index c32ea74afd..e554a423d4 100644
--- a/package/prelink-cross/prelink-cross.mk
+++ b/package/prelink-cross/prelink-cross.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-PRELINK_CROSS_VERSION = 440c0059a21f06b5577499a80b55482cb99d6d1c
+PRELINK_CROSS_VERSION = ff2561c02ade96c5d4d56ddd4e27ff064840a176
 PRELINK_CROSS_SITE = https://git.yoctoproject.org/git/prelink-cross
 PRELINK_CROSS_SITE_METHOD = git
 PRELINK_CROSS_LICENSE = GPL-2.0+
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/prelink-cross: bump to version ff2561c02ade96c5d4d56ddd4e27ff064840a176

[Thomas Petazzoni via buildroot]

On Fri, 12 Jul 2024 14:19:43 -0600
James Hilliard <james.hilliard1@gmail.com> wrote:

> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
>  package/prelink-cross/prelink-cross.hash | 2 +-
>  package/prelink-cross/prelink-cross.mk   | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/prelink-cross: bump to version ff2561c02ade96c5d4d56ddd4e27ff064840a176

[Thomas Petazzoni via buildroot]

Hello James,

On Fri, 12 Jul 2024 14:19:43 -0600
James Hilliard <james.hilliard1@gmail.com> wrote:

> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>

It would have been *really* nice if you could have pointed out that
this commit fixes a build issue that was occurring in the autobuilder.
The only commit brought by your version bump is an upstream commit of
you to fix the build issue, but you did not even mention it here.

This fixes:

  http://autobuild.buildroot.net/results/e0f46983dafdc7d309e6cdfdeda268c582a03156/build-end.log

which was occurring with version
440c0059a21f06b5577499a80b55482cb99d6d1c.

But also fixes:

  http://autobuild.buildroot.net/results/a9de4890fd2499842a26abc8f595f43206e4bdc1/build-end.log

which was occurring with the previous version,
a853a5d715d84eec93aa68e8f2df26b7d860f5b2.

Peter: it means this version bump is actually fixing an issue that
occurs on 2024.02, so this version bump should be backported to our LTS
branch.

James: this is why we ask for more explanations, so that we can figure
out whether a certain commit is relevant or not for our LTS branch.

Thanks for your contribution!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/prelink-cross: bump to version ff2561c02ade96c5d4d56ddd4e27ff064840a176

[James Hilliard]

On Sat, Jul 13, 2024 at 6:15 AM Thomas Petazzoni
<thomas.petazzoni@bootlin.com> wrote:
>
> Hello James,
>
> On Fri, 12 Jul 2024 14:19:43 -0600
> James Hilliard <james.hilliard1@gmail.com> wrote:
>
> > Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
>
> It would have been *really* nice if you could have pointed out that
> this commit fixes a build issue that was occurring in the autobuilder.
> The only commit brought by your version bump is an upstream commit of
> you to fix the build issue, but you did not even mention it here.
>
> This fixes:
>
>   http://autobuild.buildroot.net/results/e0f46983dafdc7d309e6cdfdeda268c582a03156/build-end.log
>
> which was occurring with version
> 440c0059a21f06b5577499a80b55482cb99d6d1c.
>
> But also fixes:
>
>   http://autobuild.buildroot.net/results/a9de4890fd2499842a26abc8f595f43206e4bdc1/build-end.log
>
> which was occurring with the previous version,
> a853a5d715d84eec93aa68e8f2df26b7d860f5b2.

Well, it probably would happen with all previous versions, note the issue
was due to a major compiler version update in my autobuilders and does
not affect systems running older GCC versions.

I generally lock my arch autobuilders to master branch since there tends
to be a ton of breakage on LTS branches for them which creates a lot of
noise due to lots of build failures.

>
> Peter: it means this version bump is actually fixing an issue that
> occurs on 2024.02, so this version bump should be backported to our LTS
> branch.
>
> James: this is why we ask for more explanations, so that we can figure
> out whether a certain commit is relevant or not for our LTS branch.

Do we backport build host major compiler version update fixes to LTS
branches?

>
> Thanks for your contribution!
>
> Thomas
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/prelink-cross: bump to version ff2561c02ade96c5d4d56ddd4e27ff064840a176

[Thomas Petazzoni via buildroot]

On Sat, 13 Jul 2024 11:47:57 -0600
James Hilliard <james.hilliard1@gmail.com> wrote:

> > Peter: it means this version bump is actually fixing an issue that
> > occurs on 2024.02, so this version bump should be backported to our LTS
> > branch.
> >
> > James: this is why we ask for more explanations, so that we can figure
> > out whether a certain commit is relevant or not for our LTS branch.  
> 
> Do we backport build host major compiler version update fixes to LTS
> branches?

No, but when a fix is made by a bump, we need to know it to then decide
whether (or not) it should be backported to LTS branches.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/prelink-cross: bump to version ff2561c02ade96c5d4d56ddd4e27ff064840a176

[Thomas Petazzoni via buildroot]

Hello James,

On Fri, 12 Jul 2024 14:19:43 -0600
James Hilliard <james.hilliard1@gmail.com> wrote:

> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
>  package/prelink-cross/prelink-cross.hash | 2 +-
>  package/prelink-cross/prelink-cross.mk   | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Unfortunately, I had to revert this bump (and the previous one),
because it was causing breakage for the two things in Buildroot that
use host-prelink-cross. Indeed, newer versions of prelink-cross no
longer build/install prelink-rtld, and that breaks
gobject-instrospection and dracut.

Note that I did keep the patch that you added to fix the build issue,
and verified that host-prelink-cross continues to build on a machine
with host GCC 14.x.

I think investigating prelink-cross is probably not worth it.

Indeed, in gobject-introspection, the use of prelink-rtld can be
replaced by "objdump -p".
See https://git.openembedded.org/openembedded-core/commit/meta/recipes-gnome/gobject-introspection?id=767e0880d4d729e659e859dd99c1cdb084b8ba51 for inspiration.

And in dracut, I believe the same could be done as well (though I have
not investigated in detail).

This would allow to get rid of the prelink-cross package entirely.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot