[Buildroot] [PATCH 1/1] Revert "package/crun: allow building with uClibc"

[Buildroot] [PATCH 1/1] Revert "package/crun: allow building with uClibc"

[Fabrice Fontaine]

This reverts commit 223596c75d73a7eb29152235d3c5d9bf53bd58f5 indeed
fexecve is only available since
https://github.com/wbx-github/uclibc-ng/commit/858ffad217076227089cc17eb832db0bd1497792
resulting in the following build failure with uclibc < 1.0.33:

/home/thomas/autobuild/instance-3/output-1/host/opt/ext-toolchain/bin/../lib/gcc/arceb-snps-linux-uclibc/9.2.1/../../../../arceb-snps-linux-uclibc/bin/ld: libcrun_testing.a(libcrun_testing_a-cloned_binary.o): in function `ensure_cloned_binary':
/home/thomas/autobuild/instance-3/output-1/build/crun-1.8.4/src/libcrun/cloned_binary.c:540: undefined reference to `fexecve'

Fixes: 223596c75d73a7eb29152235d3c5d9bf53bd58f5
 - http://autobuild.buildroot.org/results/9c4488d5d26e575f39bcbaed8e0793ed1cdb8cd5

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/crun/Config.in | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/package/crun/Config.in b/package/crun/Config.in
index f6a1ec7c66..bbed21817e 100644
--- a/package/crun/Config.in
+++ b/package/crun/Config.in
@@ -1,8 +1,9 @@
 config BR2_PACKAGE_CRUN
 	bool "crun"
 	depends on BR2_USE_MMU # fork()
+	depends on !BR2_TOOLCHAIN_USES_UCLIBC # no fexecve
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # C11/stdatomic.h
-	select BR2_PACKAGE_ARGP_STANDALONE if !BR2_TOOLCHAIN_USES_GLIBC
+	select BR2_PACKAGE_ARGP_STANDALONE if BR2_TOOLCHAIN_USES_MUSL
 	select BR2_PACKAGE_YAJL # libocispec
 	help
 	  crun is a fast and low-memory OCI Container Runtime in C.
-- 
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] Revert "package/crun: allow building with uClibc"

[Thomas Petazzoni via buildroot]

Hello,

+Alexey for ARC specific topic/question.

On Tue, 13 Feb 2024 22:05:23 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> This reverts commit 223596c75d73a7eb29152235d3c5d9bf53bd58f5 indeed
> fexecve is only available since
> https://github.com/wbx-github/uclibc-ng/commit/858ffad217076227089cc17eb832db0bd1497792
> resulting in the following build failure with uclibc < 1.0.33:
> 
> /home/thomas/autobuild/instance-3/output-1/host/opt/ext-toolchain/bin/../lib/gcc/arceb-snps-linux-uclibc/9.2.1/../../../../arceb-snps-linux-uclibc/bin/ld: libcrun_testing.a(libcrun_testing_a-cloned_binary.o): in function `ensure_cloned_binary':
> /home/thomas/autobuild/instance-3/output-1/build/crun-1.8.4/src/libcrun/cloned_binary.c:540: undefined reference to `fexecve'
> 
> Fixes: 223596c75d73a7eb29152235d3c5d9bf53bd58f5
>  - http://autobuild.buildroot.org/results/9c4488d5d26e575f39bcbaed8e0793ed1cdb8cd5
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/crun/Config.in | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

I don't think this is the right fix. The issue is occurring here with
the rather old Synopsys ARC toolchain, of which we're using version
2019.09. Turns out
that https://github.com/foss-for-synopsys-dwc-arc-processors/toolchain/releases/
has much much newer versions available, so the right fix really would be to
upgrade.

Alexey, do you think someone on your side could work on this? Unless
Fabrice you're interested in having a look?

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] Revert "package/crun: allow building with uClibc"

[Alexey Brodkin via buildroot]

Hi Thomas, Fabrice,

> +Alexey for ARC specific topic/question.
> 
> On Tue, 13 Feb 2024 22:05:23 +0100
> Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> 
> > This reverts commit 223596c75d73a7eb29152235d3c5d9bf53bd58f5 indeed
> > fexecve is only available since
> > https://github.com/wbx-github/uclibc-ng/commit/858ffad217076227089cc17eb832db0bd1497792
> > resulting in the following build failure with uclibc < 1.0.33:
> >
> > /home/thomas/autobuild/instance-3/output-1/host/opt/ext-toolchain/bin/../lib/gcc/arceb-snps-linux-uclibc/9.2.1/../../../../arceb-snps-linux-uclibc/bin/ld: libcrun_testing.a(libcrun_testing_a-cloned_binary.o): in function `ensure_cloned_binary':
> > /home/thomas/autobuild/instance-3/output-1/build/crun-1.8.4/src/libcrun/cloned_binary.c:540: undefined reference to `fexecve'
> >
> > Fixes: 223596c75d73a7eb29152235d3c5d9bf53bd58f5
> >  - http://autobuild.buildroot.org/results/9c4488d5d26e575f39bcbaed8e0793ed1cdb8cd5/
> >
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> > ---
> >  package/crun/Config.in | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> I don't think this is the right fix. The issue is occurring here with
> the rather old Synopsys ARC toolchain, of which we're using version
> 2019.09. Turns out
> that https://github.com/foss-for-synopsys-dwc-arc-processors/toolchain/releases/
> has much much newer versions available, so the right fix really would be to
> upgrade.

Indeed, makes no sense to mess with such an old toolchian.

> Alexey, do you think someone on your side could work on this? Unless
> Fabrice you're interested in having a look?

Sure, we're about to publish the most recent arc-2024.06 toolchain (planned for next week)
and as a part of that release process, we'll update Buildroot's version.

While we're at it though, may I kindly ask you to revisit my old patchset [1]
where I add ARCv3 ISA processors support? If there're no concerns regarding that stale
series, we'll rebase it on top of the current master and it will go nicely along with
arc-2024.06 release as we have ARCv3 support there together with the rest of ARC Classic cores.

[1] https://patchwork.ozlabs.org/project/buildroot/list/?series=389160

-Alexey
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot