From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Julien Olivain <ju.o@free.fr>
Cc: "Yann E. MORIN" <yann.morin.1998@free.fr>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/2] support/testing: test_audio_codec_base.py: new helper class
Date: Tue, 6 Aug 2024 23:24:42 +0200 [thread overview]
Message-ID: <20240806232442.0d61058c@windsurf> (raw)
In-Reply-To: <20240615091612.9579-1-ju.o@free.fr>
On Sat, 15 Jun 2024 11:16:11 +0200
Julien Olivain <ju.o@free.fr> wrote:
> This is a helper class providing a template for testing audio codec
> programs such as lame mp3 encoder, flac tools, ogg vorbis-tools, ...
>
> Signed-off-by: Julien Olivain <ju.o@free.fr>
> ---
> DEVELOPERS | 1 +
> .../tests/package/test_audio_codec_base.py | 86 +++++++++++++++++++
> 2 files changed, 87 insertions(+)
> create mode 100644 support/testing/tests/package/test_audio_codec_base.py
Thanks, series applied!
Yann: I have read your good feedback and arguments, but I believe
Julien gave some solid explanations/counter-arguments. Generally
speaking, what Julien proposed is well aligned with the current
"philosophy" of the test cases, so I decided to apply. Also, if we were
to change how abstract test classes are done, we should rework it in a
global manner for all test cases, and not have multiple ways of doing
the same thing in different test cases.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2024-08-06 21:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-15 9:16 [Buildroot] [PATCH 1/2] support/testing: test_audio_codec_base.py: new helper class Julien Olivain
2024-06-15 9:16 ` [Buildroot] [PATCH 2/2] support/testing: add lame runtime test Julien Olivain
2024-06-15 18:09 ` [Buildroot] [PATCH 1/2] support/testing: test_audio_codec_base.py: new helper class Yann E. MORIN
2024-06-21 14:40 ` Julien Olivain
2024-08-07 19:35 ` Thomas Petazzoni via buildroot
2024-08-07 21:09 ` Julien Olivain
2024-08-07 21:20 ` Thomas Petazzoni via buildroot
2024-08-06 21:24 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240806232442.0d61058c@windsurf \
--to=buildroot@buildroot.org \
--cc=ju.o@free.fr \
--cc=thomas.petazzoni@bootlin.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox