Re: [Buildroot] [PATCH 1/2] support/testing: test_audio_codec_base.py: new helper class

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello,

On Wed, 07 Aug 2024 23:09:00 +0200
Julien Olivain <ju.o@free.fr> wrote:

> I think the reason the test gets registered many times is because the
> "abstract" class contains a test_run() function. The way nose2 scans
> for test will search in all the class hierarchy. The only way to
> prevent that for now is the __test__ = False.
> 
> We can see the selection of test if we add debug in nose2 discovery:
> 
>      nose2.discover(argv=[script_path,
>                           "-s", test_dir,
>                           "-v",
>                           "--collect-only",
>                           "--log-level", "debug"],
>                     plugins=["nose2.plugins.collect"])
> 
> in support/testing/run-tests, and invoking with "run-tests -l".
> 
> The reason I've put a test_run() function in the abstract class is 
> because
> I would like to keep the same test sequence for all those audio tests.

Right, and I think it makes sense.

> Maybe nose2 discovery should not recurse in the class hierarchy? The 
> only
> way I to prevent that would be to modify the loader at:
> https://github.com/nose-devs/nose2/blob/main/nose2/plugins/loader/discovery.py
> 
> Would you like me to propose a change of this nose2 behavior?

No strong opinion. I'm not particularly attached to nose2. I think
someone mentioned pytest as an alternative?

I don't know if nose2 is still actively developed, if it makes sense to
"invest" in this compared to some other solutions.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot