Re: [Buildroot] [PATCH 1/2] support/testing: test_audio_codec_base.py: new helper class

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Julien,

On Fri, 21 Jun 2024 14:40:20 +0000
Julien Olivain <ju.o@free.fr> wrote:

> Renaming the "test_audio_codec_base.py" file to "audio_codec_base.py",
> and the "TestAudioCodecBase" class to "AudioCodecBase" will not
> prevent the test to be discovered by Nose2. This will prevent the file
> and class to be selected at first. But if "__test__ = False" is not
> present, it will still be indirectly loaded from the TestLame
> import. This can be seen by adding "--log-level debug" in nose2
> arguments.
> 
> While I do agree we could rename the file and class to better show the
> intent this is an "abstract" class which does not include a test, I
> think the "__test__ = False" needs to stay here to really prevent it
> being loaded.

Apparently, not. Look at:

  https://patchwork.ozlabs.org/project/buildroot/patch/f57167b1488b3c5ad76362dd8bca1b12d281aa19.1696522656.git.yann.morin.1998@free.fr/

proposed by Yann. The abstract class doesn't start with Test, it
doesn't have __test__ = false, and it isn't considered as a test by
nose2.

Now, look at:

  https://patchwork.ozlabs.org/project/buildroot/patch/33ee4b08c20f9c4566cfe82c648f01599cab70b5.1696522656.git.yann.morin.1998@free.fr/

which uses multiple inheritance, doesn't defined __test__ = true, and
is properly considered by nose2.

Could you have a look as to why this pattern wouldn't work for your
audio codec situation?

Thanks a lot,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot