Re: [Buildroot] [PATCH next] board/friendlyarm/nanopi-neo: fix uboot partition size

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello,

On Fri, 16 Aug 2024 01:28:26 +0800
Dong Wang <wangdong115@foxmail.com> wrote:

> This patch fixes the wrongly calculated uboot partition size in
> genimage.cfg. The size should be 1016K, which is
> 1MB (typical partition start) - 8K(offset dictated by the bootrom).
> 
> Signed-off-by: Dong Wang <wangdong115@foxmail.com>
> ---
>  board/friendlyarm/nanopi-neo/genimage.cfg | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/board/friendlyarm/nanopi-neo/genimage.cfg b/board/friendlyarm/nanopi-neo/genimage.cfg
> index ec78fd0e56..8d6bdd3295 100644
> --- a/board/friendlyarm/nanopi-neo/genimage.cfg
> +++ b/board/friendlyarm/nanopi-neo/genimage.cfg
> @@ -7,7 +7,7 @@ image sdcard.img {
>  		in-partition-table = false
>  		image = "u-boot-sunxi-with-spl.bin"
>  		offset = 8K
> -		size = 1000K # 1MB - 8KB(offset) - 16KB(GPT)
> +		size = 1016K # 1MB - 8KB(offset)

Actually, does this size argument really make sense? This space will
automatically take the size of the "u-boot-sunxi-with-spl.bin" file I
believe. Or is it needed to make sure that the next partition doesn't
start before 1 MB?

Why is it important that the size is 1MB - 8KB, and not 1MB or 2MB ?

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot