Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Dong Wang <wangdong115@foxmail.com>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH next] board/friendlyarm/nanopi-neo: fix uboot partition size
Date: Thu, 15 Aug 2024 19:50:27 +0200	[thread overview]
Message-ID: <Zr4_46ILTkziZpJU@landeda> (raw)
In-Reply-To: <tencent_C2D6061483906AA710B3001B277F4EE62606@qq.com>

Dong Wang, All,

Thanks for your contribution.

On 2024-08-16 01:28 +0800, Dong Wang spake thusly:
> This patch fixes the wrongly calculated uboot partition size in
> genimage.cfg. The size should be 1016K, which is
> 1MB (typical partition start) - 8K(offset dictated by the bootrom).

It seems you are using an old version of Buildroot, as the defconfig
and board files for nanopi_neo were removed with commit c0a44ba0dfbf
(configs/friendlyarm_nanopi_neo: drop defconfig), in August 2022, two
years ago.

If you are still using nanopi_neo and have access to that board, then
you are welcome to submit it again, of course!

Regards,
Yann E. MORIN.

> Signed-off-by: Dong Wang <wangdong115@foxmail.com>
> ---
>  board/friendlyarm/nanopi-neo/genimage.cfg | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/board/friendlyarm/nanopi-neo/genimage.cfg b/board/friendlyarm/nanopi-neo/genimage.cfg
> index ec78fd0e56..8d6bdd3295 100644
> --- a/board/friendlyarm/nanopi-neo/genimage.cfg
> +++ b/board/friendlyarm/nanopi-neo/genimage.cfg
> @@ -7,7 +7,7 @@ image sdcard.img {
>  		in-partition-table = false
>  		image = "u-boot-sunxi-with-spl.bin"
>  		offset = 8K
> -		size = 1000K # 1MB - 8KB(offset) - 16KB(GPT)
> +		size = 1016K # 1MB - 8KB(offset)
>  	}
>  
>  	partition rootfs {
> -- 
> 2.25.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2024-08-15 17:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-15 17:28 [Buildroot] [PATCH next] board/friendlyarm/nanopi-neo: fix uboot partition size Dong Wang
2024-08-15 17:50 ` Yann E. MORIN [this message]
2024-08-15 17:58   ` Darren Wang
2024-08-15 18:14     ` Yann E. MORIN
2024-08-15 18:19 ` Yann E. MORIN
2024-08-15 18:22   ` Dong Wang
2024-08-15 19:50 ` Thomas Petazzoni via buildroot
2024-08-15 20:00   ` Yann E. MORIN
2024-08-16 16:15     ` Dong Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zr4_46ILTkziZpJU@landeda \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@buildroot.org \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=wangdong115@foxmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox