Re: [Buildroot] [PATCH next] board/friendlyarm/nanopi-neo: fix uboot partition size

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Thomas, All,

On 2024-08-15 21:50 +0200, Thomas Petazzoni via buildroot spake thusly:
> On Fri, 16 Aug 2024 01:28:26 +0800
> Dong Wang <wangdong115@foxmail.com> wrote:
> > This patch fixes the wrongly calculated uboot partition size in
> > genimage.cfg. The size should be 1016K, which is
> > 1MB (typical partition start) - 8K(offset dictated by the bootrom).
[--SNIP--]
> > -		size = 1000K # 1MB - 8KB(offset) - 16KB(GPT)
> > +		size = 1016K # 1MB - 8KB(offset)
> Actually, does this size argument really make sense? This space will
> automatically take the size of the "u-boot-sunxi-with-spl.bin" file I
> believe. Or is it needed to make sure that the next partition doesn't
> start before 1 MB?
> 
> Why is it important that the size is 1MB - 8KB, and not 1MB or 2MB ?

The above has two effects:
  - ensure the uboot image is not bigger than the allocated space,
  - the filesystem image (rootfs) is aligned to a 1MiB boundary.

The latter could be achieved by setting offset=1MiB (or 2MiB or
whatever). I'm not sure how genimage would handle the case where the
uboot image would be too big that the offset of the next partition could
not be honored...

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot