[Buildroot] [PATCH 1/1] package/chrony: install default config

[Buildroot] [PATCH 1/1] package/chrony: install default config

[TIAN Yuanhao]

chrony needs a config file to work:
  Could not open /etc/chrony.conf : No such file or directory

Signed-off-by: TIAN Yuanhao <tianyuanhao3@163.com>
Cc: Peter Korsgaard <peter@korsgaard.com>
---
 package/chrony/chrony.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/chrony/chrony.mk b/package/chrony/chrony.mk
index e7e6931a2a..9ed9dcff56 100644
--- a/package/chrony/chrony.mk
+++ b/package/chrony/chrony.mk
@@ -71,6 +71,7 @@ endef
 
 define CHRONY_INSTALL_TARGET_CMDS
 	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) DESTDIR="$(TARGET_DIR)" install
+	$(INSTALL) -D -m 644 $(@D)/examples/chrony.conf.example2 $(TARGET_DIR)/etc/chrony.conf
 endef
 
 define CHRONY_INSTALL_INIT_SYSV
-- 
2.45.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/chrony: install default config

[Thomas Petazzoni via buildroot]

Hello,

On Fri, 30 Aug 2024 04:43:19 -0700
TIAN Yuanhao <tianyuanhao3@163.com> wrote:

> chrony needs a config file to work:
>   Could not open /etc/chrony.conf : No such file or directory
> 
> Signed-off-by: TIAN Yuanhao <tianyuanhao3@163.com>
> Cc: Peter Korsgaard <peter@korsgaard.com>

Thanks for this contribution. Question below.

>  define CHRONY_INSTALL_TARGET_CMDS
>  	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) DESTDIR="$(TARGET_DIR)" install
> +	$(INSTALL) -D -m 644 $(@D)/examples/chrony.conf.example2 $(TARGET_DIR)/etc/chrony.conf
>  endef

I'm not super familiar with chrony, but the question is: is there a
sensible "default configuration file" that makes sense for people as a
starting point?

For example, chrony ships with 3 example configuration files, and
you've decided to install example2. Why not example1 or example3?

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/chrony: install default config

[TIAN Yuanhao]

At 2024-08-31 01:11:33, "Thomas Petazzoni via buildroot" <buildroot@buildroot.org> wrote:
>Hello,
>
>On Fri, 30 Aug 2024 04:43:19 -0700
>TIAN Yuanhao <tianyuanhao3@163.com> wrote:
>
>> chrony needs a config file to work:
>>   Could not open /etc/chrony.conf : No such file or directory
>> 
>> Signed-off-by: TIAN Yuanhao <tianyuanhao3@163.com>
>> Cc: Peter Korsgaard <peter@korsgaard.com>
>
>Thanks for this contribution. Question below.
>
>>  define CHRONY_INSTALL_TARGET_CMDS
>>  	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) DESTDIR="$(TARGET_DIR)" install
>> +	$(INSTALL) -D -m 644 $(@D)/examples/chrony.conf.example2 $(TARGET_DIR)/etc/chrony.conf
>>  endef
>
>I'm not super familiar with chrony, but the question is: is there a
>sensible "default configuration file" that makes sense for people as a
>starting point?
>
>For example, chrony ships with 3 example configuration files, and
>you've decided to install example2. Why not example1 or example3?
>

chrony is mainly used to replace ntp in Linux distros of the RHEL family.

Many distros [1][2] use example 2 as the default config, and few distros (such as freeBSD [3]) use example 3.

Example 1 [4] is very brief. Example 2 [5] fully includes example 1 and sets the log directory. Example 3 [6] is almost entirely comments intended to serve as documentation.

[1]: https://github.com/microsoft/azurelinux/blob/3.0-stable/SPECS/chrony/chrony.spec#L72
[2]: https://github.com/vmware/photon/blob/5.0-Beta/SPECS/chrony/chrony.spec#L33
[3]: https://github.com/FreeBSDDesktop/freebsd-ports/blob/master/net/chrony/Makefile#L93-L94
[4]: https://gitlab.com/chrony/chrony/-/blob/3.5-stable/examples/chrony.conf.example1
[5]: https://gitlab.com/chrony/chrony/-/blob/3.5-stable/examples/chrony.conf.example2#L35
[6]: https://gitlab.com/chrony/chrony/-/blob/3.5-stable/examples/chrony.conf.example3#L30-34

>Thomas
>-- 
>Thomas Petazzoni, co-owner and CEO, Bootlin
>Embedded Linux and Kernel engineering and training
>https://bootlin.com

--
Regards,
TIAN Yuanhao
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/chrony: install default config

[Thomas Petazzoni via buildroot]

On Fri, 30 Aug 2024 04:43:19 -0700
TIAN Yuanhao <tianyuanhao3@163.com> wrote:

> chrony needs a config file to work:
>   Could not open /etc/chrony.conf : No such file or directory
> 
> Signed-off-by: TIAN Yuanhao <tianyuanhao3@163.com>
> Cc: Peter Korsgaard <peter@korsgaard.com>
> ---
>  package/chrony/chrony.mk | 1 +
>  1 file changed, 1 insertion(+)

I have extended your commit log with the great additional explanation
you provided as a reply to my feedback, and applied your patch to our
next branch. Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot