* [Buildroot] [PATCH] package/sysvinit: add version number to SYSVINIT_MAKE_OPTS [not found] ` <CAFQdmxJ-p8TV4wK=TJxUb0D8hGscODzXApgZviemrQiUEf+y1w@mail.gmail.com> @ 2024-10-05 14:15 ` Cody Green 2024-10-26 11:51 ` Thomas Petazzoni via buildroot 2024-11-11 10:35 ` Peter Korsgaard 0 siblings, 2 replies; 3+ messages in thread From: Cody Green @ 2024-10-05 14:15 UTC (permalink / raw) To: buildroot Version environment variable VERSION=$(VERSION) is set in the top level Makefile of the sysvinit: $(MAKE) VERSION=$(VERSION) -C src $@ Build command SYSVINIT_BUILD_CMDS doesn't use the top level Makefile, but src/Makefile instead without setting the VERSION variable, which leads to undefined VERSION macro in src/init.c. Add VERSION=$(SYSVINIT_VERSION) to SYSVINIT_MAKE_OPTS to make the VERSION environment variable available in the src/Makefile. Signed-off-by: Cody Green <cody@londelec.com> --- package/sysvinit/sysvinit.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/sysvinit/sysvinit.mk b/package/sysvinit/sysvinit.mk index 7f37cea131..e05a6dee38 100644 --- a/package/sysvinit/sysvinit.mk +++ b/package/sysvinit/sysvinit.mk @@ -11,7 +11,7 @@ SYSVINIT_LICENSE = GPL-2.0+ SYSVINIT_LICENSE_FILES = COPYING SYSVINIT_CPE_ID_VALID = YES -SYSVINIT_MAKE_OPTS = SYSROOT=$(STAGING_DIR) +SYSVINIT_MAKE_OPTS = SYSROOT=$(STAGING_DIR) VERSION=$(SYSVINIT_VERSION) ifeq ($(BR2_PACKAGE_LIBSELINUX),y) SYSVINIT_DEPENDENCIES += libselinux -- 2.39.2 _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH] package/sysvinit: add version number to SYSVINIT_MAKE_OPTS 2024-10-05 14:15 ` [Buildroot] [PATCH] package/sysvinit: add version number to SYSVINIT_MAKE_OPTS Cody Green @ 2024-10-26 11:51 ` Thomas Petazzoni via buildroot 2024-11-11 10:35 ` Peter Korsgaard 1 sibling, 0 replies; 3+ messages in thread From: Thomas Petazzoni via buildroot @ 2024-10-26 11:51 UTC (permalink / raw) To: Cody Green; +Cc: buildroot On Sat, 5 Oct 2024 15:15:39 +0100 Cody Green <cody@londelec.com> wrote: > Version environment variable VERSION=$(VERSION) is set in the top level > Makefile of the sysvinit: > $(MAKE) VERSION=$(VERSION) -C src $@ > > Build command SYSVINIT_BUILD_CMDS doesn't use the top level Makefile, but > src/Makefile instead without setting the VERSION variable, which leads to > undefined VERSION macro in src/init.c. > > Add VERSION=$(SYSVINIT_VERSION) to SYSVINIT_MAKE_OPTS to make the VERSION > environment variable available in the src/Makefile. > > Signed-off-by: Cody Green <cody@londelec.com> > --- > package/sysvinit/sysvinit.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied to master, thanks. Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH] package/sysvinit: add version number to SYSVINIT_MAKE_OPTS 2024-10-05 14:15 ` [Buildroot] [PATCH] package/sysvinit: add version number to SYSVINIT_MAKE_OPTS Cody Green 2024-10-26 11:51 ` Thomas Petazzoni via buildroot @ 2024-11-11 10:35 ` Peter Korsgaard 1 sibling, 0 replies; 3+ messages in thread From: Peter Korsgaard @ 2024-11-11 10:35 UTC (permalink / raw) To: Cody Green; +Cc: buildroot >>>>> "Cody" == Cody Green <cody@londelec.com> writes: > Version environment variable VERSION=$(VERSION) is set in the top level > Makefile of the sysvinit: > $(MAKE) VERSION=$(VERSION) -C src $@ > Build command SYSVINIT_BUILD_CMDS doesn't use the top level Makefile, but > src/Makefile instead without setting the VERSION variable, which leads to > undefined VERSION macro in src/init.c. > Add VERSION=$(SYSVINIT_VERSION) to SYSVINIT_MAKE_OPTS to make the VERSION > environment variable available in the src/Makefile. > Signed-off-by: Cody Green <cody@londelec.com> Committed to 2024.02.x and 2024.08.x, thanks. -- Bye, Peter Korsgaard _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-11-11 10:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CAFQdmxKcoojruP+5Cebkm_oqCzBx657NddiTJ+nJi_u0AChJzA@mail.gmail.com>
[not found] ` <CAFQdmxJ-p8TV4wK=TJxUb0D8hGscODzXApgZviemrQiUEf+y1w@mail.gmail.com>
2024-10-05 14:15 ` [Buildroot] [PATCH] package/sysvinit: add version number to SYSVINIT_MAKE_OPTS Cody Green
2024-10-26 11:51 ` Thomas Petazzoni via buildroot
2024-11-11 10:35 ` Peter Korsgaard
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox